mbox series

[v2,0/4] Match data improvements for mcp23s08 driver

Message ID 20230909121903.34062-1-biju.das.jz@bp.renesas.com
Headers show
Series Match data improvements for mcp23s08 driver | expand

Message

Biju Das Sept. 9, 2023, 12:18 p.m. UTC 
This patch series aims to add match data improvements for mcp23s08 driver.
This patch series is only compile tested.

v1->v2:
 * Arranged variable declaration in reverse xmas tree for patch#1.
 * Updated commit description for patch#2.
 * Dropped printing 'type' in error path for i2c_get_match_data().
 * Added similar simplification for SPI driver.
Biju Das (4):
  pinctrl: mcp23s08_i2c: Extend match support for OF tables
  pinctrl: mcp23s08_i2c: Simplify probe()
  pinctrl: mcp23s08_spi: Simplify probe()
  pinctrl: mcp23s08_spi: Simplify mcp23s08_spi_regmap_init()

 drivers/pinctrl/pinctrl-mcp23s08_i2c.c | 101 ++++++++++++-------------
 drivers/pinctrl/pinctrl-mcp23s08_spi.c | 101 +++++++++++++------------
 2 files changed, 100 insertions(+), 102 deletions(-)

Comments

Andy Shevchenko Sept. 11, 2023, 10:10 a.m. UTC | #1 
On Sat, Sep 09, 2023 at 01:18:59PM +0100, Biju Das wrote:
> This patch series aims to add match data improvements for mcp23s08 driver.
> This patch series is only compile tested.

Now, do you see the common grounds for unifying two data structure types you
created?

IN the common header you may introduce a type and use it in the both files.

For the patches 1 & 3 (the API simplification):
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>