mbox series

[SRU,F/J/L,0/1] CVE-2023-3772

Message ID 20230906223055.35186-1-yuxuan.luo@canonical.com
Headers show
Series CVE-2023-3772 | expand

Message

Yuxuan Luo Sept. 6, 2023, 10:30 p.m. UTC
[Impact]
A flaw was found in the Linux kernel’s IP framework for transforming
packets (XFRM subsystem). This issue may allow a malicious user with
CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
xfrm_update_ae_params(), leading to a possible kernel crash and denial of
service.

[Backport]
Clean cherry picks.
There are two .patch files because the one for Jammy and Lunar cannot be
applied clean on Focal using 'git am'.

[Test]
Compile and boot tested.

[Potential Regression]
Expect minial regression.

Lin Ma (1):
  xfrm: add NULL check in xfrm_update_ae_params

 net/xfrm/xfrm_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader Sept. 7, 2023, 7:48 a.m. UTC | #1
On 07.09.23 00:30, Yuxuan Luo wrote:
> [Impact]
> A flaw was found in the Linux kernel’s IP framework for transforming
> packets (XFRM subsystem). This issue may allow a malicious user with
> CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
> xfrm_update_ae_params(), leading to a possible kernel crash and denial of
> service.
> 
> [Backport]
> Clean cherry picks.
> There are two .patch files because the one for Jammy and Lunar cannot be
> applied clean on Focal using 'git am'.

If it is only minor context, "git am -C2" *sometimes* works.

> 
> [Test]
> Compile and boot tested.
> 
> [Potential Regression]
> Expect minial regression.
> 
> Lin Ma (1):
>    xfrm: add NULL check in xfrm_update_ae_params
> 
>   net/xfrm/xfrm_user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner Sept. 7, 2023, 2:42 p.m. UTC | #2
On 9/6/23 4:30 PM, Yuxuan Luo wrote:
> [Impact]
> A flaw was found in the Linux kernel’s IP framework for transforming
> packets (XFRM subsystem). This issue may allow a malicious user with
> CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
> xfrm_update_ae_params(), leading to a possible kernel crash and denial of
> service.
> 
> [Backport]
> Clean cherry picks.
> There are two .patch files because the one for Jammy and Lunar cannot be
> applied clean on Focal using 'git am'.
> 
> [Test]
> Compile and boot tested.
> 
> [Potential Regression]
> Expect minial regression.
> 
> Lin Ma (1):
>    xfrm: add NULL check in xfrm_update_ae_params
> 
>   net/xfrm/xfrm_user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Yuxuan Luo Sept. 7, 2023, 9:56 p.m. UTC | #3
On 9/7/23 03:48, Stefan Bader wrote:
> On 07.09.23 00:30, Yuxuan Luo wrote:
>> [Impact]
>> A flaw was found in the Linux kernel’s IP framework for transforming
>> packets (XFRM subsystem). This issue may allow a malicious user with
>> CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
>> xfrm_update_ae_params(), leading to a possible kernel crash and 
>> denial of
>> service.
>>
>> [Backport]
>> Clean cherry picks.
>> There are two .patch files because the one for Jammy and Lunar cannot be
>> applied clean on Focal using 'git am'.
>
> If it is only minor context, "git am -C2" *sometimes* works.

 From your perspective, would you prefer separate .patch files or a 
single file

with a note "this is a clean cherry pick for xxx releases"?

>
>>
>> [Test]
>> Compile and boot tested.
>>
>> [Potential Regression]
>> Expect minial regression.
>>
>> Lin Ma (1):
>>    xfrm: add NULL check in xfrm_update_ae_params
>>
>>   net/xfrm/xfrm_user.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Sept. 11, 2023, 9:33 a.m. UTC | #4
On 07.09.23 23:56, Yuxuan Luo wrote:
> 
> On 9/7/23 03:48, Stefan Bader wrote:
>> On 07.09.23 00:30, Yuxuan Luo wrote:
>>> [Impact]
>>> A flaw was found in the Linux kernel’s IP framework for transforming
>>> packets (XFRM subsystem). This issue may allow a malicious user with
>>> CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
>>> xfrm_update_ae_params(), leading to a possible kernel crash and 
>>> denial of
>>> service.
>>>
>>> [Backport]
>>> Clean cherry picks.
>>> There are two .patch files because the one for Jammy and Lunar cannot be
>>> applied clean on Focal using 'git am'.
>>
>> If it is only minor context, "git am -C2" *sometimes* works.
> 
>  From your perspective, would you prefer separate .patch files or a 
> single file
> 
> with a note "this is a clean cherry pick for xxx releases"?

A single file with note (that it might need reduced context for some 
series) as this is only one item to look at.
> 
>>
>>>
>>> [Test]
>>> Compile and boot tested.
>>>
>>> [Potential Regression]
>>> Expect minial regression.
>>>
>>> Lin Ma (1):
>>>    xfrm: add NULL check in xfrm_update_ae_params
>>>
>>>   net/xfrm/xfrm_user.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Sept. 15, 2023, 8:38 a.m. UTC | #5
On 07.09.23 00:30, Yuxuan Luo wrote:
> [Impact]
> A flaw was found in the Linux kernel’s IP framework for transforming
> packets (XFRM subsystem). This issue may allow a malicious user with
> CAP_NET_ADMIN privileges to directly dereference a NULL pointer in
> xfrm_update_ae_params(), leading to a possible kernel crash and denial of
> service.
> 
> [Backport]
> Clean cherry picks.
> There are two .patch files because the one for Jammy and Lunar cannot be
> applied clean on Focal using 'git am'.
> 
> [Test]
> Compile and boot tested.
> 
> [Potential Regression]
> Expect minial regression.
> 
> Lin Ma (1):
>    xfrm: add NULL check in xfrm_update_ae_params
> 
>   net/xfrm/xfrm_user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to lunar,jammy,focal:linux/master-next. Thanks.

-Stefan