diff mbox series

manual/jobs.texi: Add missing @item EPERM for getpgid

Message ID 20230824193634.1992046-1-mjw@redhat.com
State New
Headers show
Series manual/jobs.texi: Add missing @item EPERM for getpgid | expand

Commit Message

Mark Wielaard Aug. 24, 2023, 7:36 p.m. UTC
From: Mark Wielaard <mark@klomp.org>

The missing @item makes it look like errno will be set to ESRCH
if a cross-session getpgid is not permitted.

Found by ulfvonbelow on irc.
---
 manual/job.texi | 1 +
 1 file changed, 1 insertion(+)

Comments

Sam James Aug. 24, 2023, 7:55 p.m. UTC | #1
Mark Wielaard via Libc-alpha <libc-alpha@sourceware.org> writes:

> From: Mark Wielaard <mark@klomp.org>
>
> The missing @item makes it look like errno will be set to ESRCH
> if a cross-session getpgid is not permitted.
>
> Found by ulfvonbelow on irc.
> ---
>  manual/job.texi | 1 +
>  1 file changed, 1 insertion(+)

lgtm, thanks.

>
> diff --git a/manual/job.texi b/manual/job.texi
> index 42cb9fb26d..8157f13a1c 100644
> --- a/manual/job.texi
> +++ b/manual/job.texi
> @@ -1133,6 +1133,7 @@ following @code{errno} error conditions are defined for this function:
>  @table @code
>  @item ESRCH
>  There is no process with the given process ID @var{pid}.
> +@item EPERM
>  The calling process and the process specified by @var{pid} are in
>  different sessions, and the implementation doesn't allow to access the
>  process group ID of the process with ID @var{pid} from the calling
Mark Wielaard Aug. 25, 2023, 10:07 a.m. UTC | #2
Hi Sam,

On Thu, 2023-08-24 at 20:55 +0100, Sam James wrote:
> > From: Mark Wielaard <mark@klomp.org>
> > 
> > The missing @item makes it look like errno will be set to ESRCH
> > if a cross-session getpgid is not permitted.
> > 
> > Found by ulfvonbelow on irc.
> > ---
> >  manual/job.texi | 1 +
> >  1 file changed, 1 insertion(+)
> 
> lgtm, thanks.

Thanks. Pushed.

It is nice to immediately (after 15 minutes) see the updated snapshots
docs:
https://snapshots.sourceware.org/glibc/trunk/latest/manual/html_node/Process-Group-Functions.html#index-getpgid
Cheers,

Mark
diff mbox series

Patch

diff --git a/manual/job.texi b/manual/job.texi
index 42cb9fb26d..8157f13a1c 100644
--- a/manual/job.texi
+++ b/manual/job.texi
@@ -1133,6 +1133,7 @@  following @code{errno} error conditions are defined for this function:
 @table @code
 @item ESRCH
 There is no process with the given process ID @var{pid}.
+@item EPERM
 The calling process and the process specified by @var{pid} are in
 different sessions, and the implementation doesn't allow to access the
 process group ID of the process with ID @var{pid} from the calling