| Message ID | 20230626180920.318774-1-bgriffis@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] arm64: tegra: fix p3767 card detect polarity | expand |
On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote: > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low. > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX") > Signed-off-by: Brad Griffis <bgriffis@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This DTS include is also used by Jetson Orin NX, but I assume that the same polarity applies to that as well? Actually, looking at the Orin NX, I don't see an SD card slot and judging by the documentation that I was able to find it's not documented for Orin Nano either. Or is it only certain variants that were equipped with the SD slot? Thierry > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi > index bd60478fa75e..831a553ec387 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi > @@ -42,7 +42,7 @@ flash@0 { > mmc@3400000 { > status = "okay"; > bus-width = <4>; > - cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_HIGH>; > + cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>; > disable-wp; > }; > > -- > 2.25.1 >
On Fri, Jul 21, 2023 at 6:22 AM +0000, Thierry Reding wrote: > On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote: > > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low. > > > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX") > > Signed-off-by: Brad Griffis <bgriffis@nvidia.com> > > --- > > arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This DTS include is also used by Jetson Orin NX, but I assume that the same > polarity applies to that as well? The polarity is the same for all Orin NX/Nano modules that have SD card. > Actually, looking at the Orin NX, I don't see an SD card slot and judging by the > documentation that I was able to find it's not documented for Orin Nano > either. Or is it only certain variants that were equipped with the SD slot? UEFI dynamically disables this mmc instance on SKUs that do not support it.
On Tue, Aug 15, 2023 at 01:37:40PM +0000, Brad Griffis wrote: > On Fri, Jul 21, 2023 at 6:22 AM +0000, Thierry Reding wrote: > > On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote: > > > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low. > > > > > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX") > > > Signed-off-by: Brad Griffis <bgriffis@nvidia.com> > > > --- > > > arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This DTS include is also used by Jetson Orin NX, but I assume that the same > > polarity applies to that as well? > > The polarity is the same for all Orin NX/Nano modules that have SD card. > > > Actually, looking at the Orin NX, I don't see an SD card slot and judging by the > > documentation that I was able to find it's not documented for Orin Nano > > either. Or is it only certain variants that were equipped with the SD slot? > > UEFI dynamically disables this mmc instance on SKUs that do not support it. Okay, good. I've adjusted the commit message a tiny little bit to clarify that this applies to all NX/Nano SKUs that have an SD card slot equipped. Applied, thanks. Thierry
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi index bd60478fa75e..831a553ec387 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi @@ -42,7 +42,7 @@ flash@0 { mmc@3400000 { status = "okay"; bus-width = <4>; - cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>; disable-wp; };
The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low. Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX") Signed-off-by: Brad Griffis <bgriffis@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)