mbox series

[0/3] Allwinner R528/T113s PSCI

Message ID 20230812003055.74527-1-CFSworks@gmail.com
Headers show
Series Allwinner R528/T113s PSCI | expand

Message

Sam Edwards Aug. 12, 2023, 12:30 a.m. UTC 
Hi list,

With Andre's R528 support (hopefully) landing soon, I figure now is time to
submit these patches for review. They refactor the ARMv7/sunxi PSCI
implementation to allow for the new NCAT2 CPU complex control registers, and
add support for the R528/T113s.

Depends on series 365063.

Thanks,
Sam

Sam Edwards (3):
  sunxi: psci: clean away preprocessor macros
  sunxi: psci: refactor register access to separate functions
  sunxi: psci: implement PSCI on R528

 arch/arm/cpu/armv7/sunxi/psci.c | 185 +++++++++++++++++++++-----------
 arch/arm/mach-sunxi/Kconfig     |   2 +
 include/configs/sunxi-common.h  |   8 ++
 3 files changed, 133 insertions(+), 62 deletions(-)

Comments

Andre Przywara Aug. 14, 2023, 2:06 p.m. UTC | #1 
On Fri, 11 Aug 2023 18:30:52 -0600
Sam Edwards <cfsworks@gmail.com> wrote:

Hi Sam,

many many thanks for sending this, I especially like your clean up around
the #ifdef's!

The patches looks good on the first glance (apart from some regression in
patch 3/3), but I will reply to them individually.

Cheers,
Andre

> Hi list,
> 
> With Andre's R528 support (hopefully) landing soon, I figure now is time to
> submit these patches for review. They refactor the ARMv7/sunxi PSCI
> implementation to allow for the new NCAT2 CPU complex control registers, and
> add support for the R528/T113s.
> 
> Depends on series 365063.
> 
> Thanks,
> Sam
> 
> Sam Edwards (3):
>   sunxi: psci: clean away preprocessor macros
>   sunxi: psci: refactor register access to separate functions
>   sunxi: psci: implement PSCI on R528
> 
>  arch/arm/cpu/armv7/sunxi/psci.c | 185 +++++++++++++++++++++-----------
>  arch/arm/mach-sunxi/Kconfig     |   2 +
>  include/configs/sunxi-common.h  |   8 ++
>  3 files changed, 133 insertions(+), 62 deletions(-)
>
Sam Edwards Aug. 14, 2023, 6:31 p.m. UTC | #2 
On 8/14/23 08:06, Andre Przywara wrote:
> Hi Sam,
> 
> many many thanks for sending this, I especially like your clean up around
> the #ifdef's!
> 
> The patches looks good on the first glance (apart from some regression in
> patch 3/3), but I will reply to them individually.
> 
> Cheers,
> Andre

Thanks for your attention to these! While you're in a PSCI headspace, 
could you also look at my patch titled:
sunxi: psci: remove redundant initialization from psci_arch_init

...dated May 31?

This one should be pretty uncontroversial and straightforward to review. :)

Many thanks,
Sam