| Message ID | 20230720034835.88372-1-sasha.neftin@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [iwl-next,v2,1/1] igc: Decrease PTM short interval from 10 us to 1 us | expand |
Hi Sasha, > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Sasha Neftin > Sent: Thursday, 20 July, 2023 11:49 AM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/1] igc: Decrease PTM short > interval from 10 us to 1 us > > With the 10us interval, we were seeing PTM transactions take around 12us. > Hardware team suggested this interval could be lowered to 1us which was > confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around > 2us. > > Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> > --- > v1->v2: Fixed commit message > --- > drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h > b/drivers/net/ethernet/intel/igc/igc_defines.h > index 44a507029946..c3722f524ea7 100644 > --- a/drivers/net/ethernet/intel/igc/igc_defines.h > +++ b/drivers/net/ethernet/intel/igc/igc_defines.h > @@ -549,7 +549,7 @@ > #define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) > #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) > > -#define IGC_PTM_SHORT_CYC_DEFAULT 10 /* Default > Short/interrupted cycle interval */ > +#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle > interval */ > #define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time > */ > #define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default > timeout for PTM errors */ I tested this setting with my TGL-U board(back-2-back). As of now, I see no problem. Tested-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> LGTM. Reviewed-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > > -- > 2.34.1 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
On 7/20/2023 06:48, Sasha Neftin wrote: > With the 10us interval, we were seeing PTM transactions take around 12us. > Hardware team suggested this interval could be lowered to 1us which was > confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took > around 2us. > > Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> > --- > v1->v2: Fixed commit message > --- > drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Naama Meir <naamax.meir@linux.intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index 44a507029946..c3722f524ea7 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -549,7 +549,7 @@ #define IGC_PTM_CTRL_SHRT_CYC(usec) (((usec) & 0x2f) << 2) #define IGC_PTM_CTRL_PTM_TO(usec) (((usec) & 0xff) << 8) -#define IGC_PTM_SHORT_CYC_DEFAULT 10 /* Default Short/interrupted cycle interval */ +#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle interval */ #define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time */ #define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default timeout for PTM errors */
With the 10us interval, we were seeing PTM transactions take around 12us. Hardware team suggested this interval could be lowered to 1us which was confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around 2us. Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> --- v1->v2: Fixed commit message --- drivers/net/ethernet/intel/igc/igc_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)