| Message ID | 20230803230324.731268-1-rentao.bupt@gmail.com |
|---|---|
| Headers | show |
| Series | ARM: dts: aspeed: Fixup Wedge400 dts | expand |
On Thu, 3 Aug 2023 at 23:03, <rentao.bupt@gmail.com> wrote: > > From: Tao Ren <rentao.bupt@gmail.com> > > The patch series fixes a few entries in wedge400 device tree. > > Patch #1 sets spi alias in ast2500-facebook-netbmc-common.dtsi (included > by wedge400 dts) to make sure spi bus is consistent with flash labels in > flash layout. > > Patch #2 enables more ADC channels in wedge400 dts. > > Patch #3 sets eMMC max frequency to 25MHz in wedge400 dts. > > Tao Ren (3): > ARM: dts: aspeed: Update spi alias in Facebook AST2500 Common dtsi I wondered if we should do this in the aspeed-g5.dtsi. > ARM: dts: aspeed: wedge400: Enable more ADC channels > ARM: dts: aspeed: wedge400: Set eMMC max frequency Reviewed-by: Joel Stanley <joel@jms.id.au> > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts | 4 +++- > arch/arm/boot/dts/aspeed/ast2500-facebook-netbmc-common.dtsi | 4 ++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > -- > 2.40.1 >
Hi Joel, On Wed, Aug 09, 2023 at 08:08:12AM +0000, Joel Stanley wrote: > On Thu, 3 Aug 2023 at 23:03, <rentao.bupt@gmail.com> wrote: > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > The patch series fixes a few entries in wedge400 device tree. > > > > Patch #1 sets spi alias in ast2500-facebook-netbmc-common.dtsi (included > > by wedge400 dts) to make sure spi bus is consistent with flash labels in > > flash layout. > > > > Patch #2 enables more ADC channels in wedge400 dts. > > > > Patch #3 sets eMMC max frequency to 25MHz in wedge400 dts. > > > > Tao Ren (3): > > ARM: dts: aspeed: Update spi alias in Facebook AST2500 Common dtsi > > I wondered if we should do this in the aspeed-g5.dtsi. I also hesitated if I should do it in aspeed-g5.dtsi, but I didn't do it because I was not sure if others care about the spi aliases.. Should I send out v2 to move the alias to aspeed-g5.dtsi? Cheers, Tao
On Thu, 10 Aug 2023 at 05:34, Tao Ren <rentao.bupt@gmail.com> wrote: > > Hi Joel, > > On Wed, Aug 09, 2023 at 08:08:12AM +0000, Joel Stanley wrote: > > On Thu, 3 Aug 2023 at 23:03, <rentao.bupt@gmail.com> wrote: > > > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > > > The patch series fixes a few entries in wedge400 device tree. > > > > > > Patch #1 sets spi alias in ast2500-facebook-netbmc-common.dtsi (included > > > by wedge400 dts) to make sure spi bus is consistent with flash labels in > > > flash layout. > > > > > > Patch #2 enables more ADC channels in wedge400 dts. > > > > > > Patch #3 sets eMMC max frequency to 25MHz in wedge400 dts. > > > > > > Tao Ren (3): > > > ARM: dts: aspeed: Update spi alias in Facebook AST2500 Common dtsi > > > > I wondered if we should do this in the aspeed-g5.dtsi. > > I also hesitated if I should do it in aspeed-g5.dtsi, but I didn't do it > because I was not sure if others care about the spi aliases.. Should I > send out v2 to move the alias to aspeed-g5.dtsi? I wasn't sure either. Lets leave it as-is, but if we see other systems wanting similar numbering then we can put it in the common dtsi. I've applied this to the aspeed tree now. Cheers, Joel
On Thu, Aug 10, 2023 at 05:37:41AM +0000, Joel Stanley wrote: > On Thu, 10 Aug 2023 at 05:34, Tao Ren <rentao.bupt@gmail.com> wrote: > > > > Hi Joel, > > > > On Wed, Aug 09, 2023 at 08:08:12AM +0000, Joel Stanley wrote: > > > On Thu, 3 Aug 2023 at 23:03, <rentao.bupt@gmail.com> wrote: > > > > > > > > From: Tao Ren <rentao.bupt@gmail.com> > > > > > > > > The patch series fixes a few entries in wedge400 device tree. > > > > > > > > Patch #1 sets spi alias in ast2500-facebook-netbmc-common.dtsi (included > > > > by wedge400 dts) to make sure spi bus is consistent with flash labels in > > > > flash layout. > > > > > > > > Patch #2 enables more ADC channels in wedge400 dts. > > > > > > > > Patch #3 sets eMMC max frequency to 25MHz in wedge400 dts. > > > > > > > > Tao Ren (3): > > > > ARM: dts: aspeed: Update spi alias in Facebook AST2500 Common dtsi > > > > > > I wondered if we should do this in the aspeed-g5.dtsi. > > > > I also hesitated if I should do it in aspeed-g5.dtsi, but I didn't do it > > because I was not sure if others care about the spi aliases.. Should I > > send out v2 to move the alias to aspeed-g5.dtsi? > > I wasn't sure either. Lets leave it as-is, but if we see other systems > wanting similar numbering then we can put it in the common dtsi. > > I've applied this to the aspeed tree now. > > Cheers, > > Joel Got it. Thanks Joel. Cheers, Tao
From: Tao Ren <rentao.bupt@gmail.com> The patch series fixes a few entries in wedge400 device tree. Patch #1 sets spi alias in ast2500-facebook-netbmc-common.dtsi (included by wedge400 dts) to make sure spi bus is consistent with flash labels in flash layout. Patch #2 enables more ADC channels in wedge400 dts. Patch #3 sets eMMC max frequency to 25MHz in wedge400 dts. Tao Ren (3): ARM: dts: aspeed: Update spi alias in Facebook AST2500 Common dtsi ARM: dts: aspeed: wedge400: Enable more ADC channels ARM: dts: aspeed: wedge400: Set eMMC max frequency arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts | 4 +++- arch/arm/boot/dts/aspeed/ast2500-facebook-netbmc-common.dtsi | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)