diff mbox series

arm: dts: medaitek: convert gmac link mode to 2500base-x for mt7986a-bpi-r3-sd

Message ID 20230804010155.137655-1-weijie.gao@mediatek.com
State Accepted
Commit 3139a77c6028273a2a9e387285982b3f05cd4ec7
Headers show
Series arm: dts: medaitek: convert gmac link mode to 2500base-x for mt7986a-bpi-r3-sd | expand

Commit Message

Weijie Gao (高惟杰) Aug. 4, 2023, 1:01 a.m. UTC
The mt7531 of bpi-r3 is connected to mt7986 with 2.5Gbps HSGMII, not the
regular 1Gbps SGMII.

Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
---
This is a supplement to commit:
aef54ea1 (arm: dts: medaitek: convert gmac link mode to 2500base-x)
---
 arch/arm/dts/mt7986a-bpi-r3-sd.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Golle Aug. 4, 2023, 2:34 a.m. UTC | #1
On Fri, Aug 04, 2023 at 09:01:55AM +0800, Weijie Gao wrote:
> The mt7531 of bpi-r3 is connected to mt7986 with 2.5Gbps HSGMII, not the
> regular 1Gbps SGMII.
> 
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>

Reviewed-by: Daniel Golle <daniel@makrotopia.org>

> ---
> This is a supplement to commit:
> aef54ea1 (arm: dts: medaitek: convert gmac link mode to 2500base-x)
> ---
>  arch/arm/dts/mt7986a-bpi-r3-sd.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/dts/mt7986a-bpi-r3-sd.dts b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> index 15256302b8..c156a81363 100644
> --- a/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> +++ b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> @@ -76,12 +76,12 @@
>  &eth {
>  	status = "okay";
>  	mediatek,gmac-id = <0>;
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	mediatek,switch = "mt7531";
>  	reset-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
>  
>  	fixed-link {
> -		speed = <1000>;
> +		speed = <2500>;
>  		full-duplex;
>  	};
>  };
> -- 
> 2.17.1
>
Weijie Gao (高惟杰) Aug. 4, 2023, 2:37 a.m. UTC | #2
On Fri, 2023-08-04 at 03:34 +0100, Daniel Golle wrote:
> On Fri, Aug 04, 2023 at 09:01:55AM +0800, Weijie Gao wrote:
> > The mt7531 of bpi-r3 is connected to mt7986 with 2.5Gbps HSGMII,
> not the
> > regular 1Gbps SGMII.
> > 
> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> 
> Reviewed-by: Daniel Golle <daniel@makrotopia.org>

Frank has already sent one:

https://patchwork.ozlabs.org/project/uboot/patch/20230803165258.14744-1-linux@fw-web.de/

> 
> > ---
> > This is a supplement to commit:
> > aef54ea1 (arm: dts: medaitek: convert gmac link mode to 2500base-x)
> > ---
> >  arch/arm/dts/mt7986a-bpi-r3-sd.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> > index 15256302b8..c156a81363 100644
> > --- a/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> > +++ b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> > @@ -76,12 +76,12 @@
> >  &eth {
> >  status = "okay";
> >  mediatek,gmac-id = <0>;
> > -phy-mode = "sgmii";
> > +phy-mode = "2500base-x";
> >  mediatek,switch = "mt7531";
> >  reset-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> >  
> >  fixed-link {
> > -speed = <1000>;
> > +speed = <2500>;
> >  full-duplex;
> >  };
> >  };
> > -- 
> > 2.17.1
> >
diff mbox series

Patch

diff --git a/arch/arm/dts/mt7986a-bpi-r3-sd.dts b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
index 15256302b8..c156a81363 100644
--- a/arch/arm/dts/mt7986a-bpi-r3-sd.dts
+++ b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
@@ -76,12 +76,12 @@ 
 &eth {
 	status = "okay";
 	mediatek,gmac-id = <0>;
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	mediatek,switch = "mt7531";
 	reset-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
 
 	fixed-link {
-		speed = <1000>;
+		speed = <2500>;
 		full-duplex;
 	};
 };