diff mbox series

[v2,2/2] spl: move SPL_CRC32 option to lib/Kconfig

Message ID 20230803160541.734853-2-oleksandr.suvorov@foundries.io
State Accepted
Commit af62d83cc0ee27ca5051718a0df44341f71abff1
Delegated to: Tom Rini
Headers show
Series [v2,1/2] spl: remove duplicate SPL_MD5 option | expand

Commit Message

Oleksandr Suvorov Aug. 3, 2023, 4:05 p.m. UTC
All SPL hash algorithm options are collected in lib/Kconfig. Move
SPL_CRC32 there as well.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
---

Changes in v2:
- add a related commit to the series.

 common/spl/Kconfig | 11 -----------
 lib/Kconfig        | 11 +++++++++++
 2 files changed, 11 insertions(+), 11 deletions(-)

Comments

Simon Glass Aug. 3, 2023, 11:28 p.m. UTC | #1
On Thu, 3 Aug 2023 at 10:05, Oleksandr Suvorov
<oleksandr.suvorov@foundries.io> wrote:
>
> All SPL hash algorithm options are collected in lib/Kconfig. Move
> SPL_CRC32 there as well.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> ---
>
> Changes in v2:
> - add a related commit to the series.
>
>  common/spl/Kconfig | 11 -----------
>  lib/Kconfig        | 11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Aug. 7, 2023, 7:28 p.m. UTC | #2
On Thu, Aug 03, 2023 at 07:05:40PM +0300, Oleksandr Suvorov wrote:

> All SPL hash algorithm options are collected in lib/Kconfig. Move
> SPL_CRC32 there as well.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index c66d70e2a99..c5dd476db58 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -550,17 +550,6 @@  config SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION
 	  the eMMC EXT_CSC_PART_CONFIG selection should be overridden in SPL
 	  by user defined partition number.
 
-config SPL_CRC32
-	bool "Support CRC32"
-	default y if SPL_LEGACY_IMAGE_FORMAT || SPL_EFI_PARTITION
-	default y if SPL_ENV_SUPPORT || TPL_BLOBLIST
-	help
-	  Enable this to support CRC32 in uImages or FIT images within SPL.
-	  This is a 32-bit checksum value that can be used to verify images.
-	  For FIT images, this is the least secure type of checksum, suitable
-	  for detected accidental image corruption. For secure applications you
-	  should consider SHA1 or SHA256.
-
 config SPL_FIT_IMAGE_TINY
 	bool "Remove functionality from SPL FIT loading to reduce size"
 	depends on SPL_FIT
diff --git a/lib/Kconfig b/lib/Kconfig
index 3926652db63..07e61de5b64 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -534,6 +534,17 @@  config SHA_HW_ACCEL
 
 if SPL
 
+config SPL_CRC32
+	bool "Enable CRC32 support in SPL"
+	default y if SPL_LEGACY_IMAGE_SUPPORT || SPL_EFI_PARTITION
+	default y if SPL_ENV_SUPPORT || TPL_BLOBLIST
+	help
+	  This option enables support of hashing using CRC32 algorithm.
+	  The CRC32 algorithm produces 32-bit checksum value. For FIT
+	  images, this is the least secure type of checksum, suitable for
+	  detected accidental image corruption. For secure applications you
+	  should consider SHA256 or SHA384.
+
 config SPL_SHA1
 	bool "Enable SHA1 support in SPL"
 	default y if SHA1