Message ID | 20230721-ti-mdio-pinmux-v2-2-4bb443e09ac0@kernel.org |
---|---|
State | Superseded |
Delegated to: | Ramon Fried |
Headers | show |
Series | net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl | expand |
On 21/07/2023 16:07, Maxime Ripard wrote: > The MDIO pinctrl nodes can't be duplicated between the child and device, > because if we ever boot Linux with our DT it will try to attach that > pinctrl configuration to both the MAC and MDIO devices, which will > result in failure to probe. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> Acked-by: Roger Quadros <rogerq@kernel.org>
diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi index 379165373aca..db814ed02a7e 100644 --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi @@ -121,7 +121,6 @@ &cpsw3g { /delete-property/ ranges; bootph-pre-ram; - pinctrl-0 = <&main_mdio1_pins_default &main_rgmii1_pins_default>; cpsw-phy-sel@04044 { compatible = "ti,am64-phy-gmii-sel";
The MDIO pinctrl nodes can't be duplicated between the child and device, because if we ever boot Linux with our DT it will try to attach that pinctrl configuration to both the MAC and MDIO devices, which will result in failure to probe. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-)