| Message ID | 20230719220853.1029316-1-iwona.winiarska@intel.com |
|---|---|
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
On Thu, 2023-07-20 at 08:17 +0200, Krzysztof Kozlowski wrote: > On 20/07/2023 00:08, Iwona Winiarska wrote: > > Hi! > > > > The series adds support for PECI on Nuvoton-based BMC boards. > > It is based on patches that were sent by Tomer Maimon from > > Nuvoton [1]. > > Similar to Aspeed driver, unused (as in, default values were used in > > all of the available DTS files) vendor-specific properties were > > removed. > > If there is a use-case for such properties, they can be added in > > a separate series. > > > > Thank you Tomer for testing this series on Nuvoton hardware. > > > > Thanks > > -Iwona > > > > [1] > > https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/ > > > > This is not v1 but v3 or v4. Please provide proper changelog and versioning. This is the first submission - also known as v1 :) Could you elaborate on why do you believe that this is v3 or v4? -Iwona > > Best regards, > Krzysztof >
On Thu, 2023-07-20 at 10:40 +0200, Krzysztof Kozlowski wrote: > On 20/07/2023 10:00, Winiarska, Iwona wrote: > > On Thu, 2023-07-20 at 08:17 +0200, Krzysztof Kozlowski wrote: > > > On 20/07/2023 00:08, Iwona Winiarska wrote: > > > > Hi! > > > > > > > > The series adds support for PECI on Nuvoton-based BMC boards. > > > > It is based on patches that were sent by Tomer Maimon from > > > > Nuvoton [1]. > > > > Similar to Aspeed driver, unused (as in, default values were used in > > > > all of the available DTS files) vendor-specific properties were > > > > removed. > > > > If there is a use-case for such properties, they can be added in > > > > a separate series. > > > > > > > > Thank you Tomer for testing this series on Nuvoton hardware. > > > > > > > > Thanks > > > > -Iwona > > > > > > > > [1] > > > > https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/ > > > > > > > > > > This is not v1 but v3 or v4. Please provide proper changelog and > > > versioning. > > > > This is the first submission - also known as v1 :) > > Could you elaborate on why do you believe that this is v3 or v4? > > I had such impression because I saw it: > https://lore.kernel.org/all/20230616193450.413366-2-iwona.winiarska@intel.com/ > https://lore.kernel.org/all/20230628090404.234965-2-tmaimon77@gmail.com/ Changelog / versioning is maintained for changes that are submitted for inclusion in upstream Linux. The series you're referring to are not upstream Linux submissions. Additionally - there were no changes :) -Iwona > > Best regards, > Krzysztof >