Message ID | 20230718132049.3028341-1-m.felsch@pengutronix.de |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [net-next,v2,1/2] dt-bindings: net: snps,dwmac: add phy-supply support | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On Tue, 18 Jul 2023 15:20:49 +0200 Marco Felsch wrote: > Add generic phy-supply handling support to control the phy regulator to > avoid handling it within the glue code. Use the generic stmmac_platform > code to register a possible phy-supply and the stmmac_main code to > handle the power on/off. > > Changelog > --- > > v2: > - adapt stmmac_phy_power > - move power-on/off into stmmac_main to handle WOL > - adapt commit message > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- Format should be: Bla bla bla Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Changelog v2: bla bla bla Please fix and rebase because the current version does not apply to net-next/main.
Hi, On 23-07-19, Jakub Kicinski wrote: > On Tue, 18 Jul 2023 15:20:49 +0200 Marco Felsch wrote: > > Add generic phy-supply handling support to control the phy regulator to > > avoid handling it within the glue code. Use the generic stmmac_platform > > code to register a possible phy-supply and the stmmac_main code to > > handle the power on/off. > > > > Changelog > > --- > > > > v2: > > - adapt stmmac_phy_power > > - move power-on/off into stmmac_main to handle WOL > > - adapt commit message > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Format should be: > > Bla bla bla > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Changelog > > v2: > bla bla bla > > > Please fix and rebase because the current version does not apply to > net-next/main. Sure, I thought the changelog should be part of the commit message in net-dev therefore I included it. Unfortunately I used --- as underline :/ I will fix this and rebase it on-top of net-next/main. Regards, Marco > -- > pw-bot: cr >
On Thu, 20 Jul 2023 08:46:36 +0200 Marco Felsch wrote: > > Please fix and rebase because the current version does not apply to > > net-next/main. > > Sure, I thought the changelog should be part of the commit message in > net-dev therefore I included it. Old rules, I think. Since started adding lore links to all patches you can put the changelog in the cut-off section. Adding a link to the previous revision there is highly encouraged, too! There's a sample of the preferred format at: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
On 23-07-20, Jakub Kicinski wrote: > On Thu, 20 Jul 2023 08:46:36 +0200 Marco Felsch wrote: > > > Please fix and rebase because the current version does not apply to > > > net-next/main. > > > > Sure, I thought the changelog should be part of the commit message in > > net-dev therefore I included it. > > Old rules, I think. Since started adding lore links to all patches you > can put the changelog in the cut-off section. Make sense. > Adding a link to the previous revision there is highly encouraged, > too! Sure, I will check my tooling to use b4 for sending, so the links are provided autom. > There's a sample of the preferred format at: > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested I will keep that in mind. Regards, Marco
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 363b3e3ea3a60..f66d1839cf561 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -159,6 +159,9 @@ properties: can be passive (no SW requirement), and requires that the MAC operate in a different mode than the PHY in order to function. + phy-supply: + description: PHY regulator + snps,axi-config: $ref: /schemas/types.yaml#/definitions/phandle description: