mbox series

[ovs-dev,0/3] ovn-installed

Message ID 20230717150641.2069008-1-xsimonar@redhat.com
Headers show
Series ovn-installed | expand

Message

Xavier Simonart July 17, 2023, 3:06 p.m. UTC 
Xavier Simonart (3):
  tests: fixed typos in macro logs
  binding: fixed ovn-installed not properly removed (migration)
  binding: fixed ovn-installed not properly removed (recomputes)

 controller/binding.c   | 21 +++++++++-
 controller/if-status.c | 19 +++++++--
 controller/if-status.h |  2 +
 tests/ovn-macros.at    | 13 +++++-
 tests/ovn.at           | 93 ++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 141 insertions(+), 7 deletions(-)

Comments

Mark Michelson July 17, 2023, 7:07 p.m. UTC | #1 
Hi Xavier,

For the series,

Acked-by: Mark Michelson <mmichels@redhat.com>

On 7/17/23 11:06, Xavier Simonart wrote:
> Xavier Simonart (3):
>    tests: fixed typos in macro logs
>    binding: fixed ovn-installed not properly removed (migration)
>    binding: fixed ovn-installed not properly removed (recomputes)
> 
>   controller/binding.c   | 21 +++++++++-
>   controller/if-status.c | 19 +++++++--
>   controller/if-status.h |  2 +
>   tests/ovn-macros.at    | 13 +++++-
>   tests/ovn.at           | 93 ++++++++++++++++++++++++++++++++++++++++++
>   5 files changed, 141 insertions(+), 7 deletions(-)
>
Ales Musil July 19, 2023, 6:21 a.m. UTC | #2 
On Mon, Jul 17, 2023 at 9:08 PM Mark Michelson <mmichels@redhat.com> wrote:

> Hi Xavier,
>
> For the series,
>
> Acked-by: Mark Michelson <mmichels@redhat.com>
>
> On 7/17/23 11:06, Xavier Simonart wrote:
> > Xavier Simonart (3):
> >    tests: fixed typos in macro logs
> >    binding: fixed ovn-installed not properly removed (migration)
> >    binding: fixed ovn-installed not properly removed (recomputes)
> >
> >   controller/binding.c   | 21 +++++++++-
> >   controller/if-status.c | 19 +++++++--
> >   controller/if-status.h |  2 +
> >   tests/ovn-macros.at    | 13 +++++-
> >   tests/ovn.at           | 93 ++++++++++++++++++++++++++++++++++++++++++
> >   5 files changed, 141 insertions(+), 7 deletions(-)
> >
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The whole series looks good, thanks.

Acked-by: Ales Musil <amusil@redhat.com>
Mark Michelson July 19, 2023, 6:11 p.m. UTC | #3 
Thank you Ales and Xavier. I pushed the changes to main, branch-23.06, 
branch-23.03, branch-22.12, and branch-22.09.

Beyond that, OVN does not have the multichassis MTU patch series, so 
patch 2 does not apply. Patch 3 applies, but calls a function that does 
not exist in if-status.c. If this should be backported to branch-22.03 
(the current LTS), then could you please provide a separate backport 
patch? Thanks!

On 7/19/23 02:21, Ales Musil wrote:
> 
> 
> On Mon, Jul 17, 2023 at 9:08 PM Mark Michelson <mmichels@redhat.com 
> <mailto:mmichels@redhat.com>> wrote:
> 
>     Hi Xavier,
> 
>     For the series,
> 
>     Acked-by: Mark Michelson <mmichels@redhat.com
>     <mailto:mmichels@redhat.com>>
> 
>     On 7/17/23 11:06, Xavier Simonart wrote:
>      > Xavier Simonart (3):
>      >    tests: fixed typos in macro logs
>      >    binding: fixed ovn-installed not properly removed (migration)
>      >    binding: fixed ovn-installed not properly removed (recomputes)
>      >
>      >   controller/binding.c   | 21 +++++++++-
>      >   controller/if-status.c | 19 +++++++--
>      >   controller/if-status.h |  2 +
>      >   tests/ovn-macros.at <http://ovn-macros.at>    | 13 +++++-
>      >   tests/ovn.at <http://ovn.at>           | 93
>     ++++++++++++++++++++++++++++++++++++++++++
>      >   5 files changed, 141 insertions(+), 7 deletions(-)
>      >
> 
>     _______________________________________________
>     dev mailing list
>     dev@openvswitch.org <mailto:dev@openvswitch.org>
>     https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>     <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>
> 
> 
> The whole series looks good, thanks.
> 
> Acked-by: Ales Musil <amusil@redhat.com <mailto:amusil@redhat.com>>
> 
> -- 
> 
> Ales Musil
> 
> Senior Software Engineer - OVN Core
> 
> Red Hat EMEA <https://www.redhat.com>
> 
> amusil@redhat.com <mailto:amusil@redhat.com> IM: amusil
> 
> <https://red.ht/sig>
>