diff mbox series

[05/29] serial: mtk: initial priv data before using

Message ID 4e3359951967714e4eb1d33e7ee5f157ab6b8096.1689756363.git.weijie.gao@mediatek.com
State Accepted
Commit 0fd96bf224c1af7f8fc3bbdc814eba0349d0c334
Delegated to: Tom Rini
Headers show
Series Add support for MediaTek MT7988 SoC | expand

Commit Message

Weijie Gao (高惟杰) July 19, 2023, 9:16 a.m. UTC 
This patch ensures driver private data being fully initialized in
_debug_uart_init which is not covered by .priv_auto ops.

Signed-off-by: Sam Shih <sam.shih@mediatek.com>
Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
---
 drivers/serial/serial_mtk.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese July 19, 2023, 9:54 a.m. UTC | #1 
On 7/19/23 11:16, Weijie Gao wrote:
> This patch ensures driver private data being fully initialized in
> _debug_uart_init which is not covered by .priv_auto ops.
> 
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> ---
>   drivers/serial/serial_mtk.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/serial/serial_mtk.c b/drivers/serial/serial_mtk.c
> index ded7346a13..2dffa14ea7 100644
> --- a/drivers/serial/serial_mtk.c
> +++ b/drivers/serial/serial_mtk.c
> @@ -439,6 +439,7 @@ static inline void _debug_uart_init(void)
>   {
>   	struct mtk_serial_priv priv;
>   
> +	memset(&priv, 0, sizeof(struct mtk_serial_priv));
>   	priv.regs = (void *) CONFIG_VAL(DEBUG_UART_BASE);
>   	priv.fixed_clk_rate = CONFIG_DEBUG_UART_CLOCK;
>   

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
diff mbox series

Patch

diff --git a/drivers/serial/serial_mtk.c b/drivers/serial/serial_mtk.c
index ded7346a13..2dffa14ea7 100644
--- a/drivers/serial/serial_mtk.c
+++ b/drivers/serial/serial_mtk.c
@@ -439,6 +439,7 @@  static inline void _debug_uart_init(void)
 {
 	struct mtk_serial_priv priv;
 
+	memset(&priv, 0, sizeof(struct mtk_serial_priv));
 	priv.regs = (void *) CONFIG_VAL(DEBUG_UART_BASE);
 	priv.fixed_clk_rate = CONFIG_DEBUG_UART_CLOCK;