mbox series

[kvmtool,v3,0/8] RISC-V SBI enable/disable, Zbb, Zicboz, and Ssaia support

Message ID 20230706173804.1237348-1-apatel@ventanamicro.com
Headers show
Series RISC-V SBI enable/disable, Zbb, Zicboz, and Ssaia support | expand

Message

Anup Patel July 6, 2023, 5:37 p.m. UTC 
The latest KVM in Linux-6.4 has support for:
1) Enabling/disabling SBI extensions from KVM user-space
2) Zbb ISA extension support
3) Zicboz ISA extension support
4) Ssaia ISA extension support

This series adds corresponding changes in KVMTOOL to use the above
mentioned features for Guest/VM.

These patches can also be found in the riscv_sbi_zbb_zicboz_ssaia_v3
branch at: https://github.com/avpatel/kvmtool.git

Changes since v2:
 - Rebased on commit 0b5e55fc032d1c6394b8ec7fe02d842813c903df
 - Updated PATCH1 to sync-up header with released Linux-6.4

Changes since v1:
 - Rebased on commit b17552ee6c9728c20c9d0bd037ef134277daaa40
 - Fixed compile error for KVMTOOL x86 by adding __DECLARE_FLEX_ARRAY()
   in include/linux/stddef.h

Andrew Jones (1):
  riscv: Add Zicboz extension support

Anup Patel (7):
  Sync-up headers with Linux-6.4
  riscv: Allow setting custom mvendorid, marchid, and mimpid
  riscv: Allow disabling SBI extensions for Guest
  riscv: Sort the ISA extension array alphabetically
  riscv: Add zbb extension support
  riscv: Add Ssaia extension support
  riscv: Fix guest RAM alloc size computation for RV32

 arm/aarch64/include/asm/kvm.h       |  38 ++++++++++
 include/linux/kvm.h                 |  57 +++++++++------
 include/linux/virtio_blk.h          | 105 ++++++++++++++++++++++++++++
 include/linux/virtio_config.h       |   6 ++
 include/linux/virtio_net.h          |   5 ++
 riscv/fdt.c                         |  19 ++++-
 riscv/include/asm/kvm.h             |  56 ++++++++++++++-
 riscv/include/kvm/kvm-config-arch.h |  51 +++++++++++++-
 riscv/include/kvm/kvm-cpu-arch.h    |  19 +++--
 riscv/kvm-cpu.c                     |  45 +++++++++++-
 riscv/kvm.c                         |  15 +++-
 x86/include/asm/kvm.h               |  50 ++++++++++---
 12 files changed, 419 insertions(+), 47 deletions(-)

Comments

Will Deacon July 12, 2023, 4:10 p.m. UTC | #1 
On Thu, Jul 06, 2023 at 11:07:56PM +0530, Anup Patel wrote:
> The latest KVM in Linux-6.4 has support for:
> 1) Enabling/disabling SBI extensions from KVM user-space
> 2) Zbb ISA extension support
> 3) Zicboz ISA extension support
> 4) Ssaia ISA extension support
> 
> This series adds corresponding changes in KVMTOOL to use the above
> mentioned features for Guest/VM.
> 
> These patches can also be found in the riscv_sbi_zbb_zicboz_ssaia_v3
> branch at: https://github.com/avpatel/kvmtool.git
> 
> Changes since v2:
>  - Rebased on commit 0b5e55fc032d1c6394b8ec7fe02d842813c903df
>  - Updated PATCH1 to sync-up header with released Linux-6.4

Bah, now we're back to the __DECLARE_FLEX_ARRAY breakage :(

In file included from include/linux/kvm.h:15,
                 from x86/include/kvm/kvm-cpu-arch.h:6,
                 from include/kvm/kvm-cpu.h:4,
                 from include/kvm/ioport.h:4,
                 from hw/rtc.c:4:
x86/include/asm/kvm.h:511:17: error: expected specifier-qualifier-list before ‘__DECLARE_FLEX_ARRAY’
  511 |                 __DECLARE_FLEX_ARRAY(struct kvm_vmx_nested_state_data, vmx);
      |                 ^~~~~~~~~~~~~~~~~~~~


Will
Anup Patel July 12, 2023, 4:33 p.m. UTC | #2 
On Wed, Jul 12, 2023 at 9:41 PM Will Deacon <will@kernel.org> wrote:
>
> On Thu, Jul 06, 2023 at 11:07:56PM +0530, Anup Patel wrote:
> > The latest KVM in Linux-6.4 has support for:
> > 1) Enabling/disabling SBI extensions from KVM user-space
> > 2) Zbb ISA extension support
> > 3) Zicboz ISA extension support
> > 4) Ssaia ISA extension support
> >
> > This series adds corresponding changes in KVMTOOL to use the above
> > mentioned features for Guest/VM.
> >
> > These patches can also be found in the riscv_sbi_zbb_zicboz_ssaia_v3
> > branch at: https://github.com/avpatel/kvmtool.git
> >
> > Changes since v2:
> >  - Rebased on commit 0b5e55fc032d1c6394b8ec7fe02d842813c903df
> >  - Updated PATCH1 to sync-up header with released Linux-6.4
>
> Bah, now we're back to the __DECLARE_FLEX_ARRAY breakage :(
>
> In file included from include/linux/kvm.h:15,
>                  from x86/include/kvm/kvm-cpu-arch.h:6,
>                  from include/kvm/kvm-cpu.h:4,
>                  from include/kvm/ioport.h:4,
>                  from hw/rtc.c:4:
> x86/include/asm/kvm.h:511:17: error: expected specifier-qualifier-list before ‘__DECLARE_FLEX_ARRAY’
>   511 |                 __DECLARE_FLEX_ARRAY(struct kvm_vmx_nested_state_data, vmx);
>       |                 ^~~~~~~~~~~~~~~~~~~~

My bad, the fix for this error was folded in the header sync patch of v2
which got accidently dropped in this version.

I will send v4 with the compile error fix as a separate patch.

Regards,
Anup