| Message ID | ddd7f9cd-994e-0baf-33a3-34c27539f2b1@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Include insn-opinit.h in PLUGIN_H [PR110610] | expand |
On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: > Hi, > > This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H > list, as insn-opinit.h is now required by internal-fn.h. This will lead > to insn-opinit.h, among the other OPTABS_H header files, being installed > in the plugin directory. > > Bootstrapped aarch64-unknown-linux-gnu. > > @Jakub: could you check to see if it also addresses PR 110284? > > > gcc/ChangeLog: > > PR 110610 > * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h and insn-codes.h and neither of those #include other headers do they? Jeff
On 11/07/2023 23:28, Jeff Law wrote: > > > On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: >> Hi, >> >> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H >> list, as insn-opinit.h is now required by internal-fn.h. This will >> lead to insn-opinit.h, among the other OPTABS_H header files, being >> installed in the plugin directory. >> >> Bootstrapped aarch64-unknown-linux-gnu. >> >> @Jakub: could you check to see if it also addresses PR 110284? >> >> >> gcc/ChangeLog: >> >> PR 110610 >> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. > Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h > and insn-codes.h and neither of those #include other headers do they? > > Yeah, there was no particular reason other than I just felt the Makefile structure sort of lend itself that way. I checked genopinit.cc and it seems insn-opinit.h doesn't include any other header files, only the sources do, so I've changed the patch to only add insn-opinit.h to INTERNAL_FN_H. ------------------- This patch fixes PR110610 by including insn-opinit.h in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory. Bootstrapped aarch64-unknown-linux-gnu. gcc/ChangeLog: PR 110610 * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h. diff --git a/gcc/Makefile.in b/gcc/Makefile.in index c478ec852013eae65b9f3ec0a443e023c7d8b452..683774ad446d545362644d2dbdc37723eea55bc3 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \ gtm-builtins.def sanitizer.def INTERNAL_FN_DEF = internal-fn.def -INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) +INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) insn-opinit.h TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \ c-family/c-common.def $(lang_tree_files) \ $(BUILTINS_DEF) $(INPUT_H) statistics.h \
On 7/17/23 05:55, Andre Vieira (lists) wrote: > > > On 11/07/2023 23:28, Jeff Law wrote: >> >> >> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: >>> Hi, >>> >>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H >>> list, as insn-opinit.h is now required by internal-fn.h. This will >>> lead to insn-opinit.h, among the other OPTABS_H header files, being >>> installed in the plugin directory. >>> >>> Bootstrapped aarch64-unknown-linux-gnu. >>> >>> @Jakub: could you check to see if it also addresses PR 110284? >>> >>> >>> gcc/ChangeLog: >>> >>> PR 110610 >>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. >> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h >> and insn-codes.h and neither of those #include other headers do they? >> >> > > Yeah, there was no particular reason other than I just felt the Makefile > structure sort of lend itself that way. I checked genopinit.cc and it > seems insn-opinit.h doesn't include any other header files, only the > sources do, so I've changed the patch to only add insn-opinit.h to > INTERNAL_FN_H. > > ------------------- > > This patch fixes PR110610 by including insn-opinit.h in the > INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. > This will lead to insn-opinit.h, among the other OPTABS_H header files, > being installed in the plugin directory. > > Bootstrapped aarch64-unknown-linux-gnu. > > gcc/ChangeLog: > PR 110610 > * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h. OK jeff
diff --git a/gcc/Makefile.in b/gcc/Makefile.in index c478ec852013eae65b9f3ec0a443e023c7d8b452..d3ff210ee04414f4e238c087400dd21e1cb0fc18 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \ gtm-builtins.def sanitizer.def INTERNAL_FN_DEF = internal-fn.def -INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) +INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) $(OPTABS_H) TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \ c-family/c-common.def $(lang_tree_files) \ $(BUILTINS_DEF) $(INPUT_H) statistics.h \
Hi, This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory. Bootstrapped aarch64-unknown-linux-gnu. @Jakub: could you check to see if it also addresses PR 110284? gcc/ChangeLog: PR 110610 * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.