| Message ID | 20230628130742.155724-3-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Remove O_DIRECT definition | expand |
Hi! > -/* xfs-specific includes */ Just a very minor nit, such cleanups should be in a separate patch. Otherwise the rest of the changes looks good: Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Hi Cyril, > Hi! > > -/* xfs-specific includes */ > Just a very minor nit, such cleanups should be in a separate patch. I'm sorry, I sometimes try to blance between separating changes and too many commits. I can put this to separate commit. > Otherwise the rest of the changes looks good: Is that that this is just this patch. Please let me know if you're meant whole patchset (it'd make sense, it's pretty simple). > Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Kind regards, Petr
Hi! > > Just a very minor nit, such cleanups should be in a separate patch. > I'm sorry, I sometimes try to blance between separating changes and too many commits. > I can put this to separate commit. I tend to be picky in separating formatting changes from actuall fixes... > > Otherwise the rest of the changes looks good: > Is that that this is just this patch. Please let me know if you're meant whole > patchset (it'd make sense, it's pretty simple). That was for the whole patchset, sorry for not being clear.
> Hi! > > > Just a very minor nit, such cleanups should be in a separate patch. > > I'm sorry, I sometimes try to blance between separating changes and too many commits. > > I can put this to separate commit. > I tend to be picky in separating formatting changes from actuall fixes... I used to be, then relaxed a bit. But you're right, it makes sense. Thus I separated this change to it's own commit. > > > Otherwise the rest of the changes looks good: > > Is that that this is just this patch. Please let me know if you're meant whole > > patchset (it'd make sense, it's pretty simple). > That was for the whole patchset, sorry for not being clear. Thanks a lot, patchset merged (dared to add your RBT to the separated commit as well.) Kind regards, Petr
diff --git a/testcases/kernel/fs/fsstress/global.h b/testcases/kernel/fs/fsstress/global.h index 4ec382426..584af025d 100644 --- a/testcases/kernel/fs/fsstress/global.h +++ b/testcases/kernel/fs/fsstress/global.h @@ -33,7 +33,7 @@ #ifndef GLOBAL_H #define GLOBAL_H -/* xfs-specific includes */ +#define _GNU_SOURCE #if defined(NO_XFS) # include "xfscompat.h" @@ -42,8 +42,6 @@ # include <attr/attributes.h> #endif -/* libc includes */ - #include <sys/stat.h> #include <sys/statvfs.h> #include <sys/time.h> @@ -59,8 +57,4 @@ #include <stdio.h> #include <unistd.h> -#ifndef O_DIRECT -#define O_DIRECT 040000 -#endif - #endif
O_DIRECT definitions differ a lot depending on architecture, therefore _GNU_SOURCE (which loads it) instead of fallback O_DIRECT definition. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testcases/kernel/fs/fsstress/global.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)