Message ID | cover.1687855361.git.quic_schowdhu@quicinc.com |
---|---|
Headers | show |
Series | misc: Add driver support for Data Capture and Compare unit(DCC) | expand |
On Tue, Jun 27, 2023 at 03:19:23PM +0530, Souradeep Chowdhury wrote: > Changes in v24 > > *Implemented the comments in v23 That explains absolutely nothing about what changed at all. What would you do if you got a patch series that had this as a change list? What do you expect us to do? {sigh}
Hi-- On 6/27/23 02:49, Souradeep Chowdhury wrote: > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 433aa4197785..3112dbb15cf4 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -276,6 +276,15 @@ config QCOM_COINCELL > to maintain PMIC register and RTC state in the absence of > external power. > > +config QCOM_DCC > + tristate "Qualcomm Technologies, Inc. Data Capture and Compare(DCC) engine driver" Compare (DCC) > + depends on ARCH_QCOM || COMPILE_TEST > + help > + This option enables driver for Data Capture and Compare engine. DCC enables the driver for the . The DCC > + driver provides interface to configure DCC block and read back provides interfaces to configure the DCC block and read back > + captured data from DCC's internal SRAM. The module name for this from the DCC's > + is qcom-dcc.ko We don't usually add the ".ko" here, so just: is qcom-dcc. thanks.
On 6/27/2023 3:52 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 27, 2023 at 03:19:23PM +0530, Souradeep Chowdhury wrote: >> Changes in v24 >> >> *Implemented the comments in v23 > > That explains absolutely nothing about what changed at all. > > What would you do if you got a patch series that had this as a change > list? What do you expect us to do? > > {sigh} My apologies on missing out on the specifics. The main changes in this version are as follows:- * Updated the documentation of the structure dcc_config_entry * Renamed "nr_link_list" to "max_link_list" * Used u64 where applicable * Removed the locks from ready_read method and also dropped the use of unlikely keyword. >
On Wed, Jun 28, 2023 at 11:15:46AM +0530, Souradeep Chowdhury wrote: > > > On 6/27/2023 3:52 PM, Greg Kroah-Hartman wrote: > > On Tue, Jun 27, 2023 at 03:19:23PM +0530, Souradeep Chowdhury wrote: > > > Changes in v24 > > > > > > *Implemented the comments in v23 > > > > That explains absolutely nothing about what changed at all. > > > > What would you do if you got a patch series that had this as a change > > list? What do you expect us to do? > > > > {sigh} > > My apologies on missing out on the specifics. > > The main changes in this version are as follows:- > > * Updated the documentation of the structure dcc_config_entry > * Renamed "nr_link_list" to "max_link_list" > * Used u64 where applicable > * Removed the locks from ready_read method and also dropped > the use of unlikely keyword. Please fix this up and send a new version. thanks, greg k-h