mbox series

[v2,0/6] Fix sparse warnings in zynq platform

Message ID 20230614090359.10809-1-ashok.reddy.soma@amd.com
Headers show
Series Fix sparse warnings in zynq platform | expand

Message

Ashok Reddy Soma June 14, 2023, 9:03 a.m. UTC
Fix below sparse warnings
 - Add missing prototype for zynqmp_mmio_write
 - Add missing prototype for zynq_qspi_mem_exec_op
 - Change datatype of status and ecc_status from u32 to int
 - Pass the missing argument type in function definition
 - Add the missing function prototypes
 - Add missing prototype for xilinx_qspi_mem_exec_op


Changes in v2:
 - Move prototype declaration from sys_proto.h to include/zynqmp_firmware.h
 - Added argument void in below files to fix warning
    board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c
    board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c
    board/xilinx/zynq/zynq-zed/ps7_init_gpl.c

Algapally Santosh Sagar (6):
  spi: xilinx_spi: Add missing prototype for xilinx_qspi_mem_exec_op
  xilinx: zynq: Add missing prototype for zynqmp_mmio_write
  spi: zynq_qspi: Add missing prototype for zynq_qspi_mem_exec_op
  mtd: nand: zynq_nand: Change datatype of status and ecc_status to int
  arm: zynq: Pass the missing argument type in function definition
  xilinx: zynq: Add the missing function prototypes

 board/xilinx/zynq/board.c                      | 2 ++
 board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c | 4 ++--
 board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c    | 4 ++--
 board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c    | 4 ++--
 board/xilinx/zynq/zynq-zed/ps7_init_gpl.c      | 4 ++--
 drivers/mtd/nand/raw/zynq_nand.c               | 4 ++--
 drivers/spi/xilinx_spi.c                       | 4 ++--
 drivers/spi/zynq_qspi.c                        | 4 ++--
 include/zynqmp_firmware.h                      | 1 +
 9 files changed, 17 insertions(+), 14 deletions(-)

Comments

Michal Simek June 23, 2023, 12:47 p.m. UTC | #1
On 6/14/23 11:03, Ashok Reddy Soma wrote:
> Fix below sparse warnings
>   - Add missing prototype for zynqmp_mmio_write
>   - Add missing prototype for zynq_qspi_mem_exec_op
>   - Change datatype of status and ecc_status from u32 to int
>   - Pass the missing argument type in function definition
>   - Add the missing function prototypes
>   - Add missing prototype for xilinx_qspi_mem_exec_op
> 
> 
> Changes in v2:
>   - Move prototype declaration from sys_proto.h to include/zynqmp_firmware.h
>   - Added argument void in below files to fix warning
>      board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c
>      board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c
>      board/xilinx/zynq/zynq-zed/ps7_init_gpl.c
> 
> Algapally Santosh Sagar (6):
>    spi: xilinx_spi: Add missing prototype for xilinx_qspi_mem_exec_op
>    xilinx: zynq: Add missing prototype for zynqmp_mmio_write
>    spi: zynq_qspi: Add missing prototype for zynq_qspi_mem_exec_op
>    mtd: nand: zynq_nand: Change datatype of status and ecc_status to int
>    arm: zynq: Pass the missing argument type in function definition
>    xilinx: zynq: Add the missing function prototypes
> 
>   board/xilinx/zynq/board.c                      | 2 ++
>   board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c | 4 ++--
>   board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c    | 4 ++--
>   board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c    | 4 ++--
>   board/xilinx/zynq/zynq-zed/ps7_init_gpl.c      | 4 ++--
>   drivers/mtd/nand/raw/zynq_nand.c               | 4 ++--
>   drivers/spi/xilinx_spi.c                       | 4 ++--
>   drivers/spi/zynq_qspi.c                        | 4 ++--
>   include/zynqmp_firmware.h                      | 1 +
>   9 files changed, 17 insertions(+), 14 deletions(-)
> 

Applied.
M