| Message ID | c1f86e5d1026937abda331ce564e5ee96b7114c7.1686882123.git.zhoubinbin@loongson.cn |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | LoongArch: Add built-in dtb support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Jun 16, 2023 at 02:10:38PM +0800, Binbin Zhou wrote: > Add the available CPUs in LoongArch binding with DT schema format using > json-schema. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml > new file mode 100644 > index 000000000000..c3e2dba42c81 > --- /dev/null > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LoongArch CPUs > + > +maintainers: > + - Binbin Zhou <zhoubinbin@loongson.cn> > + > +description: > + The device tree allows to describe the layout of CPUs in a system through > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > + defining properties for every CPU. > + > +properties: > + compatible: > + enum: > + - loongson,la264 > + - loongson,la364 > + > + reg: > + maxItems: 1 > + > + device_type: true > + > + clock-frequency: > + description: The frequency of cpu in Hz. Why don't you just add a ref to the common cpu schema and use the standard properties for communicating clock frequencies? You then get the standard properties for l1 caches, power management, frequency scaling etc as a side effect. Cheers, Conor.
On 16/06/2023 11:34, Conor Dooley wrote: > On Fri, Jun 16, 2023 at 02:10:38PM +0800, Binbin Zhou wrote: >> Add the available CPUs in LoongArch binding with DT schema format using >> json-schema. >> >> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> >> --- >> .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml >> >> diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> new file mode 100644 >> index 000000000000..c3e2dba42c81 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> @@ -0,0 +1,65 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: LoongArch CPUs >> + >> +maintainers: >> + - Binbin Zhou <zhoubinbin@loongson.cn> >> + >> +description: >> + The device tree allows to describe the layout of CPUs in a system through >> + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") >> + defining properties for every CPU. >> + >> +properties: >> + compatible: >> + enum: >> + - loongson,la264 >> + - loongson,la364 >> + >> + reg: >> + maxItems: 1 >> + >> + device_type: true >> + >> + clock-frequency: >> + description: The frequency of cpu in Hz. > > Why don't you just add a ref to the common cpu schema and use the > standard properties for communicating clock frequencies? > You then get the standard properties for l1 caches, power management, > frequency scaling etc as a side effect. > And operating-points-v2... unless all Loongson CPUs work with only one frequency and do not allow dynamic scaling? Best regards, Krzysztof
On 16/06/2023 08:10, Binbin Zhou wrote: > Add the available CPUs in LoongArch binding with DT schema format using > json-schema. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml > new file mode 100644 > index 000000000000..c3e2dba42c81 > --- /dev/null > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LoongArch CPUs > + > +maintainers: > + - Binbin Zhou <zhoubinbin@loongson.cn> > + > +description: > + The device tree allows to describe the layout of CPUs in a system through > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > + defining properties for every CPU. I understand you copied it from ARM, but I would prefer to have here something meaningful. Bindings description does not explain what is DTS, but explains what the hardware is. > + > +properties: > + compatible: > + enum: > + - loongson,la264 > + - loongson,la364 > + > + reg: > + maxItems: 1 > + > + device_type: true > + > + clock-frequency: > + description: The frequency of cpu in Hz. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User-visible cpu name in /proc/cpuinfo. First, aren't you mixing nodes? Second, it is derived from compatible, so no need for such property. > + > +required: > + - compatible > + - reg > + - clock-frequency > + > +additionalProperties: false > + > +examples: > + - | > + cpus { > + #size-cells = <0>; > + #address-cells = <1>; > + > + model = "Loongson-2K1000"; Drop, not related. Best regards, Krzysztof
On Fri, Jun 16, 2023 at 5:34 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > On Fri, Jun 16, 2023 at 02:10:38PM +0800, Binbin Zhou wrote: > > Add the available CPUs in LoongArch binding with DT schema format using > > json-schema. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml > > > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml > > new file mode 100644 > > index 000000000000..c3e2dba42c81 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LoongArch CPUs > > + > > +maintainers: > > + - Binbin Zhou <zhoubinbin@loongson.cn> > > + > > +description: > > + The device tree allows to describe the layout of CPUs in a system through > > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > > + defining properties for every CPU. > > + > > +properties: > > + compatible: > > + enum: > > + - loongson,la264 > > + - loongson,la364 > > + > > + reg: > > + maxItems: 1 > > + > > + device_type: true > > + > > + clock-frequency: > > + description: The frequency of cpu in Hz. > > Why don't you just add a ref to the common cpu schema and use the > standard properties for communicating clock frequencies? > You then get the standard properties for l1 caches, power management, > frequency scaling etc as a side effect. Hi Conor: Sorry, not sure if I understand correctly. Do the standard attributes refer to the following: power-domains = <> clocks = <> i-cache-size = <> d-cache-size = <> next-level-cache = <> Thanks. Binbin > > Cheers, > Conor.
On Fri, Jun 16, 2023 at 5:51 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 16/06/2023 08:10, Binbin Zhou wrote: > > Add the available CPUs in LoongArch binding with DT schema format using > > json-schema. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml > > > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml > > new file mode 100644 > > index 000000000000..c3e2dba42c81 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LoongArch CPUs > > + > > +maintainers: > > + - Binbin Zhou <zhoubinbin@loongson.cn> > > + > > +description: > > + The device tree allows to describe the layout of CPUs in a system through > > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > > + defining properties for every CPU. > > I understand you copied it from ARM, but I would prefer to have here > something meaningful. Bindings description does not explain what is DTS, > but explains what the hardware is. Hi Krzysztof: I am very sorry, this is my problem and I will rewrite this part. > > > + > > +properties: > > + compatible: > > + enum: > > + - loongson,la264 > > + - loongson,la364 > > + > > + reg: > > + maxItems: 1 > > + > > + device_type: true > > + > > + clock-frequency: > > + description: The frequency of cpu in Hz. > > + > > + model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: User-visible cpu name in /proc/cpuinfo. > > First, aren't you mixing nodes? > Second, it is derived from compatible, so no need for such property. Well, this attribute is an attempt to tweak it. As the description says, this attribute was added to show the model name in /proc/cpuinfo. here, we will show the custom name instead of using the cpu core name directly. For example, on a Loongson-3A5000 machine, although its cpu core is la464, we can see: [root@fedora ~]# cat /proc/cpuinfo system type : generic-loongson-machine .............. Model Name : Loongson-3A5000-HV ............ CPU MHz : 2500.00 ........... Unfortunately, some Loongson-2K chips are not designed with corresponding CPUNAME registers, so we expect to add them in the DTS. At first, we considered writing it directly into cpu compatible, but it seems that dts compatible is all lower case, while our desired model name contains upper case letters. What do you think if we repositioned this attribute under cpu? cpu0: cpu@0 { compatible = "loongson,la264". model = "Loongson-2K1000". device_type = "cpu". reg= <0x0>. ..... }. > > > + > > +required: > > + - compatible > > + - reg > > + - clock-frequency > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + cpus { > > + #size-cells = <0>; > > + #address-cells = <1>; > > + > > + model = "Loongson-2K1000"; > > Drop, not related. > > Best regards, > Krzysztof >
On 17/06/2023 08:31, Binbin Zhou wrote: > On Fri, Jun 16, 2023 at 5:51 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 16/06/2023 08:10, Binbin Zhou wrote: >>> Add the available CPUs in LoongArch binding with DT schema format using >>> json-schema. >>> >>> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> >>> --- >>> .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ >>> 1 file changed, 65 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml >>> new file mode 100644 >>> index 000000000000..c3e2dba42c81 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml >>> @@ -0,0 +1,65 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: LoongArch CPUs >>> + >>> +maintainers: >>> + - Binbin Zhou <zhoubinbin@loongson.cn> >>> + >>> +description: >>> + The device tree allows to describe the layout of CPUs in a system through >>> + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") >>> + defining properties for every CPU. >> >> I understand you copied it from ARM, but I would prefer to have here >> something meaningful. Bindings description does not explain what is DTS, >> but explains what the hardware is. > > Hi Krzysztof: > > I am very sorry, this is my problem and I will rewrite this part. > >> >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - loongson,la264 >>> + - loongson,la364 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + device_type: true >>> + >>> + clock-frequency: >>> + description: The frequency of cpu in Hz. >>> + >>> + model: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: User-visible cpu name in /proc/cpuinfo. >> >> First, aren't you mixing nodes? >> Second, it is derived from compatible, so no need for such property. > > Well, this attribute is an attempt to tweak it. > > As the description says, this attribute was added to show the model > name in /proc/cpuinfo. here, we will show the custom name instead of > using the cpu core name directly. DTS is not some translation layer. You can decode compatible and put into /proc/cpuinfo whatever you wish. > > For example, on a Loongson-3A5000 machine, although its cpu core is > la464, we can see: > [root@fedora ~]# cat /proc/cpuinfo > system type : generic-loongson-machine > .............. > Model Name : Loongson-3A5000-HV > ............ > CPU MHz : 2500.00 > ........... > > Unfortunately, some Loongson-2K chips are not designed with > corresponding CPUNAME registers, so we expect to add them in the DTS. > > At first, we considered writing it directly into cpu compatible, but > it seems that dts compatible is all lower case, while our desired > model name contains upper case letters. > > What do you think if we repositioned this attribute under cpu? You already did it, so about which solution we talk about? Anyway, I am against store translation of compatibles in DTS. Best regards, Krzysztof
On 17 June 2023 07:29:06 IST, Binbin Zhou <zhoubb.aaron@gmail.com> wrote: >On Fri, Jun 16, 2023 at 5:34 PM Conor Dooley <conor.dooley@microchip.com> wrote: >> >> On Fri, Jun 16, 2023 at 02:10:38PM +0800, Binbin Zhou wrote: >> > Add the available CPUs in LoongArch binding with DT schema format using >> > json-schema. >> > >> > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> >> > --- >> > .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ >> > 1 file changed, 65 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml >> > >> > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> > new file mode 100644 >> > index 000000000000..c3e2dba42c81 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml >> > @@ -0,0 +1,65 @@ >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: LoongArch CPUs >> > + >> > +maintainers: >> > + - Binbin Zhou <zhoubinbin@loongson.cn> >> > + >> > +description: >> > + The device tree allows to describe the layout of CPUs in a system through >> > + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") >> > + defining properties for every CPU. >> > + >> > +properties: >> > + compatible: >> > + enum: >> > + - loongson,la264 >> > + - loongson,la364 >> > + >> > + reg: >> > + maxItems: 1 >> > + >> > + device_type: true >> > + >> > + clock-frequency: >> > + description: The frequency of cpu in Hz. >> >> Why don't you just add a ref to the common cpu schema and use the >> standard properties for communicating clock frequencies? >> You then get the standard properties for l1 caches, power management, >> frequency scaling etc as a side effect. > >Hi Conor: > >Sorry, not sure if I understand correctly. Do the standard attributes >refer to the following: > >power-domains = <> >clocks = <> >i-cache-size = <> >d-cache-size = <> >next-level-cache = <> Yes, those are the sort of things I meant. Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml new file mode 100644 index 000000000000..c3e2dba42c81 --- /dev/null +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/loongarch/cpus.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LoongArch CPUs + +maintainers: + - Binbin Zhou <zhoubinbin@loongson.cn> + +description: + The device tree allows to describe the layout of CPUs in a system through + the "cpus" node, which in turn contains a number of subnodes (ie "cpu") + defining properties for every CPU. + +properties: + compatible: + enum: + - loongson,la264 + - loongson,la364 + + reg: + maxItems: 1 + + device_type: true + + clock-frequency: + description: The frequency of cpu in Hz. + + model: + $ref: /schemas/types.yaml#/definitions/string + description: User-visible cpu name in /proc/cpuinfo. + +required: + - compatible + - reg + - clock-frequency + +additionalProperties: false + +examples: + - | + cpus { + #size-cells = <0>; + #address-cells = <1>; + + model = "Loongson-2K1000"; + + cpu@0 { + compatible = "loongson,la264"; + device_type = "cpu"; + reg = <0>; + clock-frequency = <1000000000>; + }; + + cpu@1 { + compatible = "loongson,la264"; + device_type = "cpu"; + reg = <1>; + clock-frequency = <1000000000>; + }; + }; + +...
Add the available CPUs in LoongArch binding with DT schema format using json-schema. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- .../devicetree/bindings/loongarch/cpus.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml