diff mbox series

[2/2] package/libjxl: requires host-cmake >= 3.19

Message ID 20230605095607.332091-2-romain.naour@gmail.com
State Accepted
Headers show
Series [1/2] support/dependencies: introduce BR2_HOST_CMAKE_AT_LEAST | expand

Commit Message

Romain Naour June 5, 2023, 9:56 a.m. UTC
libjxl requires cmake 3.19 since version v0.7 due to the
new behavior of cmake [1].

-- Configuring done
CMake Error at cmake/FindLCMS2.cmake:40 (add_library):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "INCLUDE_DIRECTORIES" is not allowed.
Call Stack (most recent call first):
  third_party/CMakeLists.txt:114 (find_package)

The portability issue has already been reported upstream [2].

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819095

[1] https://gitlab.kitware.com/cmake/cmake/-/commit/afb998704e67d3d3ce5b24c112cb06e770fca78d
[2] https://github.com/libjxl/libjxl/issues/1425

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>
---
 package/libjxl/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard June 6, 2023, 8:23 p.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > libjxl requires cmake 3.19 since version v0.7 due to the
 > new behavior of cmake [1].

 > -- Configuring done
 > CMake Error at cmake/FindLCMS2.cmake:40 (add_library):
 >   INTERFACE_LIBRARY targets may only have whitelisted properties.  The
 >   property "INCLUDE_DIRECTORIES" is not allowed.
 > Call Stack (most recent call first):
 >   third_party/CMakeLists.txt:114 (find_package)

 > The portability issue has already been reported upstream [2].

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819095

 > [1] https://gitlab.kitware.com/cmake/cmake/-/commit/afb998704e67d3d3ce5b24c112cb06e770fca78d
 > [2] https://github.com/libjxl/libjxl/issues/1425

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>

Committed, thanks.
Peter Korsgaard June 14, 2023, 2:53 p.m. UTC | #2
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > libjxl requires cmake 3.19 since version v0.7 due to the
 > new behavior of cmake [1].

 > -- Configuring done
 > CMake Error at cmake/FindLCMS2.cmake:40 (add_library):
 >   INTERFACE_LIBRARY targets may only have whitelisted properties.  The
 >   property "INCLUDE_DIRECTORIES" is not allowed.
 > Call Stack (most recent call first):
 >   third_party/CMakeLists.txt:114 (find_package)

 > The portability issue has already been reported upstream [2].

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819095

 > [1] https://gitlab.kitware.com/cmake/cmake/-/commit/afb998704e67d3d3ce5b24c112cb06e770fca78d
 > [2] https://github.com/libjxl/libjxl/issues/1425

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Julien Olivain <ju.o@free.fr>

Committed to 2023.02.x, thanks.
diff mbox series

Patch

diff --git a/package/libjxl/Config.in b/package/libjxl/Config.in
index da04b89f9b..923560298f 100644
--- a/package/libjxl/Config.in
+++ b/package/libjxl/Config.in
@@ -7,6 +7,7 @@  config BR2_PACKAGE_LIBJXL
 	# libjxl fail to link statically due to libatomic issue
 	depends on !BR2_STATIC_LIBS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_81426
+	select BR2_HOST_CMAKE_AT_LEAST_3_19
 	select BR2_PACKAGE_BROTLI
 	select BR2_PACKAGE_HIGHWAY
 	select BR2_PACKAGE_LCMS2