diff mbox series

[SRU,L:raspi] UBUNTU: [Config] raspi: Set I2C_CHARDEV=y

Message ID 20230614065711.207718-1-juerg.haefliger@canonical.com
State New
Headers show
Series [SRU,L:raspi] UBUNTU: [Config] raspi: Set I2C_CHARDEV=y | expand

Commit Message

Juerg Haefliger June 14, 2023, 6:57 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2019320

User space expects /dev/i2c-* device entries but in raspi 6.2 the i2c-dev
driver is compiled as a module which is not auto-loaded, hence no device
entries. The driver is small enough to not have a significant impact on
kernel memory consumption for applications that don't need i2c, so compile
it into the kernel (as in previous releases).

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 debian.raspi/config/annotations | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrei Gherzan June 14, 2023, 7:41 a.m. UTC | #1
On 23/06/14 08:57AM, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/2019320
> 
> User space expects /dev/i2c-* device entries but in raspi 6.2 the i2c-dev
> driver is compiled as a module which is not auto-loaded, hence no device
> entries. The driver is small enough to not have a significant impact on
> kernel memory consumption for applications that don't need i2c, so compile
> it into the kernel (as in previous releases).
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  debian.raspi/config/annotations | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/annotations b/debian.raspi/config/annotations
> index 3ec0b739073f..d234e87fa22e 100644
> --- a/debian.raspi/config/annotations
> +++ b/debian.raspi/config/annotations
> @@ -91,7 +91,7 @@ CONFIG_HUGETLBFS                                policy<{'arm64': 'y', 'armhf': '
>  CONFIG_HWSPINLOCK                               policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi'>
>  CONFIG_I2C_BCM2708                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Introduced by rpi-6.2.y'>
>  CONFIG_I2C_BCM2708_BAUDRATE                     policy<{'arm64': '100000', 'armhf': '100000'}> note<'Introduced by rpi-6.2.y'>
> -CONFIG_I2C_CHARDEV                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
> +CONFIG_I2C_CHARDEV                              policy<{'arm64': 'y', 'armhf': 'y'}> note<'LP: #2019320 - i2c devices missing in lunar'>
>  CONFIG_I2C_DESIGNWARE_PLATFORM                  policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
>  CONFIG_I2C_EMEV2                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi armhf'>
>  CONFIG_I2C_SLAVE                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not desired on Pi'>
> -- 
> 2.37.2

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Tim Gardner June 14, 2023, 2:23 p.m. UTC | #2
On 6/13/23 23:57, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/2019320
> 
> User space expects /dev/i2c-* device entries but in raspi 6.2 the i2c-dev
> driver is compiled as a module which is not auto-loaded, hence no device
> entries. The driver is small enough to not have a significant impact on
> kernel memory consumption for applications that don't need i2c, so compile
> it into the kernel (as in previous releases).
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>   debian.raspi/config/annotations | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/annotations b/debian.raspi/config/annotations
> index 3ec0b739073f..d234e87fa22e 100644
> --- a/debian.raspi/config/annotations
> +++ b/debian.raspi/config/annotations
> @@ -91,7 +91,7 @@ CONFIG_HUGETLBFS                                policy<{'arm64': 'y', 'armhf': '
>   CONFIG_HWSPINLOCK                               policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi'>
>   CONFIG_I2C_BCM2708                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Introduced by rpi-6.2.y'>
>   CONFIG_I2C_BCM2708_BAUDRATE                     policy<{'arm64': '100000', 'armhf': '100000'}> note<'Introduced by rpi-6.2.y'>
> -CONFIG_I2C_CHARDEV                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
> +CONFIG_I2C_CHARDEV                              policy<{'arm64': 'y', 'armhf': 'y'}> note<'LP: #2019320 - i2c devices missing in lunar'>
>   CONFIG_I2C_DESIGNWARE_PLATFORM                  policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
>   CONFIG_I2C_EMEV2                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi armhf'>
>   CONFIG_I2C_SLAVE                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not desired on Pi'>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Juerg Haefliger June 16, 2023, 4:24 a.m. UTC | #3
Applied to lunar:raspi master-next branch.

...Juerg


> BugLink: https://bugs.launchpad.net/bugs/2019320
> 
> User space expects /dev/i2c-* device entries but in raspi 6.2 the i2c-dev
> driver is compiled as a module which is not auto-loaded, hence no device
> entries. The driver is small enough to not have a significant impact on
> kernel memory consumption for applications that don't need i2c, so compile
> it into the kernel (as in previous releases).
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  debian.raspi/config/annotations | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/annotations b/debian.raspi/config/annotations
> index 3ec0b739073f..d234e87fa22e 100644
> --- a/debian.raspi/config/annotations
> +++ b/debian.raspi/config/annotations
> @@ -91,7 +91,7 @@ CONFIG_HUGETLBFS                                policy<{'arm64': 'y', 'armhf': '
>  CONFIG_HWSPINLOCK                               policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi'>
>  CONFIG_I2C_BCM2708                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Introduced by rpi-6.2.y'>
>  CONFIG_I2C_BCM2708_BAUDRATE                     policy<{'arm64': '100000', 'armhf': '100000'}> note<'Introduced by rpi-6.2.y'>
> -CONFIG_I2C_CHARDEV                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
> +CONFIG_I2C_CHARDEV                              policy<{'arm64': 'y', 'armhf': 'y'}> note<'LP: #2019320 - i2c devices missing in lunar'>
>  CONFIG_I2C_DESIGNWARE_PLATFORM                  policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
>  CONFIG_I2C_EMEV2                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi armhf'>
>  CONFIG_I2C_SLAVE                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not desired on Pi'>
diff mbox series

Patch

diff --git a/debian.raspi/config/annotations b/debian.raspi/config/annotations
index 3ec0b739073f..d234e87fa22e 100644
--- a/debian.raspi/config/annotations
+++ b/debian.raspi/config/annotations
@@ -91,7 +91,7 @@  CONFIG_HUGETLBFS                                policy<{'arm64': 'y', 'armhf': '
 CONFIG_HWSPINLOCK                               policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi'>
 CONFIG_I2C_BCM2708                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Introduced by rpi-6.2.y'>
 CONFIG_I2C_BCM2708_BAUDRATE                     policy<{'arm64': '100000', 'armhf': '100000'}> note<'Introduced by rpi-6.2.y'>
-CONFIG_I2C_CHARDEV                              policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
+CONFIG_I2C_CHARDEV                              policy<{'arm64': 'y', 'armhf': 'y'}> note<'LP: #2019320 - i2c devices missing in lunar'>
 CONFIG_I2C_DESIGNWARE_PLATFORM                  policy<{'arm64': 'm', 'armhf': 'm'}> note<'Not essential on Pi'>
 CONFIG_I2C_EMEV2                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not supported on Pi armhf'>
 CONFIG_I2C_SLAVE                                policy<{'arm64': 'n', 'armhf': 'n'}> note<'Not desired on Pi'>