mbox series

[SRU,J/K/L,0/1] UBUNTU: SAUCE: selftests/ftrace: Add test dependency

Message ID 20230613134702.615805-1-thibault.ferrante@canonical.com
Headers show
Series UBUNTU: SAUCE: selftests/ftrace: Add test dependency | expand

Message

Thibault Ferrante June 13, 2023, 1:47 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1977827

[Impact]
Test was failing because the kernel didn't fullfill unspecified
requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.

[Fix]
Add required runtime dependency to the test.
  
[Test case]
Self-test passed on generic kernels and skipped for kvm kernels
as it should.

[Potential regression]
Only concern the testing suite, no impact on running systems.


Thibault Ferrante (1):
  UBUNTU: SAUCE: selftests/ftrace: Add test dependency

 .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner June 13, 2023, 9:39 p.m. UTC | #1
On 6/13/23 06:47, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/1977827
> 
> [Impact]
> Test was failing because the kernel didn't fullfill unspecified
> requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.
> 
> [Fix]
> Add required runtime dependency to the test.
>    
> [Test case]
> Self-test passed on generic kernels and skipped for kvm kernels
> as it should.
> 
> [Potential regression]
> Only concern the testing suite, no impact on running systems.
> 
> 
> Thibault Ferrante (1):
>    UBUNTU: SAUCE: selftests/ftrace: Add test dependency
> 
>   .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader June 14, 2023, 8:37 a.m. UTC | #2
On 13.06.23 15:47, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/1977827
> 
> [Impact]
> Test was failing because the kernel didn't fullfill unspecified
> requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.
> 
> [Fix]
> Add required runtime dependency to the test.
>    
> [Test case]
> Self-test passed on generic kernels and skipped for kvm kernels
> as it should.
> 
> [Potential regression]
> Only concern the testing suite, no impact on running systems.
> 
> 
> Thibault Ferrante (1):
>    UBUNTU: SAUCE: selftests/ftrace: Add test dependency
> 
>   .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Instead of a SAUCE patch, should this not be something submitted 
upstream and then imported back? What is the plan for Mantic onward?

-Stefan
Thibault Ferrante June 14, 2023, 10:12 a.m. UTC | #3
On 14/06/2023 10:37, Stefan Bader wrote:
> On 13.06.23 15:47, Thibault Ferrante wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1977827
>>
>> [Impact]
>> Test was failing because the kernel didn't fullfill unspecified
>> requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.
>>
>> [Fix]
>> Add required runtime dependency to the test.
>> [Test case]
>> Self-test passed on generic kernels and skipped for kvm kernels
>> as it should.
>>
>> [Potential regression]
>> Only concern the testing suite, no impact on running systems.
>>
>>
>> Thibault Ferrante (1):
>>    UBUNTU: SAUCE: selftests/ftrace: Add test dependency
>>
>>   .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Instead of a SAUCE patch, should this not be something submitted 
> upstream and then imported back? What is the plan for Mantic onward?
> 
> -Stefan
> 
I plan to upstream it soon, but I figured out it would be valuable to 
have it already for next release as this affects multiple distributions.

--
Thibault
Stefan Bader June 14, 2023, 10:20 a.m. UTC | #4
On 13.06.23 15:47, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/1977827
> 
> [Impact]
> Test was failing because the kernel didn't fullfill unspecified
> requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.
> 
> [Fix]
> Add required runtime dependency to the test.
>    
> [Test case]
> Self-test passed on generic kernels and skipped for kvm kernels
> as it should.
> 
> [Potential regression]
> Only concern the testing suite, no impact on running systems.
> 
> 
> Thibault Ferrante (1):
>    UBUNTU: SAUCE: selftests/ftrace: Add test dependency
> 
>   .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader June 15, 2023, 3:38 p.m. UTC | #5
On 13.06.23 15:47, Thibault Ferrante wrote:
> BugLink: https://bugs.launchpad.net/bugs/1977827
> 
> [Impact]
> Test was failing because the kernel didn't fullfill unspecified
> requirement. These failures happen at least on J-kvm, K-kvm, L-kvm.
> 
> [Fix]
> Add required runtime dependency to the test.
>    
> [Test case]
> Self-test passed on generic kernels and skipped for kvm kernels
> as it should.
> 
> [Potential regression]
> Only concern the testing suite, no impact on running systems.
> 
> 
> Thibault Ferrante (1):
>    UBUNTU: SAUCE: selftests/ftrace: Add test dependency
> 
>   .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to lunar,kinetic,jammy:linux/master-next. Thanks.

-Stefan