diff mbox series

[1/4] dt-bindings: clock: imx8m: Add missing interrupt property

Message ID 20230510065644.1317577-1-alexander.stein@ew.tq-group.com
State Not Applicable, archived
Headers show
Series [1/4] dt-bindings: clock: imx8m: Add missing interrupt property | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dt-meta-schema fail build log

Commit Message

Alexander Stein May 10, 2023, 6:56 a.m. UTC
All i.MX8M SoC have 2 CCM interrupts, called:
* Interrupt Request 1
* Interrupt Request 2

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Admittedly despite listing them in the interrupt list, there is no
further description.
If it is deemed these IRQs are useless, the corresponding property in
imx8mq.dtsi should be removed instead.

 Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski May 10, 2023, 8:25 a.m. UTC | #1
On 10/05/2023 08:56, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Admittedly despite listing them in the interrupt list, there is no
> further description.
> If it is deemed these IRQs are useless, the corresponding property in
> imx8mq.dtsi should be removed instead.
> 
>  Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
>  1 file changed, 3 insertions(+)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Abel Vesa June 12, 2023, 9:06 a.m. UTC | #2
On 23-05-10 08:56:41, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
> Admittedly despite listing them in the interrupt list, there is no
> further description.
> If it is deemed these IRQs are useless, the corresponding property in
> imx8mq.dtsi should be removed instead.
> 
>  Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> index 0dbc1433fede..80539f88bc27 100644
> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> @@ -24,6 +24,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 2
> +
>    clocks:
>      minItems: 6
>      maxItems: 7
> -- 
> 2.34.1
>
Abel Vesa June 12, 2023, 9:32 a.m. UTC | #3
On Wed, 10 May 2023 08:56:41 +0200, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> 

Applied, thanks!

[1/4] dt-bindings: clock: imx8m: Add missing interrupt property
      commit: 6e6bb1639136f36c82efda147b63e2a2197fa3f8

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
index 0dbc1433fede..80539f88bc27 100644
--- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
@@ -24,6 +24,9 @@  properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 2
+
   clocks:
     minItems: 6
     maxItems: 7