mbox series

[SRU,Focal,Jammy,OEM-5.17,OEM-6.0,OEM-6.1,Kinetic,Lunar,0/1] LP: #2023220

Message ID 20230607203321.2456329-1-cascardo@canonical.com
Headers show
Series LP: #2023220 | expand

Message

Thadeu Lima de Souza Cascardo June 7, 2023, 8:33 p.m. UTC
[Impact]
When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
the global TLB entries. This can lead to info leak or undefined behavior.

[Mitigation]
Boot with nopcid on affected systems.

[Backports]
Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was picked.

[Test case]
There is no particular test case.

[Potential regressions]
This affects performance on the affected systems. TLB behavior could also be
affected.

Dave Hansen (1):
  x86/mm: Avoid incomplete Global INVLPG flushes

 arch/x86/include/asm/intel-family.h |  5 +++++
 arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
 2 files changed, 30 insertions(+)

Comments

Cengiz Can June 8, 2023, 12:53 p.m. UTC | #1
On Wed, 2023-06-07 at 17:33 -0300, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not
> flush
> the global TLB entries. This can lead to info leak or undefined
> behavior.
> 
> [Mitigation]
> Boot with nopcid on affected systems.
> 
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y
> was picked.
> 
> [Test case]
> There is no particular test case.
> 
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could
> also be
> affected.
> 
> Dave Hansen (1):
>   x86/mm: Avoid incomplete Global INVLPG flushes

Acked-by: Cengiz Can <cengiz.can@canonical.com>

> 
>  arch/x86/include/asm/intel-family.h |  5 +++++
>  arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
> 
> -- 
> 2.34.1
> 
>
Tim Gardner June 8, 2023, 3:57 p.m. UTC | #2
On 6/7/23 2:33 PM, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
> the global TLB entries. This can lead to info leak or undefined behavior.
> 
> [Mitigation]
> Boot with nopcid on affected systems.
> 
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was picked.
> 
> [Test case]
> There is no particular test case.
> 
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could also be
> affected.
> 
> Dave Hansen (1):
>    x86/mm: Avoid incomplete Global INVLPG flushes
> 
>   arch/x86/include/asm/intel-family.h |  5 +++++
>   arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>   2 files changed, 30 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Luke Nowakowski-Krijger June 8, 2023, 7:15 p.m. UTC | #3
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

On Wed, Jun 7, 2023 at 1:35 PM Thadeu Lima de Souza Cascardo <
cascardo@canonical.com> wrote:

> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
> the global TLB entries. This can lead to info leak or undefined behavior.
>
> [Mitigation]
> Boot with nopcid on affected systems.
>
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was
> picked.
>
> [Test case]
> There is no particular test case.
>
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could also
> be
> affected.
>
> Dave Hansen (1):
>   x86/mm: Avoid incomplete Global INVLPG flushes
>
>  arch/x86/include/asm/intel-family.h |  5 +++++
>  arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Andrei Gherzan June 9, 2023, 1:33 p.m. UTC | #4
On 23/06/07 05:33PM, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
> the global TLB entries. This can lead to info leak or undefined behavior.
> 
> [Mitigation]
> Boot with nopcid on affected systems.
> 
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was picked.
> 
> [Test case]
> There is no particular test case.
> 
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could also be
> affected.
> 
> Dave Hansen (1):
>   x86/mm: Avoid incomplete Global INVLPG flushes
> 
>  arch/x86/include/asm/intel-family.h |  5 +++++
>  arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
> 
> -- 
> 2.34.1

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Luke Nowakowski-Krijger June 12, 2023, 8:53 p.m. UTC | #5
Applied to focal, jammy, kinetic, lunar linux master-next,

Thanks,
- Luke

On Wed, Jun 7, 2023 at 1:35 PM Thadeu Lima de Souza Cascardo <
cascardo@canonical.com> wrote:

> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
> the global TLB entries. This can lead to info leak or undefined behavior.
>
> [Mitigation]
> Boot with nopcid on affected systems.
>
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was
> picked.
>
> [Test case]
> There is no particular test case.
>
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could also
> be
> affected.
>
> Dave Hansen (1):
>   x86/mm: Avoid incomplete Global INVLPG flushes
>
>  arch/x86/include/asm/intel-family.h |  5 +++++
>  arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Timo Aaltonen June 13, 2023, 1:40 p.m. UTC | #6
Thadeu Lima de Souza Cascardo kirjoitti 7.6.2023 klo 23.33:
> [Impact]
> When PCIDs are enabled on Alder Lake and Raptor Lake, INVLPG will not flush
> the global TLB entries. This can lead to info leak or undefined behavior.
> 
> [Mitigation]
> Boot with nopcid on affected systems.
> 
> [Backports]
> Clean cherry-pick, except for 5.4, where backport from linux-5.4.y was picked.
> 
> [Test case]
> There is no particular test case.
> 
> [Potential regressions]
> This affects performance on the affected systems. TLB behavior could also be
> affected.
> 
> Dave Hansen (1):
>    x86/mm: Avoid incomplete Global INVLPG flushes
> 
>   arch/x86/include/asm/intel-family.h |  5 +++++
>   arch/x86/mm/init.c                  | 25 +++++++++++++++++++++++++
>   2 files changed, 30 insertions(+)
> 

applied to oem kernels, thanks