| Message ID | cover.1685974993.git.xdrudis@tinet.cat |
|---|---|
| Headers | show |
| Series | arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2 | expand |
On 6/5/23 17:04, Xavier Drudis Ferran wrote: > EHCI probing in Rock pi 4 currently fails. > > Add a clock driver for usb2phy so that probing EHCI does not fail when > missing one of the clocks in the bundle for usb_host0_ehci, since > usb2phy is UCLASS_PHY but not UCLASS_CLK. > > Xavier Drudis Ferran (2): > phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clock > phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock > > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +++++++++++++++++- > 1 file changed, 106 insertions(+), 3 deletions(-) Applied both to usb/master . btw the cover letter subject should not have 'arm: dts:' tags, but rather 'phy:' tag , since this does not touch any DTs .
El Wed, Jun 07, 2023 at 11:42:40PM +0200, Marek Vasut deia: > On 6/5/23 17:04, Xavier Drudis Ferran wrote: > > EHCI probing in Rock pi 4 currently fails. > > > > Add a clock driver for usb2phy so that probing EHCI does not fail when > > missing one of the clocks in the bundle for usb_host0_ehci, since > > usb2phy is UCLASS_PHY but not UCLASS_CLK. > > > > Xavier Drudis Ferran (2): > > phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clock > > phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock > > > > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +++++++++++++++++- > > 1 file changed, 106 insertions(+), 3 deletions(-) > > Applied both to usb/master . > > btw the cover letter subject should not have 'arm: dts:' tags, but rather > 'phy:' tag , since this does not touch any DTs . Yes, sorry. v1 did touch *-u-boot.dts. I hesitated about what was more confusing, changing subject on different versions of a patch with the same intent or keeping the old subject. Thanks for merging.
EHCI probing in Rock pi 4 currently fails. Add a clock driver for usb2phy so that probing EHCI does not fail when missing one of the clocks in the bundle for usb_host0_ehci, since usb2phy is UCLASS_PHY but not UCLASS_CLK. Xavier Drudis Ferran (2): phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clock phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +++++++++++++++++- 1 file changed, 106 insertions(+), 3 deletions(-) Cc: Simon Glass <sjg@chromium.org> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu> Cc: Kever Yang <kever.yang@rock-chips.com> Cc: Lukasz Majewski <lukma@denx.de> Cc: Sean Anderson <seanga2@gmail.com> Cc: Marek Vasut <marex@denx.de> Cc: Christoph Fritz <chf.fritz@googlemail.com> Cc: Jagan Teki <jagan@amarulasolutions.com> Signed-off-by: Xavier Drudis Ferran <xdrudis@tinet.cat> --- Changes: v7: Error handling. Remove unnecessary if. Adding config data for rk3568 (untested). v6: just retested over current next branch and some corrections to message and headers (no changes to code). v5: fixes a bug that Christoph Fritz discovered, consisting in the wrong eror code returned when enabling or disabling the clock because property_enable() returns an error code in linux but the modified register value in U-Boot. This caused the clk disable to abort before freeing the clock. v4: move v3 to one patch in the series and add a second patch to add operations to enable disable the usb2phy 480Mhz clock. Also, honour clock-output-names for what is worth. v3: implement option 5 (bind usb2phy as a clk driver too) instead of option 1 (ehci-generic.c tolerates missing clocks). v2: implement option 1 (ehci-generic.c tolerates missing clocks) instead of option 3 (change dts node to remove the missing clock).