diff mbox series

[RESEND] usb: musb-new: sunxi: fix error check

Message ID 20230605171937.3286-1-CFSworks@gmail.com
State Accepted
Commit 3cbd92da9f49bbff630a615887132da03444ce43
Delegated to: Marek Vasut
Headers show
Series [RESEND] usb: musb-new: sunxi: fix error check | expand

Commit Message

Sam Edwards June 5, 2023, 5:19 p.m. UTC 
The `musb_register` function returns some ERR_PTR(...) on failure,
not NULL, so update the check here appropriately.

Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Marek Vasut <marex@denx.de>
---
 drivers/usb/musb-new/sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut June 7, 2023, 9:39 p.m. UTC | #1 
On 6/5/23 19:19, Sam Edwards wrote:
> The `musb_register` function returns some ERR_PTR(...) on failure,
> not NULL, so update the check here appropriately.

Applied to usb/master, thanks .
diff mbox series

Patch

diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
index 6e60dd47e0..65a528e229 100644
--- a/drivers/usb/musb-new/sunxi.c
+++ b/drivers/usb/musb-new/sunxi.c
@@ -488,7 +488,7 @@  static int musb_usb_probe(struct udevice *dev)
 #else
 	pdata.mode = MUSB_PERIPHERAL;
 	host->host = musb_register(&pdata, &glue->dev, base);
-	if (!host->host)
+	if (IS_ERR_OR_NULL(host->host))
 		return -EIO;
 
 	printf("Allwinner mUSB OTG (Peripheral)\n");