mbox series

[0/2,SRU,J:linux-bluefield,v1,0/2] UBUNTU: SAUCE: mlxbf-tmfifo: robust fix to drop over-sized packet or no Rx descriptors

Message ID cover.1685455239.git.limings@nvidia.com
Headers show
Series UBUNTU: SAUCE: mlxbf-tmfifo: robust fix to drop over-sized packet or no Rx descriptors | expand

Message

Liming Sun May 30, 2023, 2:30 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2021749

SRU Justification:

[Impact]
This change is needed to avoid potential tmfifo console stuck when
network interface is down or receiving oversized packets.

[Fix]
Drop the Rx packets in the above cases. Since tmfifo is shared
resource for both console and networking. Dropping such network
packets can continue to process the fifo and avoid console stuck.

[Test Case]
Same functionality and testing as on BlueField-1/2/3. No functionality
change. Add negative tests:
- 'ifconfig tmfifo_net0 down' on ARM side during traffic, then verify
  rshim console doesn't stuck.
- Config MTU to 4000 on rshim host and send oversized packet with command
  'ping 192.168.100.2 -s 2000". It shouldn't cause any stuck.

[Regression Potential]
Same behavior from user perspective.

Liming Sun (2):
  mlxbf-tmfifo: Drop the Rx packet if no more descriptors
  mlxbf-tmfifo: Drop jumbo frames

 drivers/platform/mellanox/mlxbf-tmfifo.c | 88 +++++++++++++++++-------
 1 file changed, 62 insertions(+), 26 deletions(-)

Comments

Tim Gardner June 5, 2023, 1:31 p.m. UTC | #1 
On 5/30/23 8:30 AM, Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/2021749
> 
> SRU Justification:
> 
> [Impact]
> This change is needed to avoid potential tmfifo console stuck when
> network interface is down or receiving oversized packets.
> 
> [Fix]
> Drop the Rx packets in the above cases. Since tmfifo is shared
> resource for both console and networking. Dropping such network
> packets can continue to process the fifo and avoid console stuck.
> 
> [Test Case]
> Same functionality and testing as on BlueField-1/2/3. No functionality
> change. Add negative tests:
> - 'ifconfig tmfifo_net0 down' on ARM side during traffic, then verify
>    rshim console doesn't stuck.
> - Config MTU to 4000 on rshim host and send oversized packet with command
>    'ping 192.168.100.2 -s 2000". It shouldn't cause any stuck.
> 
> [Regression Potential]
> Same behavior from user perspective.
> 
> Liming Sun (2):
>    mlxbf-tmfifo: Drop the Rx packet if no more descriptors
>    mlxbf-tmfifo: Drop jumbo frames
> 
>   drivers/platform/mellanox/mlxbf-tmfifo.c | 88 +++++++++++++++++-------
>   1 file changed, 62 insertions(+), 26 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

ACK v2
Stefan Bader June 6, 2023, 9:58 a.m. UTC | #2 
On 30.05.23 16:30, Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/2021749
> 
> SRU Justification:
> 
> [Impact]
> This change is needed to avoid potential tmfifo console stuck when
> network interface is down or receiving oversized packets.
> 
> [Fix]
> Drop the Rx packets in the above cases. Since tmfifo is shared
> resource for both console and networking. Dropping such network
> packets can continue to process the fifo and avoid console stuck.
> 
> [Test Case]
> Same functionality and testing as on BlueField-1/2/3. No functionality
> change. Add negative tests:
> - 'ifconfig tmfifo_net0 down' on ARM side during traffic, then verify
>    rshim console doesn't stuck.
> - Config MTU to 4000 on rshim host and send oversized packet with command
>    'ping 192.168.100.2 -s 2000". It shouldn't cause any stuck.
> 
> [Regression Potential]
> Same behavior from user perspective.
> 
> Liming Sun (2):
>    mlxbf-tmfifo: Drop the Rx packet if no more descriptors
>    mlxbf-tmfifo: Drop jumbo frames
> 
>   drivers/platform/mellanox/mlxbf-tmfifo.c | 88 +++++++++++++++++-------
>   1 file changed, 62 insertions(+), 26 deletions(-)
> 

Rejected for the following reasons:
There seems to be a v2 of this which is already pending application.

-Stefan
Liming Sun June 6, 2023, 11:57 a.m. UTC | #3 
Thanks. Yes, this one has been obsoleted by v2.

- Liming

> -----Original Message-----
> From: Stefan Bader <stefan.bader@canonical.com>
> Sent: Tuesday, June 6, 2023 5:58 AM
> To: Liming Sun <limings@nvidia.com>; kernel-team@lists.ubuntu.com
> Subject: NACK/Cmnt: [PATCH 0/2] [SRU][J:linux-bluefield][PATCH v1 0/2]
> UBUNTU: SAUCE: mlxbf-tmfifo: robust fix to drop over-sized packet or no Rx
> descriptors
> 
> On 30.05.23 16:30, Liming Sun wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2021749
> >
> > SRU Justification:
> >
> > [Impact]
> > This change is needed to avoid potential tmfifo console stuck when
> > network interface is down or receiving oversized packets.
> >
> > [Fix]
> > Drop the Rx packets in the above cases. Since tmfifo is shared
> > resource for both console and networking. Dropping such network
> > packets can continue to process the fifo and avoid console stuck.
> >
> > [Test Case]
> > Same functionality and testing as on BlueField-1/2/3. No functionality
> > change. Add negative tests:
> > - 'ifconfig tmfifo_net0 down' on ARM side during traffic, then verify
> >    rshim console doesn't stuck.
> > - Config MTU to 4000 on rshim host and send oversized packet with
> command
> >    'ping 192.168.100.2 -s 2000". It shouldn't cause any stuck.
> >
> > [Regression Potential]
> > Same behavior from user perspective.
> >
> > Liming Sun (2):
> >    mlxbf-tmfifo: Drop the Rx packet if no more descriptors
> >    mlxbf-tmfifo: Drop jumbo frames
> >
> >   drivers/platform/mellanox/mlxbf-tmfifo.c | 88 +++++++++++++++++-------
> >   1 file changed, 62 insertions(+), 26 deletions(-)
> >
> 
> Rejected for the following reasons:
> There seems to be a v2 of this which is already pending application.
> 
> -Stefan