diff mbox series

[v2,1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al.

Message ID 20230601131332.26877-2-francesco@dolcini.it
State Not Applicable, archived
Headers show
Series Add Toradex Verdin AM62 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Francesco Dolcini June 1, 2023, 1:13 p.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
nonwifi and wifi variants and the carrier boards (Dahlia,
Verdin Development Board and Yavia) they may be mated in.

Link: https://developer.toradex.com/hardware/verdin-som-family/modules/verdin-am62/
Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
v2: added reviewed-by
---
 .../devicetree/bindings/arm/ti/k3.yaml        | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Tony Lindgren June 2, 2023, 7:20 a.m. UTC | #1
Hi,

* Francesco Dolcini <francesco@dolcini.it> [230601 13:15]:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
> nonwifi and wifi variants and the carrier boards (Dahlia,
> Verdin Development Board and Yavia) they may be mated in.

Looks like you have wifi on sdio, there should be no need for separate
compatible properties. The sdio wifi will try to probe and will just bail
out if no wifi is populated.

If however the non-wifi variants are recycling the sdio pins for something
else, then it's it's a different story. In that case you want either
seprate compatible properties, or want to use dts fragments possibly.

Regards,

Tony
Francesco Dolcini June 2, 2023, 8:18 a.m. UTC | #2
On Fri, Jun 02, 2023 at 10:20:45AM +0300, Tony Lindgren wrote:
> Hi,
> 
> * Francesco Dolcini <francesco@dolcini.it> [230601 13:15]:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
> > nonwifi and wifi variants and the carrier boards (Dahlia,
> > Verdin Development Board and Yavia) they may be mated in.
> 
> Looks like you have wifi on sdio, there should be no need for separate
> compatible properties. The sdio wifi will try to probe and will just bail
> out if no wifi is populated.
> 
> If however the non-wifi variants are recycling the sdio pins for something
> else, then it's it's a different story. In that case you want either
> seprate compatible properties, or want to use dts fragments possibly.

This is exactly the case, the wifi/non-wifi variant are re-using pins.

I provided a more verbose explanation on that on a previous discussion
https://lore.kernel.org/all/ZG5jYV%2FNfGJvYkma@francesco-nb.int.toradex.com/

Francesco
Tony Lindgren June 5, 2023, 4:48 a.m. UTC | #3
* Francesco Dolcini <francesco@dolcini.it> [230602 08:18]:
> On Fri, Jun 02, 2023 at 10:20:45AM +0300, Tony Lindgren wrote:
> > Hi,
> > 
> > * Francesco Dolcini <francesco@dolcini.it> [230601 13:15]:
> > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > 
> > > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
> > > nonwifi and wifi variants and the carrier boards (Dahlia,
> > > Verdin Development Board and Yavia) they may be mated in.
> > 
> > Looks like you have wifi on sdio, there should be no need for separate
> > compatible properties. The sdio wifi will try to probe and will just bail
> > out if no wifi is populated.
> > 
> > If however the non-wifi variants are recycling the sdio pins for something
> > else, then it's it's a different story. In that case you want either
> > seprate compatible properties, or want to use dts fragments possibly.
> 
> This is exactly the case, the wifi/non-wifi variant are re-using pins.
> 
> I provided a more verbose explanation on that on a previous discussion
> https://lore.kernel.org/all/ZG5jYV%2FNfGJvYkma@francesco-nb.int.toradex.com/

Ok thanks for the information.

Regards,

Tony
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index e1183f90bb06..e3aee191d403 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -33,6 +33,26 @@  properties:
               - ti,am62-lp-sk
           - const: ti,am625
 
+      - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards
+        items:
+          - enum:
+              - toradex,verdin-am62-nonwifi-dahlia # Verdin AM62 Module on Dahlia
+              - toradex,verdin-am62-nonwifi-dev    # Verdin AM62 Module on Verdin Development Board
+              - toradex,verdin-am62-nonwifi-yavia  # Verdin AM62 Module on Yavia
+          - const: toradex,verdin-am62-nonwifi     # Verdin AM62 Module without Wi-Fi / BT
+          - const: toradex,verdin-am62             # Verdin AM62 Module
+          - const: ti,am625
+
+      - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards with Wi-Fi / BT
+        items:
+          - enum:
+              - toradex,verdin-am62-wifi-dahlia # Verdin AM62 Wi-Fi / BT Module on Dahlia
+              - toradex,verdin-am62-wifi-dev    # Verdin AM62 Wi-Fi / BT M. on Verdin Development B.
+              - toradex,verdin-am62-wifi-yavia  # Verdin AM62 Wi-Fi / BT Module on Yavia
+          - const: toradex,verdin-am62-wifi     # Verdin AM62 Wi-Fi / BT Module
+          - const: toradex,verdin-am62          # Verdin AM62 Module
+          - const: ti,am625
+
       - description: K3 AM642 SoC
         items:
           - enum: