diff mbox

ext4: Report max_batch_time option correctly

Message ID 1325513582.13595.213.camel@deadeye
State Accepted, archived
Headers show

Commit Message

Ben Hutchings Jan. 2, 2012, 2:13 p.m. UTC
Currently the value reported for max_batch_time is really the
value of min_batch_time.

Reported-by: Russell Coker <russell@coker.com.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 fs/ext4/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Eric Sandeen Jan. 3, 2012, 3:46 p.m. UTC | #1
On 1/2/12 8:13 AM, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
> 
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

whoops, yep!

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/ext4/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 3e1329e..410e993 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1096,7 +1096,7 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
>  	}
>  	if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
>  		seq_printf(seq, ",max_batch_time=%u",
> -			   (unsigned) sbi->s_min_batch_time);
> +			   (unsigned) sbi->s_max_batch_time);
>  	}
>  
>  	/*

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o Jan. 5, 2012, 2:23 a.m. UTC | #2
On Mon, Jan 02, 2012 at 02:13:02PM +0000, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
> 
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 3e1329e..410e993 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1096,7 +1096,7 @@  static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
 	}
 	if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
 		seq_printf(seq, ",max_batch_time=%u",
-			   (unsigned) sbi->s_min_batch_time);
+			   (unsigned) sbi->s_max_batch_time);
 	}
 
 	/*