| Message ID | 20230518155546.168561-1-john.cabaj@canonical.com |
|---|---|
| Headers | show |
| Series | Undefined Behavior Sanitizer (UBSAN) causes failure to match symbols | expand |
On Thu, 18 May 2023 at 16:56, John Cabaj <john.cabaj@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/2003374 > > [Impact] > * When UBSAN is enabled in an s390x kernel configuration, kpatch-build can fail to find matching symbols in the vmlinux symbol table. This was discovered in both Jammy 5.15 and Kinetic 5.19 kernels. > * UBSAN was disabled in the Jammy 5.15 s390x kernel configuration to resolve the issue > * Upstream kpatch recently resolved the issue via https://github.com/dynup/kpatch/pull/1332/commits/85344cf524cccc7b8e10bf04ed38a0f586bffd10, so this patch re-enables UBSAN for Jammy 5.15 s390x kernel configuration. Is that fix already uploaded to all relevant kpatch packages we have in various places? > > [Fix] > * Simple config change > > [Test Case] > * Used kpatch-build v0.9.8 to build and load a fs/proc/meminfo.c Livepatch on s390x kernel successfully > > [Where problems could occur] > * Should not introduce any regressions as functionality was enabled since original Jammy 5.15 kernel until v5.15.0-70.77 > > John Cabaj (1): > UBUNTU: [Config] s390x: Re-adding UBSAN to configuration > > debian.master/config/annotations | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 5/18/23 7:02 PM, Dimitri John Ledkov wrote: > On Thu, 18 May 2023 at 16:56, John Cabaj <john.cabaj@canonical.com> wrote: >> >> BugLink: https://bugs.launchpad.net/bugs/2003374 >> >> [Impact] >> * When UBSAN is enabled in an s390x kernel configuration, kpatch-build can fail to find matching symbols in the vmlinux symbol table. This was discovered in both Jammy 5.15 and Kinetic 5.19 kernels. >> * UBSAN was disabled in the Jammy 5.15 s390x kernel configuration to resolve the issue >> * Upstream kpatch recently resolved the issue via https://github.com/dynup/kpatch/pull/1332/commits/85344cf524cccc7b8e10bf04ed38a0f586bffd10, so this patch re-enables UBSAN for Jammy 5.15 s390x kernel configuration. > > Is that fix already uploaded to all relevant kpatch packages we have > in various places? I think that the new version is ready to go, though I'm not certain it's uploaded everywhere yet. Adding Ben for comment. John > >> >> [Fix] >> * Simple config change >> >> [Test Case] >> * Used kpatch-build v0.9.8 to build and load a fs/proc/meminfo.c Livepatch on s390x kernel successfully >> >> [Where problems could occur] >> * Should not introduce any regressions as functionality was enabled since original Jammy 5.15 kernel until v5.15.0-70.77 >> >> John Cabaj (1): >> UBUNTU: [Config] s390x: Re-adding UBSAN to configuration >> >> debian.master/config/annotations | 26 +++++++++++++------------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> -- >> 2.34.1 >> >> >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team > > >
On Thu, 2023-05-18 at 20:36 -0500, John Cabaj wrote: > On 5/18/23 7:02 PM, Dimitri John Ledkov wrote: > I think that the new version is ready to go, though I'm not certain > it's uploaded everywhere yet. Adding Ben for comment. The latest version is in Livepatch Tools Testing (0.9.8+22.04.1- production2) and has been tested using the current production livepatch for 5.15.0-71-generic, built on s390, and it works fine. I copied the updated kpatch-build to the appropriate builder (11.3.0- 1ubuntu1+22.04.1), repackaged and successfully built the livepatch for s390, and manually tested it against the 5.15.0-71-generic kernel. -- Ben
On 5/18/23 9:55 AM, John Cabaj wrote: > BugLink: https://bugs.launchpad.net/bugs/2003374 > > [Impact] > * When UBSAN is enabled in an s390x kernel configuration, kpatch-build can fail to find matching symbols in the vmlinux symbol table. This was discovered in both Jammy 5.15 and Kinetic 5.19 kernels. > * UBSAN was disabled in the Jammy 5.15 s390x kernel configuration to resolve the issue > * Upstream kpatch recently resolved the issue via https://github.com/dynup/kpatch/pull/1332/commits/85344cf524cccc7b8e10bf04ed38a0f586bffd10, so this patch re-enables UBSAN for Jammy 5.15 s390x kernel configuration. > > [Fix] > * Simple config change > > [Test Case] > * Used kpatch-build v0.9.8 to build and load a fs/proc/meminfo.c Livepatch on s390x kernel successfully > > [Where problems could occur] > * Should not introduce any regressions as functionality was enabled since original Jammy 5.15 kernel until v5.15.0-70.77 > > John Cabaj (1): > UBUNTU: [Config] s390x: Re-adding UBSAN to configuration > > debian.master/config/annotations | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
LGTM. Acked-by: Kamal Mostafa <kamal@canonical.com> -Kamal On Thu, May 18, 2023 at 10:55:45AM -0500, John Cabaj wrote: > BugLink: https://bugs.launchpad.net/bugs/2003374 > > [Impact] > * When UBSAN is enabled in an s390x kernel configuration, kpatch-build can fail to find matching symbols in the vmlinux symbol table. This was discovered in both Jammy 5.15 and Kinetic 5.19 kernels. > * UBSAN was disabled in the Jammy 5.15 s390x kernel configuration to resolve the issue > * Upstream kpatch recently resolved the issue via https://github.com/dynup/kpatch/pull/1332/commits/85344cf524cccc7b8e10bf04ed38a0f586bffd10, so this patch re-enables UBSAN for Jammy 5.15 s390x kernel configuration. > > [Fix] > * Simple config change > > [Test Case] > * Used kpatch-build v0.9.8 to build and load a fs/proc/meminfo.c Livepatch on s390x kernel successfully > > [Where problems could occur] > * Should not introduce any regressions as functionality was enabled since original Jammy 5.15 kernel until v5.15.0-70.77 > > John Cabaj (1): > UBUNTU: [Config] s390x: Re-adding UBSAN to configuration > > debian.master/config/annotations | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 18/05/2023 17:55, John Cabaj wrote: > BugLink: https://bugs.launchpad.net/bugs/2003374 > > [Impact] > * When UBSAN is enabled in an s390x kernel configuration, kpatch-build can fail to find matching symbols in the vmlinux symbol table. This was discovered in both Jammy 5.15 and Kinetic 5.19 kernels. > * UBSAN was disabled in the Jammy 5.15 s390x kernel configuration to resolve the issue > * Upstream kpatch recently resolved the issue via https://github.com/dynup/kpatch/pull/1332/commits/85344cf524cccc7b8e10bf04ed38a0f586bffd10, so this patch re-enables UBSAN for Jammy 5.15 s390x kernel configuration. > > [Fix] > * Simple config change > > [Test Case] > * Used kpatch-build v0.9.8 to build and load a fs/proc/meminfo.c Livepatch on s390x kernel successfully > > [Where problems could occur] > * Should not introduce any regressions as functionality was enabled since original Jammy 5.15 kernel until v5.15.0-70.77 > > John Cabaj (1): > UBUNTU: [Config] s390x: Re-adding UBSAN to configuration > > debian.master/config/annotations | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > Applied to jammy:master-next. Thanks! Roxana