| Message ID | 20230510225211.111113-1-hare@suse.de |
|---|---|
| Headers | show |
| Series | libata: remove references to 'old' error handler | expand |
On 5/11/23 07:52, Hannes Reinecke wrote: > Hi all, > > now that the ipr driver has been modified to not hook into libata > all drivers now use the 'new' error handler, so we can remove any > references to it. And do a general cleanup to remove callbacks > which are no longer needed. Hannes, Are you sending a v2 to address the comments ? > > Hannes Reinecke (6): > ata: remove reference to non-existing error_handler() > ata,scsi: remove ata_sas_port_{start,stop} callbacks > ata,scsi: remove ata_sas_port_destroy() > ata: remove ata_sas_sync_probe() > ata: inline ata_port_probe() > ata,scsi: cleanup ata_port_probe() > > drivers/ata/libata-core.c | 166 +++++++++++------------------ > drivers/ata/libata-eh.c | 148 +++++++++++-------------- > drivers/ata/libata-sata.c | 77 ------------- > drivers/ata/libata-scsi.c | 21 +--- > drivers/ata/libata-sff.c | 32 +++--- > drivers/ata/libata.h | 2 - > drivers/scsi/libsas/sas_ata.c | 6 +- > drivers/scsi/libsas/sas_discover.c | 2 +- > include/linux/libata.h | 6 +- > 9 files changed, 143 insertions(+), 317 deletions(-) >
On 5/22/23 02:46, Damien Le Moal wrote: > On 5/11/23 07:52, Hannes Reinecke wrote: >> Hi all, >> >> now that the ipr driver has been modified to not hook into libata >> all drivers now use the 'new' error handler, so we can remove any >> references to it. And do a general cleanup to remove callbacks >> which are no longer needed. > > Hannes, > > Are you sending a v2 to address the comments ? > Sure. Just catching up wfter yet another week of conference. Cheers, Hannes
On Mon, May 22, 2023 at 08:46:18AM +0200, Hannes Reinecke wrote: > On 5/22/23 02:46, Damien Le Moal wrote: > > On 5/11/23 07:52, Hannes Reinecke wrote: > > > Hi all, > > > > > > now that the ipr driver has been modified to not hook into libata > > > all drivers now use the 'new' error handler, so we can remove any > > > references to it. And do a general cleanup to remove callbacks > > > which are no longer needed. > > > > Hannes, > > > > Are you sending a v2 to address the comments ? > > > Sure. Just catching up wfter yet another week of conference. Hello Hannes, Are you planning on sending a V2? It would be nice for the series to cook in linux-next for the customary 2+ weeks before being sent to Linus, especially considering the kernel test robot regression report. I assume that the regression report is related to the review comment that I gave, i.e. that ata_dump_status() is now called unconditionally: %stddev %change %stddev pp.vprintk_emit._printk.ata_dump_status.ata_scsi_qc_complete.ata_qc_complete_multiple 0.00 +22.4 22.41 ± 8% perf-profile.calltrace.cycles- Kind regards, Niklas
On Mon, Jun 05, 2023 at 02:43:46PM +0000, Niklas Cassel wrote: (snip) > I assume that the regression report is related to the review comment > that I gave, i.e. that ata_dump_status() is now called unconditionally: > > %stddev %change %stddev > pp.vprintk_emit._printk.ata_dump_status.ata_scsi_qc_complete.ata_qc_complete_multiple > 0.00 +22.4 22.41 ± 8% perf-profile.calltrace.cycles- Perhaps unconditionally is not exactly the right word here, but since the regular case is that a QC does not have flag ATA_QCFLAG_QUIET set, you probably understood what I meant :) Kind regards, Niklas
On 6/5/23 16:43, Niklas Cassel wrote: > On Mon, May 22, 2023 at 08:46:18AM +0200, Hannes Reinecke wrote: >> On 5/22/23 02:46, Damien Le Moal wrote: >>> On 5/11/23 07:52, Hannes Reinecke wrote: >>>> Hi all, >>>> >>>> now that the ipr driver has been modified to not hook into libata >>>> all drivers now use the 'new' error handler, so we can remove any >>>> references to it. And do a general cleanup to remove callbacks >>>> which are no longer needed. >>> >>> Hannes, >>> >>> Are you sending a v2 to address the comments ? >>> >> Sure. Just catching up wfter yet another week of conference. > > Hello Hannes, > > Are you planning on sending a V2? > > It would be nice for the series to cook in linux-next for the customary > 2+ weeks before being sent to Linus, especially considering the kernel > test robot regression report. > > I assume that the regression report is related to the review comment > that I gave, i.e. that ata_dump_status() is now called unconditionally: > > %stddev %change %stddev > pp.vprintk_emit._printk.ata_dump_status.ata_scsi_qc_complete.ata_qc_complete_multiple > 0.00 +22.4 22.41 ± 8% perf-profile.calltrace.cycles- > > Ah, right. Yes, will be resending. Cheers, Hannes
Hi all, now that the ipr driver has been modified to not hook into libata all drivers now use the 'new' error handler, so we can remove any references to it. And do a general cleanup to remove callbacks which are no longer needed. Hannes Reinecke (6): ata: remove reference to non-existing error_handler() ata,scsi: remove ata_sas_port_{start,stop} callbacks ata,scsi: remove ata_sas_port_destroy() ata: remove ata_sas_sync_probe() ata: inline ata_port_probe() ata,scsi: cleanup ata_port_probe() drivers/ata/libata-core.c | 166 +++++++++++------------------ drivers/ata/libata-eh.c | 148 +++++++++++-------------- drivers/ata/libata-sata.c | 77 ------------- drivers/ata/libata-scsi.c | 21 +--- drivers/ata/libata-sff.c | 32 +++--- drivers/ata/libata.h | 2 - drivers/scsi/libsas/sas_ata.c | 6 +- drivers/scsi/libsas/sas_discover.c | 2 +- include/linux/libata.h | 6 +- 9 files changed, 143 insertions(+), 317 deletions(-)