| Message ID | 20230512212214.130908-1-CFSworks@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9bc6f1a4d08261032d60836ea1dd6f2e98889060 |
| Delegated to: | Andre Przywara |
| Headers | show |
| Series | sunxi: Fix typo in include guard | expand |
On Fri, 12 May 2023 15:22:14 -0600 Sam Edwards <cfsworks@gmail.com> wrote: Hi Sam, Good catch! It's not the first time we see misspelled preprocessor symbols, although that typically happens with Kconfig names. How did you find this? Just by accident? I was wondering if we could check the tree automatically for those accidents. > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h > index 3ccfe138f3..5ab9b2809f 100644 > --- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h > +++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h > @@ -6,7 +6,7 @@ > */ > > #ifndef _SUNXI_PMIC_BUS_H > -#define _SUNXI_PMIS_BUS_H > +#define _SUNXI_PMIC_BUS_H > > int pmic_bus_init(void); > int pmic_bus_read(u8 reg, u8 *data);
On 5/15/23 03:48, Andre Przywara wrote: Ahoy, Andre! > How did you find this? Just by accident? I was wondering if we could > check the tree automatically for those accidents. I found it both automatically and by accident. :) My cross-compiler of choice is Clang (as I don't have to rebuild/reinstall it for each target) and its enabled-by-default -Wheader-guard diagnostic flagged that for me. Regards, Sam
On Fri, 12 May 2023 15:22:14 -0600 Sam Edwards <cfsworks@gmail.com> wrote: > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Applied to sunxi/master. Thanks, Andre > --- > arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h > index 3ccfe138f3..5ab9b2809f 100644 > --- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h > +++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h > @@ -6,7 +6,7 @@ > */ > > #ifndef _SUNXI_PMIC_BUS_H > -#define _SUNXI_PMIS_BUS_H > +#define _SUNXI_PMIC_BUS_H > > int pmic_bus_init(void); > int pmic_bus_read(u8 reg, u8 *data);
diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h index 3ccfe138f3..5ab9b2809f 100644 --- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h +++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h @@ -6,7 +6,7 @@ */ #ifndef _SUNXI_PMIC_BUS_H -#define _SUNXI_PMIS_BUS_H +#define _SUNXI_PMIC_BUS_H int pmic_bus_init(void); int pmic_bus_read(u8 reg, u8 *data);
Signed-off-by: Sam Edwards <CFSworks@gmail.com> --- arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)