| Message ID | 20230512230135.133162-1-CFSworks@gmail.com |
|---|---|
| State | Handled Elsewhere, archived |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/3] makefile: Fix symbol typo in binary_size_check | expand |
On Fri, May 12, 2023 at 05:01:33PM -0600, Sam Edwards wrote: > The start-of-image marker symbol is `__image_copy_start`; by > searching for `_image_copy_start` instead, this check can > accidentally match `_image_copy_start_ofs`. > > Signed-off-by: Sam Edwards <CFSworks@gmail.com> Reviewed-by: Tom Rini <trini@konsulko.com>
diff --git a/Makefile b/Makefile index fb02bba08f..22bdc30109 100644 --- a/Makefile +++ b/Makefile @@ -1262,7 +1262,7 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \ binary_size_check: u-boot-nodtb.bin FORCE @file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \ map_size=$(shell cat u-boot.map | \ - awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \ + awk '/__image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \ | sed 's/0X//g' \ | bc); \ if [ "" != "$$map_size" ]; then \
The start-of-image marker symbol is `__image_copy_start`; by searching for `_image_copy_start` instead, this check can accidentally match `_image_copy_start_ofs`. Signed-off-by: Sam Edwards <CFSworks@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)