Message ID | 20081210165455.GC6391@linux.vnet.ibm.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
Hi, Le mercredi 10 décembre 2008 à 22:24 +0530, Kamalesh Babulal a écrit : > * Randy Dunlap <randy.dunlap@oracle.com> [2008-12-01 11:59:34]: > > the function nfulnl_log_packet is exported only if > CONFIG_NETFILTER_NETLINK_LOG is enabled, so marking the loging function > between ifdef. > My patch introduces a real depedency of xt_NFLOG with nfnetlink_log (CONFIG_NETFILTER_NETLINK_LOG) but I forget to state it in Kconfig. I thus disagree with your patch. It is better to fix the compilation depedency instead by modifying Kconfig. A patch fixing this issue is to come. BR,
diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c index a57c5cf..fa814a6 100644 --- a/net/netfilter/xt_NFLOG.c +++ b/net/netfilter/xt_NFLOG.c @@ -32,8 +32,11 @@ nflog_tg(struct sk_buff *skb, const struct xt_target_param *par) li.u.ulog.group = info->group; li.u.ulog.qthreshold = info->threshold; +#ifdef CONFIG_NETFILTER_NETLINK_LOG nfulnl_log_packet(par->family, par->hooknum, skb, par->in, par->out, &li, info->prefix); +#endif /* CONFIG_NETFILTER_NETLINK_LOG */ + return XT_CONTINUE; }