Message ID | 20230321141028.24456-9-hnagalla@ti.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | Introduce initial TI's J784S4 support | expand |
On 21/03/23 19:40, Hari Nagalla wrote: > Add support for J784S4 SoC Identification. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > drivers/soc/soc_ti_k3.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c > index 8af0ac7051..caf8db9574 100644 > --- a/drivers/soc/soc_ti_k3.c > +++ b/drivers/soc/soc_ti_k3.c > @@ -17,6 +17,7 @@ > #define J721S2 0xbb75 > #define AM62X 0xbb7e > #define AM62AX 0xbb8d > +#define J784S4 0xbb80 > > #define JTAG_ID_VARIANT_SHIFT 28 > #define JTAG_ID_VARIANT_MASK (0xf << 28) > @@ -54,9 +55,14 @@ static const char *get_family_string(u32 idreg) > case AM62X: > family = "AM62X"; > break; > + > case AM62AX: > family = "AM62AX"; > + You are missing a break here. This will render AM62Ax unbootable as we end up returning family as J784S4 > + case J784S4: > + family = "J784S4"; > break; > + > default: > family = "Unknown Silicon"; > };
diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c index 8af0ac7051..caf8db9574 100644 --- a/drivers/soc/soc_ti_k3.c +++ b/drivers/soc/soc_ti_k3.c @@ -17,6 +17,7 @@ #define J721S2 0xbb75 #define AM62X 0xbb7e #define AM62AX 0xbb8d +#define J784S4 0xbb80 #define JTAG_ID_VARIANT_SHIFT 28 #define JTAG_ID_VARIANT_MASK (0xf << 28) @@ -54,9 +55,14 @@ static const char *get_family_string(u32 idreg) case AM62X: family = "AM62X"; break; + case AM62AX: family = "AM62AX"; + + case J784S4: + family = "J784S4"; break; + default: family = "Unknown Silicon"; };
Add support for J784S4 SoC Identification. Signed-off-by: Hari Nagalla <hnagalla@ti.com> --- drivers/soc/soc_ti_k3.c | 6 ++++++ 1 file changed, 6 insertions(+)