Message ID | rzvlvgl567swjx6trflkalqyfewvnd64ddcpmmrm77re6q73ar@6ohth6ey5ito |
---|---|
State | New |
Headers | show |
Series | [v2] testsuite: stdlib/isomac.c: fix REQUIREMENTS | expand |
On 5/4/23 16:25, наб via Libc-alpha wrote: > All of the mentioned variables are gone. gcc is just the default and > argv[1] can be used instead. /usr/include isn't hard-coded and you can > pass argv[2] with -I... to adjust. LGTM. Thank you! Pushed. Reviewed-by: Carlos O'Donell <carlos@redhat.com> > > Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> > --- > v2: no-change resend after clean rebase > > stdlib/isomac.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/stdlib/isomac.c b/stdlib/isomac.c > index 3a6009d988..a371bb2593 100644 > --- a/stdlib/isomac.c > +++ b/stdlib/isomac.c > @@ -45,14 +45,11 @@ > compiler compiles some other language than Standard C. > > REQUIREMENTS: > - This program calls gcc to get the list of defined macros. If you > + This program calls ${1-gcc} to get the list of defined macros. If you OK. > don't have gcc you're probably out of luck unless your compiler or > - preprocessor has something similar to gcc's -dM option. Tune > - PRINT_MACROS in this case. This program assumes headers are found > - under /usr/include and that there is a writable /tmp directory. > - Tune SYSTEM_INCLUDE if your system differs. > - #define BROKEN_SYSTEM if system(NULL) bombs -- one more violation > - of ISO C, by the way. > + preprocessor has something similar to gcc's -dM option. This program > + assumes headers are found in the default search path (pass -I... in > + $2 if this is not the case) and that there is a writable /tmp directory. OK. > > OUTPUT: > Each header file name is printed, followed by illegal macro names
diff --git a/stdlib/isomac.c b/stdlib/isomac.c index 3a6009d988..a371bb2593 100644 --- a/stdlib/isomac.c +++ b/stdlib/isomac.c @@ -45,14 +45,11 @@ compiler compiles some other language than Standard C. REQUIREMENTS: - This program calls gcc to get the list of defined macros. If you + This program calls ${1-gcc} to get the list of defined macros. If you don't have gcc you're probably out of luck unless your compiler or - preprocessor has something similar to gcc's -dM option. Tune - PRINT_MACROS in this case. This program assumes headers are found - under /usr/include and that there is a writable /tmp directory. - Tune SYSTEM_INCLUDE if your system differs. - #define BROKEN_SYSTEM if system(NULL) bombs -- one more violation - of ISO C, by the way. + preprocessor has something similar to gcc's -dM option. This program + assumes headers are found in the default search path (pass -I... in + $2 if this is not the case) and that there is a writable /tmp directory. OUTPUT: Each header file name is printed, followed by illegal macro names
All of the mentioned variables are gone. gcc is just the default and argv[1] can be used instead. /usr/include isn't hard-coded and you can pass argv[2] with -I... to adjust. Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> --- v2: no-change resend after clean rebase stdlib/isomac.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)