| Message ID | 20230428141758.2733456-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 46240314ac483b93aef081d828b9e86fa9754feb |
| Headers | show |
| Series | [ovs-dev] ovsdb-idl.at: Fix write-changed-only tests without change tracking. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/intel-ovs-compilation | success | test: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 4/28/23 16:17, Ilya Maximets wrote: > The '-w' command line argument is not passed to test-ovsdb in the > OVSDB_CHECK_IDL_WRITE_CHANGED_ONLY_C, so it juts repeats normal > tests without testing the feature. > > Adding the flag. And using the long version of the flag to make > things more obvious and harder to overlook. Swapping the argument > in the other working test as well, just for consistency. > > Fixes: d94cd0d3eec3 ("ovsdb-idl: Support write-only-changed IDL monitor mode.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- Oops, sorry about this, thanks for fixing it! Acked-by: Dumitru Ceara <dceara@redhat.com>
On 5/2/23 17:27, Dumitru Ceara wrote: > On 4/28/23 16:17, Ilya Maximets wrote: >> The '-w' command line argument is not passed to test-ovsdb in the >> OVSDB_CHECK_IDL_WRITE_CHANGED_ONLY_C, so it juts repeats normal >> tests without testing the feature. >> >> Adding the flag. And using the long version of the flag to make >> things more obvious and harder to overlook. Swapping the argument >> in the other working test as well, just for consistency. >> >> Fixes: d94cd0d3eec3 ("ovsdb-idl: Support write-only-changed IDL monitor mode.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- > > Oops, sorry about this, thanks for fixing it! > > Acked-by: Dumitru Ceara <dceara@redhat.com> > Thanks! Applied and backported down to 3.0. Best regards, Ilya Maximets.
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index 5a7e76eaa..9d28672ef 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -94,7 +94,7 @@ m4_define([OVSDB_CHECK_IDL_WRITE_CHANGED_ONLY_C], AT_CHECK([ovsdb_start_idltest]) m4_if([$2], [], [], [AT_CHECK([ovsdb-client transact unix:socket $2], [0], [ignore], [ignore])]) - AT_CHECK([test-ovsdb '-vPATTERN:console:test-ovsdb|%c|%m' -vjsonrpc -t10 idl unix:socket $3], + AT_CHECK([test-ovsdb '-vPATTERN:console:test-ovsdb|%c|%m' -vjsonrpc -t10 --write-changed-only idl unix:socket $3], [0], [stdout], [ignore]) AT_CHECK([sort stdout | uuidfilt]m4_if([$6],,, [[| $6]]), [0], [$4]) @@ -1216,7 +1216,7 @@ m4_define([OVSDB_CHECK_IDL_TRACK_WRITE_CHANGED_ONLY_C], AT_CHECK([ovsdb_start_idltest]) m4_if([$2], [], [], [AT_CHECK([ovsdb-client transact unix:socket $2], [0], [ignore], [ignore])]) - AT_CHECK([test-ovsdb '-vPATTERN:console:test-ovsdb|%c|%m' -vjsonrpc -t10 -c -w idl unix:socket $3], + AT_CHECK([test-ovsdb '-vPATTERN:console:test-ovsdb|%c|%m' -vjsonrpc -t10 -c --write-changed-only idl unix:socket $3], [0], [stdout], [ignore]) AT_CHECK([sort stdout | uuidfilt]m4_if([$6],,, [[| $6]]), [0], [$4])
The '-w' command line argument is not passed to test-ovsdb in the OVSDB_CHECK_IDL_WRITE_CHANGED_ONLY_C, so it juts repeats normal tests without testing the feature. Adding the flag. And using the long version of the flag to make things more obvious and harder to overlook. Swapping the argument in the other working test as well, just for consistency. Fixes: d94cd0d3eec3 ("ovsdb-idl: Support write-only-changed IDL monitor mode.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- tests/ovsdb-idl.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)