| Message ID | 20230420164836.291643-1-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: decrease risk of flaky failures of ovn -- CoPP system test | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Thu, Apr 20, 2023 at 6:49 PM Xavier Simonart <xsimonar@redhat.com> wrote: > The test was often failing with a meter of 10 pps while generating 100 > packets. > When the 100 packets generation takes more than 100 msec, the test fails. > This happens from time to time in upstream ci. > Reducing the number of generated packets to 40 should reduce number of > flakes. > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/system-ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index b46f67636..3ede60f0a 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -7190,7 +7190,7 @@ NS_EXEC([sw01], [tcpdump -l -n -i sw01 icmp -Q in > > reject.pcap &]) > check ovn-nbctl --may-exist meter-add acl-meter drop 10 pktps 0 > ip netns exec sw01 scapy -H <<-EOF > p = IP(src="192.168.1.2", dst="192.168.1.1") / UDP(dport = 12345) / > Raw(b"X"*64) > -send (p, iface='sw01', loop = 0, verbose = 0, count = 100) > +send (p, iface='sw01', loop = 0, verbose = 0, count = 40) > EOF > > # 10pps > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
Thanks Xavier and Ales. I applied this change to main and all branches back to 22.03. On 4/21/23 04:07, Ales Musil wrote: > On Thu, Apr 20, 2023 at 6:49 PM Xavier Simonart <xsimonar@redhat.com> wrote: > >> The test was often failing with a meter of 10 pps while generating 100 >> packets. >> When the 100 packets generation takes more than 100 msec, the test fails. >> This happens from time to time in upstream ci. >> Reducing the number of generated packets to 40 should reduce number of >> flakes. >> >> Signed-off-by: Xavier Simonart <xsimonar@redhat.com> >> --- >> tests/system-ovn.at | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/system-ovn.at b/tests/system-ovn.at >> index b46f67636..3ede60f0a 100644 >> --- a/tests/system-ovn.at >> +++ b/tests/system-ovn.at >> @@ -7190,7 +7190,7 @@ NS_EXEC([sw01], [tcpdump -l -n -i sw01 icmp -Q in > >> reject.pcap &]) >> check ovn-nbctl --may-exist meter-add acl-meter drop 10 pktps 0 >> ip netns exec sw01 scapy -H <<-EOF >> p = IP(src="192.168.1.2", dst="192.168.1.1") / UDP(dport = 12345) / >> Raw(b"X"*64) >> -send (p, iface='sw01', loop = 0, verbose = 0, count = 100) >> +send (p, iface='sw01', loop = 0, verbose = 0, count = 40) >> EOF >> >> # 10pps >> -- >> 2.31.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> >
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index b46f67636..3ede60f0a 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -7190,7 +7190,7 @@ NS_EXEC([sw01], [tcpdump -l -n -i sw01 icmp -Q in > reject.pcap &]) check ovn-nbctl --may-exist meter-add acl-meter drop 10 pktps 0 ip netns exec sw01 scapy -H <<-EOF p = IP(src="192.168.1.2", dst="192.168.1.1") / UDP(dport = 12345) / Raw(b"X"*64) -send (p, iface='sw01', loop = 0, verbose = 0, count = 100) +send (p, iface='sw01', loop = 0, verbose = 0, count = 40) EOF # 10pps
The test was often failing with a meter of 10 pps while generating 100 packets. When the 100 packets generation takes more than 100 msec, the test fails. This happens from time to time in upstream ci. Reducing the number of generated packets to 40 should reduce number of flakes. Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/system-ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)