| Message ID | 20230418095344.274025-2-cristian.ciocaltea@collabora.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Enable rk3588 timer support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Am Dienstag, 18. April 2023, 11:53:42 CEST schrieb Cristian Ciocaltea: > The compatible string for Rockchip RK3288 is provided in both the 'enum' > and the subsequent 'const' item. Drop the unnecessary entry from the > enum. And the actual rk3288-timer case is handled in the separate - const: rockchip,rk3288-timer at the top of the list too. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On 4/18/23 13:26, Heiko Stübner wrote: > Am Dienstag, 18. April 2023, 11:53:42 CEST schrieb Cristian Ciocaltea: >> The compatible string for Rockchip RK3288 is provided in both the 'enum' >> and the subsequent 'const' item. Drop the unnecessary entry from the >> enum. > > And the actual rk3288-timer case is handled in the separate > - const: rockchip,rk3288-timer > at the top of the list too. Right, in total there were 3 occurrences of this compatible string. >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Thanks for the quick review! Regards, Cristian
diff --git a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml index 65e59836a660..2bdb6e6bdb21 100644 --- a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml +++ b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml @@ -23,7 +23,6 @@ properties: - rockchip,rk3188-timer - rockchip,rk3228-timer - rockchip,rk3229-timer - - rockchip,rk3288-timer - rockchip,rk3368-timer - rockchip,px30-timer - const: rockchip,rk3288-timer
The compatible string for Rockchip RK3288 is provided in both the 'enum' and the subsequent 'const' item. Drop the unnecessary entry from the enum. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 - 1 file changed, 1 deletion(-)