diff mbox series

[v3,2/2] soc: nuvoton: Add "select REGMAP" to WPCM450 SoC driver

Message ID 20230412183834.3769519-2-j.neuschaefer@gmx.net
State New
Headers show
Series [v3,1/2] soc: nuvoton: Add a menu for Nuvoton SoC drivers | expand

Commit Message

J. Neuschäfer April 12, 2023, 6:38 p.m. UTC
Select CONFIG_REGMAP from CONFIG_WPCM450_SOC, because the driver relies
on regmap to work.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v3:
- Split the commit into two
- Reword the commit messages a bit

v2:
- https://lore.kernel.org/lkml/20230212215234.2608565-1-j.neuschaefer@gmx.net/
- Commit message improvements, as suggested by Geert Uytterhoeven.
- Add Link after Reviewed-by, as checkpatch.pl now suggests
---
 drivers/soc/nuvoton/Kconfig | 1 +
 1 file changed, 1 insertion(+)

--
2.39.2

Comments

Geert Uytterhoeven April 17, 2023, 7:26 a.m. UTC | #1
On Wed, Apr 12, 2023 at 8:38 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Select CONFIG_REGMAP from CONFIG_WPCM450_SOC, because the driver relies
> on regmap to work.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
> Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> v3:
> - Split the commit into two
> - Reword the commit messages a bit

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven April 17, 2023, 7:29 a.m. UTC | #2
On Mon, Apr 17, 2023 at 9:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Apr 12, 2023 at 8:38 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> > Select CONFIG_REGMAP from CONFIG_WPCM450_SOC, because the driver relies
> > on regmap to work.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
> > Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")

This reference is wrong, it should be 7dbb4a38bff3.

> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
index 853392c8a9151..2167d3d739d84 100644
--- a/drivers/soc/nuvoton/Kconfig
+++ b/drivers/soc/nuvoton/Kconfig
@@ -6,6 +6,7 @@  config WPCM450_SOC
 	tristate "Nuvoton WPCM450 SoC driver"
 	default y if ARCH_WPCM450
 	select SOC_BUS
+	select REGMAP
 	help
 	  Say Y here to compile the SoC information driver for Nuvoton
 	  WPCM450 SoCs.