| Message ID | 20230412183834.3769519-1-j.neuschaefer@gmx.net |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] soc: nuvoton: Add a menu for Nuvoton SoC drivers | expand |
On Wed, Apr 12, 2023 at 8:38 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton > SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC > driver when configuring a kernel without support for Nuvoton SoCs. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/ > Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450") > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > v3: > - Split the commit into two > - Reword the commit messages a bit Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Mon, Apr 17, 2023 at 9:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, Apr 12, 2023 at 8:38 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton > > SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC > > driver when configuring a kernel without support for Nuvoton SoCs. > > > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/ > > Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450") This reference is wrong, it should be 7dbb4a38bff3. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Gr{oetje,eeting}s, Geert
On Mon, Apr 17, 2023 at 09:28:47AM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 17, 2023 at 9:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Apr 12, 2023 at 8:38 PM Jonathan Neuschäfer > > <j.neuschaefer@gmx.net> wrote: > > > Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton > > > SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC > > > driver when configuring a kernel without support for Nuvoton SoCs. > > > > > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/ > > > Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450") > > This reference is wrong, it should be 7dbb4a38bff3. Good catch, I picked a local copy of the patch/commit by accident. Thanks, Jonathan
diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig index df46182088ec2..853392c8a9151 100644 --- a/drivers/soc/nuvoton/Kconfig +++ b/drivers/soc/nuvoton/Kconfig @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 -menuconfig WPCM450_SOC +menu "Nuvoton SoC drivers" + depends on ARCH_NPCM || COMPILE_TEST + +config WPCM450_SOC tristate "Nuvoton WPCM450 SoC driver" default y if ARCH_WPCM450 select SOC_BUS @@ -9,3 +12,5 @@ menuconfig WPCM450_SOC This driver provides information such as the SoC model and revision. + +endmenu
Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC driver when configuring a kernel without support for Nuvoton SoCs. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/ Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450") Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- v3: - Split the commit into two - Reword the commit messages a bit v2: - https://lore.kernel.org/lkml/20230212215234.2608565-1-j.neuschaefer@gmx.net/ - Commit message improvements, as suggested by Geert Uytterhoeven. - Add Link after Reviewed-by, as checkpatch.pl now suggests --- drivers/soc/nuvoton/Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.39.2