| Message ID | cover.1680646955.git.limings@nvidia.com |
|---|---|
| Headers | show |
| Series | UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for BlueField-3 | expand |
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> Using module parameters interface instead of custom sysfs entries for passing information to user-space looks a bit strange to me but it doesn't seem to cause problems. Also please use the shortened URL for BugLink (in case of this submission it should be https://bugs.launchpad.net/bugs/2015307) next time (I can correct this while applying the patch so there is no need to resubmit it). -- Best regards, Bartlomiej On Wed, Apr 5, 2023 at 1:31 AM Liming Sun <limings@nvidia.com> wrote: > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2015307 > > SRU Justification: > > [Impact] > This change is needed to avoid unnecessary eMMC GPIO toggling when eMMC is idle > > [Fix] > The fix implements the runtime PM operations for BlueField-3 SoC to disable the card clock when idle. > > [Test Case] > Same functionality and testing as on BlueField-1/2. > > [Regression Potential] > Same behavior from user perspective. > > Liming Sun (1): > UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for > BlueField-3 > > drivers/mmc/host/sdhci-of-dwcmshc.c | 103 +++++++++++++++++++++++++++- > 1 file changed, 102 insertions(+), 1 deletion(-) >
On 23/04/04 07:29PM, Liming Sun wrote: > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2015307 > > SRU Justification: > > [Impact] > This change is needed to avoid unnecessary eMMC GPIO toggling when eMMC is idle > > [Fix] > The fix implements the runtime PM operations for BlueField-3 SoC to disable the card clock when idle. > > [Test Case] > Same functionality and testing as on BlueField-1/2. > > [Regression Potential] > Same behavior from user perspective. > > Liming Sun (1): > UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for > BlueField-3 > > drivers/mmc/host/sdhci-of-dwcmshc.c | 103 +++++++++++++++++++++++++++- > 1 file changed, 102 insertions(+), 1 deletion(-) > > -- > 2.30.1 Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Thanks, Bartlomiej! Best regards, Liming > -----Original Message----- > From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> > Sent: Wednesday, April 5, 2023 7:33 AM > To: Liming Sun <limings@nvidia.com> > Cc: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com> > Subject: ACK/Cmnt: [PATCH v1 0/1] [SRU][J:linux-bluefield][PATCH v1 1/1] > UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for > BlueField-3 > > Acked-by: Bartlomiej Zolnierkiewicz > <bartlomiej.zolnierkiewicz@canonical.com> > > Using module parameters interface instead of custom sysfs entries for > passing information to user-space looks a bit strange to me but it > doesn't seem to cause problems. > > Also please use the shortened URL for BugLink (in case of this > submission it should be > https://bugs.la/ > unchpad.net%2Fbugs%2F2015307&data=05%7C01%7Climings%40nvidia.com% > 7Cec62dca0c0794d3cf4c208db35c9973c%7C43083d15727340c1b7db39efd9ccc > 17a%7C0%7C0%7C638162912165501217%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7C&sdata=Q2k%2FkcEPnW%2B%2BSLVHbD8ws1U8vS%2Byb0M > qOUOa6iaLi6o%3D&reserved=0) next > time (I can correct this while applying the patch so there is no need > to resubmit it). > > -- > Best regards, > Bartlomiej > > On Wed, Apr 5, 2023 at 1:31 AM Liming Sun <limings@nvidia.com> wrote: > > > > BugLink: > https://bugs.la/ > unchpad.net%2Fubuntu%2F%2Bsource%2Flinux- > bluefield%2F%2Bbug%2F2015307&data=05%7C01%7Climings%40nvidia.com% > 7Cec62dca0c0794d3cf4c208db35c9973c%7C43083d15727340c1b7db39efd9ccc > 17a%7C0%7C0%7C638162912165501217%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7C&sdata=y1KYmYbbQju6GMCAa8rxZgDuHY26SJxQaQWYnh81k > lQ%3D&reserved=0 > > > > SRU Justification: > > > > [Impact] > > This change is needed to avoid unnecessary eMMC GPIO toggling when > eMMC is idle > > > > [Fix] > > The fix implements the runtime PM operations for BlueField-3 SoC to disable > the card clock when idle. > > > > [Test Case] > > Same functionality and testing as on BlueField-1/2. > > > > [Regression Potential] > > Same behavior from user perspective. > > > > Liming Sun (1): > > UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for > > BlueField-3 > > > > drivers/mmc/host/sdhci-of-dwcmshc.c | 103 > +++++++++++++++++++++++++++- > > 1 file changed, 102 insertions(+), 1 deletion(-) > >
Applied to jammy:linux-bluefield/master-next. Thanks. -- Best regards, Bartlomiej On Wed, Apr 5, 2023 at 1:31 AM Liming Sun <limings@nvidia.com> wrote: > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2015307 > > SRU Justification: > > [Impact] > This change is needed to avoid unnecessary eMMC GPIO toggling when eMMC is idle > > [Fix] > The fix implements the runtime PM operations for BlueField-3 SoC to disable the card clock when idle. > > [Test Case] > Same functionality and testing as on BlueField-1/2. > > [Regression Potential] > Same behavior from user perspective. > > Liming Sun (1): > UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for > BlueField-3 > > drivers/mmc/host/sdhci-of-dwcmshc.c | 103 +++++++++++++++++++++++++++- > 1 file changed, 102 insertions(+), 1 deletion(-) >
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2015307 SRU Justification: [Impact] This change is needed to avoid unnecessary eMMC GPIO toggling when eMMC is idle [Fix] The fix implements the runtime PM operations for BlueField-3 SoC to disable the card clock when idle. [Test Case] Same functionality and testing as on BlueField-1/2. [Regression Potential] Same behavior from user perspective. Liming Sun (1): UBUNTU: SAUCE: mmc: sdhci-of-dwcmshc: Add runtime PM operations for BlueField-3 drivers/mmc/host/sdhci-of-dwcmshc.c | 103 +++++++++++++++++++++++++++- 1 file changed, 102 insertions(+), 1 deletion(-)