| Message ID | 20230331095715.5988-1-stefan.wahren@chargebyte.com |
|---|---|
| Headers | show |
| Series | ARM: dts: imx6ull: Add chargebyte Tarragon support | expand |
On 31/03/2023 11:57, Stefan Wahren wrote: > This adds the compatibles for the chargebyte Tarragon boards. > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> > --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Mar 31, 2023 at 4:58 AM Stefan Wahren <stefan.wahren@chargebyte.com> wrote: > > Both chips are I2C to 1-wire bridges. > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 6f482a254a1d..9b7b24989359 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -183,6 +183,10 @@ properties: > - maxim,ds1803-050 > # 100 kOhm digital potentiometer with I2C interface > - maxim,ds1803-100 > + # I2C to 1-wire bridge > + - maxim,ds2482 > + # I2C to 1-wire bridge > + - maxim,ds2484 A 1-wire device isn't really trivial because it can have child nodes. You're probably not the first here, but don't add more. You could do a "trivial 1-wire devices" schema similar to trivial RTC device schema. Rob
Hi Rob, Am 31.03.23 um 17:49 schrieb Rob Herring: > On Fri, Mar 31, 2023 at 4:58 AM Stefan Wahren > <stefan.wahren@chargebyte.com> wrote: >> >> Both chips are I2C to 1-wire bridges. >> >> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> >> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 6f482a254a1d..9b7b24989359 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -183,6 +183,10 @@ properties: >> - maxim,ds1803-050 >> # 100 kOhm digital potentiometer with I2C interface >> - maxim,ds1803-100 >> + # I2C to 1-wire bridge >> + - maxim,ds2482 >> + # I2C to 1-wire bridge >> + - maxim,ds2484 > > A 1-wire device isn't really trivial because it can have child nodes. > You're probably not the first here, but don't add more. > > You could do a "trivial 1-wire devices" schema similar to trivial RTC > device schema. okay. After thinking more about this, it isn't a trivial device at all. I will make a dedicated schema for this. Best regards > > Rob