| Message ID | 20230324173056.2652725-1-trix@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ksmbd: remove unused is_char_allowed function | expand |
On (23/03/24 13:30), Tom Rix wrote: > > clang with W=1 reports > fs/ksmbd/unicode.c:122:19: error: unused function > 'is_char_allowed' [-Werror,-Wunused-function] > static inline int is_char_allowed(char *ch) > ^ > This function is not used so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> We have a copy of that function in fs/ksmbd/misc.c.
2023-03-25 2:30 GMT+09:00, Tom Rix <trix@redhat.com>: > clang with W=1 reports > fs/ksmbd/unicode.c:122:19: error: unused function > 'is_char_allowed' [-Werror,-Wunused-function] > static inline int is_char_allowed(char *ch) > ^ > This function is not used so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Thanks!
diff --git a/fs/ksmbd/unicode.c b/fs/ksmbd/unicode.c index a0db699ddafd..9ae676906ed3 100644 --- a/fs/ksmbd/unicode.c +++ b/fs/ksmbd/unicode.c @@ -113,24 +113,6 @@ cifs_mapchar(char *target, const __u16 src_char, const struct nls_table *cp, goto out; } -/* - * is_char_allowed() - check for valid character - * @ch: input character to be checked - * - * Return: 1 if char is allowed, otherwise 0 - */ -static inline int is_char_allowed(char *ch) -{ - /* check for control chars, wildcards etc. */ - if (!(*ch & 0x80) && - (*ch <= 0x1f || - *ch == '?' || *ch == '"' || *ch == '<' || - *ch == '>' || *ch == '|')) - return 0; - - return 1; -} - /* * smb_from_utf16() - convert utf16le string to local charset * @to: destination buffer
clang with W=1 reports fs/ksmbd/unicode.c:122:19: error: unused function 'is_char_allowed' [-Werror,-Wunused-function] static inline int is_char_allowed(char *ch) ^ This function is not used so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- fs/ksmbd/unicode.c | 18 ------------------ 1 file changed, 18 deletions(-)