| Message ID | 20230318235031.3793301-1-odivlad@gmail.com |
|---|---|
| Headers | show |
| Series | Inactivity probe configuration for ic, controller-vtep | expand |
On Sat, Mar 18, 2023 at 7:50 PM Vladislav Odintsov <odivlad@gmail.com> wrote: > > This patch series adds support to configure inactivity probe for ovn-ic > and ovn-controller-vtep. > In first commit is just a preparation for adding support: the duplicated > logic from ovn-controller and ovn-northd is moved to lib/ovn-util. > > Additionally methods to monitor OVSDB connection status were added to > ovn-ic and ovn-controller-vtep. > > Vladislav Odintsov (6): > controller,northd: move inactivity probe configuration to lib/ > ic: add support to configure ovsdb inactivity probe > controller-vtep: add support to configure inactivity probe interval > controller-vtep: add unixctl commands to show DB connection status > ovn-ic: add unixctl commands to report db connection status > NEWS: add info about ic/controller-vtep inactivity probe support Thanks for adding this feature. I applied the series to the main branch. Note that I've not reviewed this patch - http://patchwork.ozlabs.org/project/ovn/patch/20230319005427.3796325-1-odivlad@gmail.com/ Can you please submit separately. CI has not run for this patch maybe due to the patch number 7/6. Numan > > NEWS | 2 ++ > controller-vtep/ovn-controller-vtep.8.xml | 14 +++++++++ > controller-vtep/ovn-controller-vtep.c | 22 ++++++++++++++ > controller/ovn-controller.c | 8 ++--- > ic/ovn-ic.c | 37 +++++++++++++++++++++++ > lib/ovn-util.c | 22 ++++++++++++++ > lib/ovn-util.h | 4 +++ > northd/ovn-northd.c | 30 +++--------------- > ovn-ic-nb.xml | 14 +++++++++ > ovn-nb.xml | 13 ++++++++ > 10 files changed, 135 insertions(+), 31 deletions(-) > > -- > 2.36.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Hi Numan, thanks for the review and patches applying. I’ve re-submitted the last patch here: https://patchwork.ozlabs.org/project/ovn/patch/20230323192520.3903330-1-odivlad@gmail.com/ > On 23 Mar 2023, at 22:15, Numan Siddique <numans@ovn.org> wrote: > > On Sat, Mar 18, 2023 at 7:50 PM Vladislav Odintsov <odivlad@gmail.com <mailto:odivlad@gmail.com>> wrote: >> >> This patch series adds support to configure inactivity probe for ovn-ic >> and ovn-controller-vtep. >> In first commit is just a preparation for adding support: the duplicated >> logic from ovn-controller and ovn-northd is moved to lib/ovn-util. >> >> Additionally methods to monitor OVSDB connection status were added to >> ovn-ic and ovn-controller-vtep. >> >> Vladislav Odintsov (6): >> controller,northd: move inactivity probe configuration to lib/ >> ic: add support to configure ovsdb inactivity probe >> controller-vtep: add support to configure inactivity probe interval >> controller-vtep: add unixctl commands to show DB connection status >> ovn-ic: add unixctl commands to report db connection status >> NEWS: add info about ic/controller-vtep inactivity probe support > > Thanks for adding this feature. > > I applied the series to the main branch. Note that I've not reviewed > this patch - http://patchwork.ozlabs.org/project/ovn/patch/20230319005427.3796325-1-odivlad@gmail.com/ > > Can you please submit separately. CI has not run for this patch maybe > due to the patch number 7/6. > > Numan > >> >> NEWS | 2 ++ >> controller-vtep/ovn-controller-vtep.8.xml | 14 +++++++++ >> controller-vtep/ovn-controller-vtep.c | 22 ++++++++++++++ >> controller/ovn-controller.c | 8 ++--- >> ic/ovn-ic.c | 37 +++++++++++++++++++++++ >> lib/ovn-util.c | 22 ++++++++++++++ >> lib/ovn-util.h | 4 +++ >> northd/ovn-northd.c | 30 +++--------------- >> ovn-ic-nb.xml | 14 +++++++++ >> ovn-nb.xml | 13 ++++++++ >> 10 files changed, 135 insertions(+), 31 deletions(-) >> >> -- >> 2.36.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org <mailto:dev@openvswitch.org> >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > _______________________________________________ > dev mailing list > dev@openvswitch.org <mailto:dev@openvswitch.org> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Regards, Vladislav Odintsov