Message ID | 20230224133129.887203-4-eblanc@baylibre.com |
---|---|
State | New |
Headers | show |
Series | TI TPS6594 PMIC support (RTC, pinctrl, regulators, device trees) | expand |
On Fri, Feb 24, 2023 at 02:31:29PM +0100, Esteban Blanc wrote: > From: Jerome Neanne <jneanne@baylibre.com> > > This patch adds support for TPS6594 regulators (bucks and LDOs). > The output voltages are configurable and are meant to supply power > to the main processor and other components. > Bucks can be used in single or multiphase mode, depending on PMIC > part number. > > Signed-off-by: Jerome Neanne <jneanne@baylibre.com> > --- You've not provided a Signed-off-by for this so I can't do anything with it, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important. > @@ -0,0 +1,559 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Regulator driver for tps6594 PMIC > + * > + * Copyright (C) 2022 BayLibre Incorporated - https://www.baylibre.com/ Please make the entire comment block a C++ one so things look more intentional. > +static unsigned int tps6594_get_mode(struct regulator_dev *dev) > +{ > + return REGULATOR_MODE_NORMAL; > +} If configuring modes isn't supported just omit all mode operations. > + } > + > + regulator_notifier_call_chain(irq_data->rdev, > + irq_data->type->event, NULL); > + > + dev_err(irq_data->dev, "Error IRQ trap %s for %s\n", > + irq_data->type->event_name, irq_data->type->regulator_name); I suspect it might avoid future confusion to log the error before notifying so that any consequences of the error more clearly happen in response to the error. > +static int tps6594_get_rdev_by_name(const char *regulator_name, > + struct regulator_dev *rdevbucktbl[BUCK_NB], > + struct regulator_dev *rdevldotbl[LDO_NB], > + struct regulator_dev *dev) > +{ > + int i; > + > + for (i = 0; i <= BUCK_NB; i++) { > + if (strcmp(regulator_name, buck_regs[i].name) == 0) { > + dev = rdevbucktbl[i]; > + return 0; > + } > + } > + > + for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { > + if (strcmp(regulator_name, ldo_regs[i].name) == 0) { > + dev = rdevldotbl[i]; > + return 0; > + } > + } > + return -EINVAL; > +} > + for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { > + irq_type = &tps6594_regulator_irq_types[i]; > + > + irq = platform_get_irq_byname(pdev, irq_type->irq_name); > + if (irq < 0) > + return -EINVAL; > + > + irq_data[i].dev = tps->dev; > + irq_data[i].type = irq_type; > + > + tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, > + rdevldotbl, rdev); This would be simpler and you wouldn't need this lookup function if the regulator descriptions included their IRQ names, then you could just request the interrupts while registering the regulators. > + error = devm_request_threaded_irq(tps->dev, irq, NULL, > + tps6594_regulator_irq_handler, > + IRQF_ONESHOT, > + irq_type->irq_name, > + &irq_data[i]); > + if (error) { > + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", > + irq_type->irq_name, irq, error); > + return error; > + } This leaks all previously requested interrupts.
Hi Esteban, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on linusw-pinctrl/for-next broonie-regulator/for-next abelloni/rtc-next linus/master v6.2 next-20230224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Esteban-Blanc/rtc-tps6594-add-driver-for-TPS6594-PMIC-RTC/20230224-213323 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20230224133129.887203-4-eblanc%40baylibre.com patch subject: [PATCH INTERNAL v1 3/3] regulator: tps6594-regulator: Add driver for TI TPS6594 regulators config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230225/202302250541.p9Kg2Tc6-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/740925ed262d27dda4f7b9af4c0173a845fa0578 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Esteban-Blanc/rtc-tps6594-add-driver-for-TPS6594-PMIC-RTC/20230224-213323 git checkout 740925ed262d27dda4f7b9af4c0173a845fa0578 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202302250541.p9Kg2Tc6-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/regulator/tps6594-regulator.c: In function 'tps6594_get_rdev_by_name': >> drivers/regulator/tps6594-regulator.c:342:59: warning: parameter 'dev' set but not used [-Wunused-but-set-parameter] 342 | struct regulator_dev *dev) | ~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/regulator/tps6594-regulator.c: In function 'tps6594_regulator_probe': >> drivers/regulator/tps6594-regulator.c:493:26: warning: ordered comparison of pointer with integer zero [-Wextra] 493 | if (rdev < 0) { | ^ >> drivers/regulator/tps6594-regulator.c:381:13: warning: variable 'multi_phase_case' set but not used [-Wunused-but-set-variable] 381 | int multi_phase_case = 0xFFFF; | ^~~~~~~~~~~~~~~~ >> drivers/regulator/tps6594-regulator.c:377:31: warning: variable 'rdevmultitbl' set but not used [-Wunused-but-set-variable] 377 | struct regulator_dev *rdevmultitbl[MULTI_PHASE_NB]; | ^~~~~~~~~~~~ vim +/dev +342 drivers/regulator/tps6594-regulator.c 338 339 static int tps6594_get_rdev_by_name(const char *regulator_name, 340 struct regulator_dev *rdevbucktbl[BUCK_NB], 341 struct regulator_dev *rdevldotbl[LDO_NB], > 342 struct regulator_dev *dev) 343 { 344 int i; 345 346 for (i = 0; i <= BUCK_NB; i++) { 347 if (strcmp(regulator_name, buck_regs[i].name) == 0) { 348 dev = rdevbucktbl[i]; 349 return 0; 350 } 351 } 352 353 for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { 354 if (strcmp(regulator_name, ldo_regs[i].name) == 0) { 355 dev = rdevldotbl[i]; 356 return 0; 357 } 358 } 359 return -EINVAL; 360 } 361 362 static int tps6594_regulator_probe(struct platform_device *pdev) 363 { 364 struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent); 365 struct regulator_dev *rdev; 366 struct regulator_config config = {}; 367 u8 buck_configured[BUCK_NB] = { 0 }; 368 u8 buck_multi[MULTI_PHASE_NB] = { 0 }; 369 int i; 370 int error; 371 int irq; 372 int ext_reg_irq_nb = 2; 373 struct tps6594_regulator_irq_data *irq_data; 374 struct tps6594_ext_regulator_irq_data *irq_ext_reg_data; 375 struct tps6594_regulator_irq_type *irq_type; 376 struct regulator_dev *rdevbucktbl[BUCK_NB]; > 377 struct regulator_dev *rdevmultitbl[MULTI_PHASE_NB]; 378 struct regulator_dev *rdevldotbl[LDO_NB]; 379 380 int multi_phase_id; > 381 int multi_phase_case = 0xFFFF; 382 383 config.dev = tps->dev; 384 config.driver_data = tps; 385 config.regmap = tps->regmap; 386 387 /* 388 * Switch case defines different possible multi phase config 389 * This is based on dts custom property: multi-phase-id 390 * Using compatible or device rev is a too complex alternative 391 * Default case is no Multiphase buck. 392 * In case of Multiphase configuration, value should be defined for 393 * buck_configured to avoid creating bucks for every buck in multiphase 394 */ 395 396 if (device_property_present(tps->dev, "ti,multi-phase-id")) { 397 device_property_read_u32(tps->dev, "ti,multi-phase-id", &multi_phase_id); 398 switch (multi_phase_id) { 399 case 12: 400 buck_multi[0] = 1; 401 buck_configured[0] = 1; 402 buck_configured[1] = 1; 403 multi_phase_case = TPS6594_BUCK_12; 404 break; 405 case 34: 406 buck_multi[1] = 1; 407 buck_configured[2] = 1; 408 buck_configured[3] = 1; 409 multi_phase_case = TPS6594_BUCK_34; 410 break; 411 case 123: 412 buck_multi[2] = 1; 413 buck_configured[0] = 1; 414 buck_configured[1] = 1; 415 buck_configured[2] = 1; 416 multi_phase_case = TPS6594_BUCK_123; 417 break; 418 case 1234: 419 buck_multi[3] = 1; 420 buck_configured[0] = 1; 421 buck_configured[1] = 1; 422 buck_configured[2] = 1; 423 buck_configured[3] = 1; 424 multi_phase_case = TPS6594_BUCK_1234; 425 break; 426 } 427 } 428 429 for (i = 0; i < MULTI_PHASE_NB; i++) { 430 if (buck_multi[i] == 0) 431 continue; 432 433 rdev = devm_regulator_register(&pdev->dev, &multi_regs[i], &config); 434 if (IS_ERR(rdev)) { 435 dev_err(tps->dev, "failed to register %s regulator\n", 436 pdev->name); 437 return PTR_ERR(rdev); 438 } 439 rdevmultitbl[i] = rdev; 440 } 441 442 if (tps->chip_id == LP8764X) 443 /* There is only 4 buck on LP8764X */ 444 buck_configured[4] = 1; 445 446 for (i = 0; i < BUCK_NB; i++) { 447 if (buck_configured[i] == 1) 448 continue; 449 450 rdev = devm_regulator_register(&pdev->dev, &buck_regs[i], &config); 451 if (IS_ERR(rdev)) { 452 dev_err(tps->dev, "failed to register %s regulator\n", 453 pdev->name); 454 return PTR_ERR(rdev); 455 } 456 rdevbucktbl[i] = rdev; 457 } 458 459 /* LP8764X dosen't have LDO */ 460 if (tps->chip_id != LP8764X) { 461 for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { 462 rdev = devm_regulator_register(&pdev->dev, &ldo_regs[i], &config); 463 if (IS_ERR(rdev)) { 464 dev_err(tps->dev, 465 "failed to register %s regulator\n", 466 pdev->name); 467 return PTR_ERR(rdev); 468 } 469 rdevldotbl[i] = rdev; 470 } 471 } 472 473 irq_data = devm_kmalloc(tps->dev, 474 ARRAY_SIZE(tps6594_regulator_irq_types) * 475 sizeof(struct tps6594_regulator_irq_data), 476 GFP_KERNEL); 477 if (!irq_data) 478 return -ENOMEM; 479 480 for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { 481 irq_type = &tps6594_regulator_irq_types[i]; 482 483 irq = platform_get_irq_byname(pdev, irq_type->irq_name); 484 if (irq < 0) 485 return -EINVAL; 486 487 irq_data[i].dev = tps->dev; 488 irq_data[i].type = irq_type; 489 490 tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, 491 rdevldotbl, rdev); 492 > 493 if (rdev < 0) { 494 dev_err(tps->dev, "Failed to get rdev for %s\n", 495 irq_type->regulator_name); 496 return -EINVAL; 497 } 498 irq_data[i].rdev = rdev; 499 500 error = devm_request_threaded_irq(tps->dev, irq, NULL, 501 tps6594_regulator_irq_handler, 502 IRQF_ONESHOT, 503 irq_type->irq_name, 504 &irq_data[i]); 505 if (error) { 506 dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", 507 irq_type->irq_name, irq, error); 508 return error; 509 } 510 } 511 512 if (tps->chip_id == LP8764X) 513 ext_reg_irq_nb = ARRAY_SIZE(tps6594_ext_regulator_irq_types); 514 515 irq_ext_reg_data = devm_kmalloc(tps->dev, 516 ext_reg_irq_nb * 517 sizeof(struct tps6594_ext_regulator_irq_data), 518 GFP_KERNEL); 519 if (!irq_ext_reg_data) 520 return -ENOMEM; 521 522 for (i = 0; i < ext_reg_irq_nb; ++i) { 523 irq_type = &tps6594_ext_regulator_irq_types[i]; 524 525 irq = platform_get_irq_byname(pdev, irq_type->irq_name); 526 if (irq < 0) 527 return -EINVAL; 528 529 irq_ext_reg_data[i].dev = tps->dev; 530 irq_ext_reg_data[i].type = irq_type; 531 532 error = devm_request_threaded_irq(tps->dev, irq, NULL, 533 tps6594_regulator_irq_handler, 534 IRQF_ONESHOT, 535 irq_type->irq_name, 536 &irq_ext_reg_data[i]); 537 if (error) { 538 dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", 539 irq_type->irq_name, irq, error); 540 return error; 541 } 542 } 543 544 return 0; 545 } 546
On 24/02/2023 15:05, Matti Vaittinen wrote: > Hi Esteban, > > On 2/24/23 15:31, Esteban Blanc wrote: >> From: Jerome Neanne <jneanne@baylibre.com> >> >> This patch adds support for TPS6594 regulators (bucks and LDOs). >> The output voltages are configurable and are meant to supply power >> to the main processor and other components. >> Bucks can be used in single or multiphase mode, depending on PMIC >> part number. >> >> Signed-off-by: Jerome Neanne <jneanne@baylibre.com> >> --- >> drivers/regulator/Kconfig | 12 + >> drivers/regulator/Makefile | 1 + >> drivers/regulator/tps6594-regulator.c | 559 ++++++++++++++++++++++++++ >> 3 files changed, 572 insertions(+) >> create mode 100644 drivers/regulator/tps6594-regulator.c >> >> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig >> index 820c9a0788e5..921540af6958 100644 >> --- a/drivers/regulator/Kconfig >> +++ b/drivers/regulator/Kconfig >> @@ -1432,6 +1432,18 @@ config REGULATOR_TPS65219 >> voltage regulators. It supports software based voltage control >> for different voltage domains. >> +config REGULATOR_TPS6594 >> + tristate "TI TPS6594 Power regulators" >> + depends on MFD_TPS6594 && OF >> + help >> + This driver supports TPS6594 voltage regulator chips. >> + TPS6594 series of PMICs have 5 BUCKs and 4 LDOs >> + voltage regulators. >> + BUCKs 1,2,3,4 can be used in single phase or multiphase mode. >> + Part number defines which single or multiphase mode is i used. >> + It supports software based voltage control >> + for different voltage domains. >> + >> config REGULATOR_TPS6524X >> tristate "TI TPS6524X Power regulators" >> depends on SPI >> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile >> index b9f5eb35bf5f..948b53f6156b 100644 >> --- a/drivers/regulator/Makefile >> +++ b/drivers/regulator/Makefile >> @@ -171,6 +171,7 @@ obj-$(CONFIG_REGULATOR_TPS6524X) += >> tps6524x-regulator.o >> obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o >> obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o >> obj-$(CONFIG_REGULATOR_TPS65912) += tps65912-regulator.o >> +obj-$(CONFIG_REGULATOR_TPS6594) += tps6594-regulator.o >> obj-$(CONFIG_REGULATOR_TPS65132) += tps65132-regulator.o >> obj-$(CONFIG_REGULATOR_TPS68470) += tps68470-regulator.o >> obj-$(CONFIG_REGULATOR_TWL4030) += twl-regulator.o twl6030-regulator.o >> diff --git a/drivers/regulator/tps6594-regulator.c >> b/drivers/regulator/tps6594-regulator.c >> new file mode 100644 >> index 000000000000..c099711fd460 >> --- /dev/null >> +++ b/drivers/regulator/tps6594-regulator.c >> @@ -0,0 +1,559 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Regulator driver for tps6594 PMIC >> + * >> + * Copyright (C) 2022 BayLibre Incorporated - https://www.baylibre.com/ >> + * >> + * This implementation derived from tps65218 authored by "J Keerthy >> <j-keerthy@ti.com>" >> + */ >> + >> +#include <linux/device.h> >> +#include <linux/err.h> >> +#include <linux/init.h> >> +#include <linux/kernel.h> >> +#include <linux/module.h> >> +#include <linux/of_device.h> >> +#include <linux/platform_device.h> >> +#include <linux/regmap.h> >> +#include <linux/regulator/driver.h> >> +#include <linux/regulator/machine.h> >> +#include <linux/regulator/of_regulator.h> >> + >> +#include <linux/mfd/tps6594.h> >> + >> +#define BUCK_NB 5 >> +#define LDO_NB 4 >> +#define MULTI_PHASE_NB 4 >> + >> +enum tps6594_regulator_id { >> + /* DCDC's */ >> + TPS6594_BUCK_1, >> + TPS6594_BUCK_2, >> + TPS6594_BUCK_3, >> + TPS6594_BUCK_4, >> + TPS6594_BUCK_5, >> + >> + /* LDOs */ >> + TPS6594_LDO_1, >> + TPS6594_LDO_2, >> + TPS6594_LDO_3, >> + TPS6594_LDO_4, >> +}; >> + >> +enum tps6594_multi_regulator_id { >> + /* Multi-phase DCDC's */ >> + TPS6594_BUCK_12, >> + TPS6594_BUCK_34, >> + TPS6594_BUCK_123, >> + TPS6594_BUCK_1234, >> +}; >> + >> +struct tps6594_regulator_irq_type { >> + const char *irq_name; >> + const char *regulator_name; >> + const char *event_name; >> + unsigned long event; >> +}; >> + >> +static struct tps6594_regulator_irq_type >> tps6594_regulator_irq_types[] = { >> + { TPS6594_IRQ_NAME_BUCK1_OV, "BUCK1", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_BUCK1_UV, "BUCK1", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, > > You have warning level IRQs - which is cool :) > > As warning level IRQs are used for non fatal errors, you probably would > like to also implement a mechanism for consumers to know when the > "warning is over" (assuming the HW provides the status information). > Maybe regulator_get_error_flags() would serve you? > > I'd be _really_ interested in hearing if you already have a use-case for > the warnings. I double checked with TI PMIC team and so far we don't have any routine. The requirement for upstream driver is to raise the warning to the processor nothing else. Up to the final customer to customize further. Note that it can be dangerous to handle in sw it in a generic way since those warnings might affect some regulators that is supplying some resources needed by the processor for correct behavior... > >> + { TPS6594_IRQ_NAME_BUCK1_SC, "BUCK1", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_BUCK1_ILIM, "BUCK1", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_BUCK2_OV, "BUCK2", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_BUCK2_UV, "BUCK2", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_BUCK2_SC, "BUCK2", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_BUCK2_ILIM, "BUCK2", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_BUCK3_OV, "BUCK3", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_BUCK3_UV, "BUCK3", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_BUCK3_SC, "BUCK3", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_BUCK3_ILIM, "BUCK3", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_BUCK4_OV, "BUCK4", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_BUCK4_UV, "BUCK4", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_BUCK4_SC, "BUCK4", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_BUCK4_ILIM, "BUCK4", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_BUCK5_OV, "BUCK5", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_BUCK5_UV, "BUCK5", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_BUCK5_SC, "BUCK5", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_BUCK5_ILIM, "BUCK5", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_LDO1_OV, "LDO1", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_LDO1_UV, "LDO1", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_LDO1_SC, "LDO1", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_LDO1_ILIM, "LDO1", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_LDO2_OV, "LDO2", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_LDO2_UV, "LDO2", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_LDO2_SC, "LDO2", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_LDO2_ILIM, "LDO2", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_LDO3_OV, "LDO3", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_LDO3_UV, "LDO3", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_LDO3_SC, "LDO3", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_LDO3_ILIM, "LDO3", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> + { TPS6594_IRQ_NAME_LDO4_OV, "LDO4", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_LDO4_UV, "LDO4", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_LDO4_SC, "LDO4", "short circuit", >> REGULATOR_EVENT_REGULATION_OUT }, >> + { TPS6594_IRQ_NAME_LDO4_ILIM, "LDO4", "reach ilim, overcurrent", >> + REGULATOR_EVENT_OVER_CURRENT }, >> +}; >> + >> +static struct tps6594_regulator_irq_type >> tps6594_ext_regulator_irq_types[] = { >> + { TPS6594_IRQ_NAME_VCCA_OV, "VCCA", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_VCCA_UV, "VCCA", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_VMON1_OV, "VMON1", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_VMON1_UV, "VMON1", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_VMON1_RV, "VMON1", "residual voltage", >> + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_VMON2_OV, "VMON2", "overvoltage", >> REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> + { TPS6594_IRQ_NAME_VMON2_UV, "VMON2", "undervoltage", >> REGULATOR_EVENT_UNDER_VOLTAGE }, >> + { TPS6594_IRQ_NAME_VMON2_RV, "VMON2", "residual voltage", >> + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, >> +}; >> + >> +struct tps6594_regulator_irq_data { >> + struct device *dev; >> + struct tps6594_regulator_irq_type *type; >> + struct regulator_dev *rdev; >> +}; >> + >> +struct tps6594_ext_regulator_irq_data { >> + struct device *dev; >> + struct tps6594_regulator_irq_type *type; >> +}; >> + >> + for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { >> + irq_type = &tps6594_regulator_irq_types[i]; >> + >> + irq = platform_get_irq_byname(pdev, irq_type->irq_name); >> + if (irq < 0) >> + return -EINVAL; >> + >> + irq_data[i].dev = tps->dev; >> + irq_data[i].type = irq_type; >> + >> + tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, >> + rdevldotbl, rdev); >> + >> + if (rdev < 0) { >> + dev_err(tps->dev, "Failed to get rdev for %s\n", >> + irq_type->regulator_name); >> + return -EINVAL; >> + } >> + irq_data[i].rdev = rdev; >> + >> + error = devm_request_threaded_irq(tps->dev, irq, NULL, >> + tps6594_regulator_irq_handler, >> + IRQF_ONESHOT, >> + irq_type->irq_name, >> + &irq_data[i]); >> + if (error) { >> + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", >> + irq_type->irq_name, irq, error); >> + return error; >> + } >> + } > > If I read this correctly, you have exact, 1 to 1 mapping from an IRQ to > regulator and event? Maybe you could slightly simplify the driver by > using the devm_regulator_irq_helper() and > regulator_irq_map_event_simple() with it's map-event? And if the > devm_regulator_irq_helper() does not work for you I'll be interested in > hearing if it could be improved. > I'll give it a try. Thanks
On 24/02/2023 14:42, Mark Brown wrote: > On Fri, Feb 24, 2023 at 02:31:29PM +0100, Esteban Blanc wrote: >> From: Jerome Neanne <jneanne@baylibre.com> >> >> This patch adds support for TPS6594 regulators (bucks and LDOs). >> The output voltages are configurable and are meant to supply power >> to the main processor and other components. >> Bucks can be used in single or multiphase mode, depending on PMIC >> part number. >> >> Signed-off-by: Jerome Neanne <jneanne@baylibre.com> >> --- > > You've not provided a Signed-off-by for this so I can't do anything with > it, please see Documentation/process/submitting-patches.rst for details > on what this is and why it's important. > I did this patch but Esteban sent the whole patch-list. The sign-off has not been updated accordingly. Sorry for disturbance. We'll fix that. >> @@ -0,0 +1,559 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Regulator driver for tps6594 PMIC >> + * >> + * Copyright (C) 2022 BayLibre Incorporated - https://www.baylibre.com/ > > Please make the entire comment block a C++ one so things look more > intentional. > >> +static unsigned int tps6594_get_mode(struct regulator_dev *dev) >> +{ >> + return REGULATOR_MODE_NORMAL; >> +} > > If configuring modes isn't supported just omit all mode operations. > >> + } >> + >> + regulator_notifier_call_chain(irq_data->rdev, >> + irq_data->type->event, NULL); >> + >> + dev_err(irq_data->dev, "Error IRQ trap %s for %s\n", >> + irq_data->type->event_name, irq_data->type->regulator_name); > > I suspect it might avoid future confusion to log the error before > notifying so that any consequences of the error more clearly happen in > response to the error. > I'll rework all that section for v2 following your recommendations >> +static int tps6594_get_rdev_by_name(const char *regulator_name, >> + struct regulator_dev *rdevbucktbl[BUCK_NB], >> + struct regulator_dev *rdevldotbl[LDO_NB], >> + struct regulator_dev *dev) >> +{ >> + int i; >> + >> + for (i = 0; i <= BUCK_NB; i++) { >> + if (strcmp(regulator_name, buck_regs[i].name) == 0) { >> + dev = rdevbucktbl[i]; >> + return 0; >> + } >> + } >> + >> + for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { >> + if (strcmp(regulator_name, ldo_regs[i].name) == 0) { >> + dev = rdevldotbl[i]; >> + return 0; >> + } >> + } >> + return -EINVAL; >> +} > >> + for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { >> + irq_type = &tps6594_regulator_irq_types[i]; >> + >> + irq = platform_get_irq_byname(pdev, irq_type->irq_name); >> + if (irq < 0) >> + return -EINVAL; >> + >> + irq_data[i].dev = tps->dev; >> + irq_data[i].type = irq_type; >> + >> + tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, >> + rdevldotbl, rdev); > > This would be simpler and you wouldn't need this lookup function if the > regulator descriptions included their IRQ names, then you could just > request the interrupts while registering the regulators. > >> + error = devm_request_threaded_irq(tps->dev, irq, NULL, >> + tps6594_regulator_irq_handler, >> + IRQF_ONESHOT, >> + irq_type->irq_name, >> + &irq_data[i]); >> + if (error) { >> + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", >> + irq_type->irq_name, irq, error); >> + return error; >> + } > > This leaks all previously requested interrupts. Thanks for your time and precious feedback.
On 2/24/23 14:31, Esteban Blanc wrote: > From: Jerome Neanne <jneanne@baylibre.com> > > This patch adds support for TPS6594 regulators (bucks and LDOs). > The output voltages are configurable and are meant to supply power > to the main processor and other components. > Bucks can be used in single or multiphase mode, depending on PMIC > part number. > > Signed-off-by: Jerome Neanne <jneanne@baylibre.com> > --- (...) > +static int tps6594_regulator_probe(struct platform_device *pdev) > +{ > + struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent); > + struct regulator_dev *rdev; > + struct regulator_config config = {}; > + u8 buck_configured[BUCK_NB] = { 0 }; > + u8 buck_multi[MULTI_PHASE_NB] = { 0 }; > + int i; > + int error; > + int irq; > + int ext_reg_irq_nb = 2; > + struct tps6594_regulator_irq_data *irq_data; > + struct tps6594_ext_regulator_irq_data *irq_ext_reg_data; > + struct tps6594_regulator_irq_type *irq_type; > + struct regulator_dev *rdevbucktbl[BUCK_NB]; > + struct regulator_dev *rdevmultitbl[MULTI_PHASE_NB]; > + struct regulator_dev *rdevldotbl[LDO_NB]; > + > + int multi_phase_id; > + int multi_phase_case = 0xFFFF; > + > + config.dev = tps->dev; > + config.driver_data = tps; > + config.regmap = tps->regmap; > + > + /* > + * Switch case defines different possible multi phase config > + * This is based on dts custom property: multi-phase-id > + * Using compatible or device rev is a too complex alternative > + * Default case is no Multiphase buck. > + * In case of Multiphase configuration, value should be defined for > + * buck_configured to avoid creating bucks for every buck in multiphase > + */ > + > + if (device_property_present(tps->dev, "ti,multi-phase-id")) { Question @ Mark/Liam: Shouldn't we use the generic 'regulator-coupled-with' property instead of 'ti,multi-phase-id' ? I am in charge of upstreaming dt-bindings and maintainers pointed out the similarity between 'multi-phase' and 'coupled' regulator concepts. Does 'regulator-coupled-with' mean that outputs of buck converters are combined ? If so, this generic property should replace our specific 'ti,multi-phase-id' prop, I guess. > + device_property_read_u32(tps->dev, "ti,multi-phase-id", &multi_phase_id); > + switch (multi_phase_id) { > + case 12: > + buck_multi[0] = 1; > + buck_configured[0] = 1; > + buck_configured[1] = 1; > + multi_phase_case = TPS6594_BUCK_12; > + break; > + case 34: > + buck_multi[1] = 1; > + buck_configured[2] = 1; > + buck_configured[3] = 1; > + multi_phase_case = TPS6594_BUCK_34; > + break; > + case 123: > + buck_multi[2] = 1; > + buck_configured[0] = 1; > + buck_configured[1] = 1; > + buck_configured[2] = 1; > + multi_phase_case = TPS6594_BUCK_123; > + break; > + case 1234: > + buck_multi[3] = 1; > + buck_configured[0] = 1; > + buck_configured[1] = 1; > + buck_configured[2] = 1; > + buck_configured[3] = 1; > + multi_phase_case = TPS6594_BUCK_1234; > + break; > + } > + } > + > + for (i = 0; i < MULTI_PHASE_NB; i++) { > + if (buck_multi[i] == 0) > + continue; > + > + rdev = devm_regulator_register(&pdev->dev, &multi_regs[i], &config); > + if (IS_ERR(rdev)) { > + dev_err(tps->dev, "failed to register %s regulator\n", > + pdev->name); > + return PTR_ERR(rdev); > + } > + rdevmultitbl[i] = rdev; > + } > + (...)
On Wed, Mar 22, 2023 at 10:10:23AM +0100, Julien Panis wrote: > Question @ Mark/Liam: > Shouldn't we use the generic 'regulator-coupled-with' property > instead of 'ti,multi-phase-id' ? My understanding was that this was a hardware configuration where two regulators operate as one with only one set of registers used for configuration. > I am in charge of upstreaming dt-bindings and maintainers > pointed out the similarity between 'multi-phase' and 'coupled' > regulator concepts. Does 'regulator-coupled-with' mean that > outputs of buck converters are combined ? If so, this generic > property should replace our specific 'ti,multi-phase-id' prop, > I guess. No, coupled regulators are regulators where the voltages can vary but there's a constraint that their configurations need to be related somehow, for example they must be within 200mV of each other or something like that.
On 3/22/23 14:13, Mark Brown wrote: > On Wed, Mar 22, 2023 at 10:10:23AM +0100, Julien Panis wrote: > >> Question @ Mark/Liam: >> Shouldn't we use the generic 'regulator-coupled-with' property >> instead of 'ti,multi-phase-id' ? > My understanding was that this was a hardware configuration where > two regulators operate as one with only one set of registers used > for configuration. Your understanding was correct. > >> I am in charge of upstreaming dt-bindings and maintainers >> pointed out the similarity between 'multi-phase' and 'coupled' >> regulator concepts. Does 'regulator-coupled-with' mean that >> outputs of buck converters are combined ? If so, this generic >> property should replace our specific 'ti,multi-phase-id' prop, >> I guess. > No, coupled regulators are regulators where the voltages can vary > but there's a constraint that their configurations need to be > related somehow, for example they must be within 200mV of each > other or something like that. OK, thank you for this explanation. So, we keep 'ti,multi-phase-id' property.
>> +static int tps6594_get_rdev_by_name(const char *regulator_name, >> + struct regulator_dev *rdevbucktbl[BUCK_NB], >> + struct regulator_dev *rdevldotbl[LDO_NB], >> + struct regulator_dev *dev) >> +{ >> + int i; >> + >> + for (i = 0; i <= BUCK_NB; i++) { >> + if (strcmp(regulator_name, buck_regs[i].name) == 0) { >> + dev = rdevbucktbl[i]; >> + return 0; >> + } >> + } >> + >> + for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { >> + if (strcmp(regulator_name, ldo_regs[i].name) == 0) { >> + dev = rdevldotbl[i]; >> + return 0; >> + } >> + } >> + return -EINVAL; >> +} > >> + for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { >> + irq_type = &tps6594_regulator_irq_types[i]; >> + >> + irq = platform_get_irq_byname(pdev, irq_type->irq_name); >> + if (irq < 0) >> + return -EINVAL; >> + >> + irq_data[i].dev = tps->dev; >> + irq_data[i].type = irq_type; >> + >> + tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, >> + rdevldotbl, rdev); > > This would be simpler and you wouldn't need this lookup function if the > regulator descriptions included their IRQ names, then you could just > request the interrupts while registering the regulators. I changed the code to follow your recommendations then now in case of a multiphase buck, only one set of interrupt is requested. ex: multiphase buck1234 single buck5 cat /proc/interrupts: 563: 0 0 tps6594-0-0x4c 0 Edge buck1_ov 564: 0 0 tps6594-0-0x4c 1 Edge buck1_uv 565: 0 0 tps6594-0-0x4c 2 Edge buck1_sc 566: 0 0 tps6594-0-0x4c 3 Edge buck1_ilim 579: 0 0 tps6594-0-0x4c 16 Edge buck5_ov 580: 0 0 tps6594-0-0x4c 17 Edge buck5_uv 581: 0 0 tps6594-0-0x4c 18 Edge buck5_sc 582: 0 0 tps6594-0-0x4c 19 Edge buck5_ilim buck2, buck3, buck4 are not associated to a regulator device because buck1 registers control all the multiphase bucks (only one logic regulator). Consequently the mapping for the associated interrupts does not occur. I'm not sure it's the right option. Do you suggest to keep it like that for multiphase? Is it better to request all the interrupts anyway and map it to the same rdev? > >> + error = devm_request_threaded_irq(tps->dev, irq, NULL, >> + tps6594_regulator_irq_handler, >> + IRQF_ONESHOT, >> + irq_type->irq_name, >> + &irq_data[i]); >> + if (error) { >> + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", >> + irq_type->irq_name, irq, error); >> + return error; >> + } > > This leaks all previously requested interrupts. I'm not sure to understand this sentence correctly. You mean all the interrupts already requested are still allocated after the error occurs?
On Thu, Mar 23, 2023 at 10:12:21AM +0100, jerome Neanne wrote: > > This would be simpler and you wouldn't need this lookup function if the > > regulator descriptions included their IRQ names, then you could just > > request the interrupts while registering the regulators. > I changed the code to follow your recommendations then now in case of a > multiphase buck, only one set of interrupt is requested. > buck2, buck3, buck4 are not associated to a regulator device because buck1 > registers control all the multiphase bucks (only one logic regulator). > Consequently the mapping for the associated interrupts does not occur. > I'm not sure it's the right option. > Do you suggest to keep it like that for multiphase? > Is it better to request all the interrupts anyway and map it to the same > rdev? Do the other interrupts do anything useful for this configuration? With a lot of hardware the whole control interface gets merged into one which includes the interrupts. > > > + error = devm_request_threaded_irq(tps->dev, irq, NULL, > > > + tps6594_regulator_irq_handler, > > > + IRQF_ONESHOT, > > > + irq_type->irq_name, > > > + &irq_data[i]); > > > + if (error) { > > > + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", > > > + irq_type->irq_name, irq, error); > > > + return error; > > > + } > > This leaks all previously requested interrupts. > I'm not sure to understand this sentence correctly. You mean all the > interrupts already requested are still allocated after the error occurs? Yes, I'd either not registered the devm or thought there was some other interrupt wasn't devm.
On 23/03/2023 12:38, Mark Brown wrote: > On Thu, Mar 23, 2023 at 10:12:21AM +0100, jerome Neanne wrote: > >>> This would be simpler and you wouldn't need this lookup function if the >>> regulator descriptions included their IRQ names, then you could just >>> request the interrupts while registering the regulators. > >> I changed the code to follow your recommendations then now in case of a >> multiphase buck, only one set of interrupt is requested. > >> buck2, buck3, buck4 are not associated to a regulator device because buck1 >> registers control all the multiphase bucks (only one logic regulator). >> Consequently the mapping for the associated interrupts does not occur. >> I'm not sure it's the right option. >> Do you suggest to keep it like that for multiphase? >> Is it better to request all the interrupts anyway and map it to the same >> rdev? > > Do the other interrupts do anything useful for this configuration? With > a lot of hardware the whole control interface gets merged into one which > includes the interrupts. > Discussed the point with TI in //. In case of multiphase buck ex: buck12 All the control is delegated to buck1 registers but there is still a possibility that an interrupt triggers on buck2 (overcurrent typically). I slightly changed the logic so that all the interrupts are registered even in multiphase mode. In that case interrupts for buck2 are attached to rdev buck12. >>>> + error = devm_request_threaded_irq(tps->dev, irq, NULL, >>>> + tps6594_regulator_irq_handler, >>>> + IRQF_ONESHOT, >>>> + irq_type->irq_name, >>>> + &irq_data[i]); >>>> + if (error) { >>>> + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", >>>> + irq_type->irq_name, irq, error); >>>> + return error; >>>> + } > >>> This leaks all previously requested interrupts. > >> I'm not sure to understand this sentence correctly. You mean all the >> interrupts already requested are still allocated after the error occurs? > > Yes, I'd either not registered the devm or thought there was some other > interrupt wasn't devm. All the interrupts are requested with devm, then should be fine.
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 820c9a0788e5..921540af6958 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -1432,6 +1432,18 @@ config REGULATOR_TPS65219 voltage regulators. It supports software based voltage control for different voltage domains. +config REGULATOR_TPS6594 + tristate "TI TPS6594 Power regulators" + depends on MFD_TPS6594 && OF + help + This driver supports TPS6594 voltage regulator chips. + TPS6594 series of PMICs have 5 BUCKs and 4 LDOs + voltage regulators. + BUCKs 1,2,3,4 can be used in single phase or multiphase mode. + Part number defines which single or multiphase mode is i used. + It supports software based voltage control + for different voltage domains. + config REGULATOR_TPS6524X tristate "TI TPS6524X Power regulators" depends on SPI diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index b9f5eb35bf5f..948b53f6156b 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -171,6 +171,7 @@ obj-$(CONFIG_REGULATOR_TPS6524X) += tps6524x-regulator.o obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o obj-$(CONFIG_REGULATOR_TPS65912) += tps65912-regulator.o +obj-$(CONFIG_REGULATOR_TPS6594) += tps6594-regulator.o obj-$(CONFIG_REGULATOR_TPS65132) += tps65132-regulator.o obj-$(CONFIG_REGULATOR_TPS68470) += tps68470-regulator.o obj-$(CONFIG_REGULATOR_TWL4030) += twl-regulator.o twl6030-regulator.o diff --git a/drivers/regulator/tps6594-regulator.c b/drivers/regulator/tps6594-regulator.c new file mode 100644 index 000000000000..c099711fd460 --- /dev/null +++ b/drivers/regulator/tps6594-regulator.c @@ -0,0 +1,559 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Regulator driver for tps6594 PMIC + * + * Copyright (C) 2022 BayLibre Incorporated - https://www.baylibre.com/ + * + * This implementation derived from tps65218 authored by "J Keerthy <j-keerthy@ti.com>" + */ + +#include <linux/device.h> +#include <linux/err.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/regulator/driver.h> +#include <linux/regulator/machine.h> +#include <linux/regulator/of_regulator.h> + +#include <linux/mfd/tps6594.h> + +#define BUCK_NB 5 +#define LDO_NB 4 +#define MULTI_PHASE_NB 4 + +enum tps6594_regulator_id { + /* DCDC's */ + TPS6594_BUCK_1, + TPS6594_BUCK_2, + TPS6594_BUCK_3, + TPS6594_BUCK_4, + TPS6594_BUCK_5, + + /* LDOs */ + TPS6594_LDO_1, + TPS6594_LDO_2, + TPS6594_LDO_3, + TPS6594_LDO_4, +}; + +enum tps6594_multi_regulator_id { + /* Multi-phase DCDC's */ + TPS6594_BUCK_12, + TPS6594_BUCK_34, + TPS6594_BUCK_123, + TPS6594_BUCK_1234, +}; + +struct tps6594_regulator_irq_type { + const char *irq_name; + const char *regulator_name; + const char *event_name; + unsigned long event; +}; + +static struct tps6594_regulator_irq_type tps6594_regulator_irq_types[] = { + { TPS6594_IRQ_NAME_BUCK1_OV, "BUCK1", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_BUCK1_UV, "BUCK1", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_BUCK1_SC, "BUCK1", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_BUCK1_ILIM, "BUCK1", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_BUCK2_OV, "BUCK2", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_BUCK2_UV, "BUCK2", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_BUCK2_SC, "BUCK2", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_BUCK2_ILIM, "BUCK2", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_BUCK3_OV, "BUCK3", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_BUCK3_UV, "BUCK3", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_BUCK3_SC, "BUCK3", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_BUCK3_ILIM, "BUCK3", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_BUCK4_OV, "BUCK4", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_BUCK4_UV, "BUCK4", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_BUCK4_SC, "BUCK4", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_BUCK4_ILIM, "BUCK4", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_BUCK5_OV, "BUCK5", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_BUCK5_UV, "BUCK5", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_BUCK5_SC, "BUCK5", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_BUCK5_ILIM, "BUCK5", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_LDO1_OV, "LDO1", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_LDO1_UV, "LDO1", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_LDO1_SC, "LDO1", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_LDO1_ILIM, "LDO1", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_LDO2_OV, "LDO2", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_LDO2_UV, "LDO2", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_LDO2_SC, "LDO2", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_LDO2_ILIM, "LDO2", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_LDO3_OV, "LDO3", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_LDO3_UV, "LDO3", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_LDO3_SC, "LDO3", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_LDO3_ILIM, "LDO3", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, + { TPS6594_IRQ_NAME_LDO4_OV, "LDO4", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_LDO4_UV, "LDO4", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_LDO4_SC, "LDO4", "short circuit", REGULATOR_EVENT_REGULATION_OUT }, + { TPS6594_IRQ_NAME_LDO4_ILIM, "LDO4", "reach ilim, overcurrent", + REGULATOR_EVENT_OVER_CURRENT }, +}; + +static struct tps6594_regulator_irq_type tps6594_ext_regulator_irq_types[] = { + { TPS6594_IRQ_NAME_VCCA_OV, "VCCA", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_VCCA_UV, "VCCA", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_VMON1_OV, "VMON1", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_VMON1_UV, "VMON1", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_VMON1_RV, "VMON1", "residual voltage", + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_VMON2_OV, "VMON2", "overvoltage", REGULATOR_EVENT_OVER_VOLTAGE_WARN }, + { TPS6594_IRQ_NAME_VMON2_UV, "VMON2", "undervoltage", REGULATOR_EVENT_UNDER_VOLTAGE }, + { TPS6594_IRQ_NAME_VMON2_RV, "VMON2", "residual voltage", + REGULATOR_EVENT_OVER_VOLTAGE_WARN }, +}; + +struct tps6594_regulator_irq_data { + struct device *dev; + struct tps6594_regulator_irq_type *type; + struct regulator_dev *rdev; +}; + +struct tps6594_ext_regulator_irq_data { + struct device *dev; + struct tps6594_regulator_irq_type *type; +}; + +#define TPS6594_REGULATOR(_name, _of, _id, _type, _ops, _n, _vr, _vm, _er, \ + _em, _cr, _cm, _lr, _nlr, _delay, _fuv, \ + _ct, _ncl, _bpm) \ + { \ + .name = _name, \ + .of_match = _of, \ + .regulators_node = of_match_ptr("regulators"), \ + .supply_name = _of, \ + .id = _id, \ + .ops = &(_ops), \ + .n_voltages = _n, \ + .type = _type, \ + .owner = THIS_MODULE, \ + .vsel_reg = _vr, \ + .vsel_mask = _vm, \ + .csel_reg = _cr, \ + .csel_mask = _cm, \ + .curr_table = _ct, \ + .n_current_limits = _ncl, \ + .enable_reg = _er, \ + .enable_mask = _em, \ + .volt_table = NULL, \ + .linear_ranges = _lr, \ + .n_linear_ranges = _nlr, \ + .ramp_delay = _delay, \ + .fixed_uV = _fuv, \ + .bypass_reg = _vr, \ + .bypass_mask = _bpm, \ + } \ + +static const struct linear_range bucks_ranges[] = { + REGULATOR_LINEAR_RANGE(300000, 0x0, 0xe, 20000), + REGULATOR_LINEAR_RANGE(600000, 0xf, 0x72, 5000), + REGULATOR_LINEAR_RANGE(1100000, 0x73, 0xaa, 10000), + REGULATOR_LINEAR_RANGE(1660000, 0xab, 0xff, 20000), +}; + +static const struct linear_range ldos_1_2_3_ranges[] = { + REGULATOR_LINEAR_RANGE(600000, 0x4, 0x3a, 50000), +}; + +static const struct linear_range ldos_4_ranges[] = { + REGULATOR_LINEAR_RANGE(1200000, 0x20, 0x74, 25000), +}; + +static unsigned int tps6594_get_mode(struct regulator_dev *dev) +{ + return REGULATOR_MODE_NORMAL; +} + +/* Operations permitted on BUCK1/2/3/4/5 */ +static const struct regulator_ops tps6594_bucks_ops = { + .is_enabled = regulator_is_enabled_regmap, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .get_mode = tps6594_get_mode, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, + .set_voltage_time_sel = regulator_set_voltage_time_sel, + +}; + +/* Operations permitted on LDO1/2/3 */ +static const struct regulator_ops tps6594_ldos_1_2_3_ops = { + .is_enabled = regulator_is_enabled_regmap, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .get_mode = tps6594_get_mode, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, + .set_bypass = regulator_set_bypass_regmap, + .get_bypass = regulator_get_bypass_regmap, +}; + +/* Operations permitted on LDO4 */ +static const struct regulator_ops tps6594_ldos_4_ops = { + .is_enabled = regulator_is_enabled_regmap, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .get_mode = tps6594_get_mode, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, +}; + +static const struct regulator_desc buck_regs[] = { + TPS6594_REGULATOR("BUCK1", "buck1", TPS6594_BUCK_1, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(0), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(0), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK2", "buck2", TPS6594_BUCK_2, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(1), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(1), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK3", "buck3", TPS6594_BUCK_3, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(2), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(2), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK4", "buck4", TPS6594_BUCK_4, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(3), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(3), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK5", "buck5", TPS6594_BUCK_5, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(4), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(4), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), +}; + +static const struct regulator_desc multi_regs[] = { + TPS6594_REGULATOR("BUCK12", "buck12", TPS6594_BUCK_1, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(1), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(1), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 4000, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK34", "buck34", TPS6594_BUCK_3, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(3), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(3), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 0, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK123", "buck123", TPS6594_BUCK_1, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(1), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(1), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 4000, 0, NULL, 0, 0), + TPS6594_REGULATOR("BUCK1234", "buck1234", TPS6594_BUCK_1, + REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_VOUT_1(1), + TPS6594_MASK_BUCKS_VSET, + TPS6594_REG_BUCKX_CTRL(1), + TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges, + 4, 4000, 0, NULL, 0, 0), +}; + +static const struct regulator_desc ldo_regs[] = { + TPS6594_REGULATOR("LDO1", "ldo1", TPS6594_LDO_1, + REGULATOR_VOLTAGE, tps6594_ldos_1_2_3_ops, TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_VOUT(0), + TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_CTRL(0), + TPS6594_BIT_LDO_EN, 0, 0, ldos_1_2_3_ranges, + 1, 0, 0, NULL, 0, TPS6594_BIT_LDO_BYPASS), + TPS6594_REGULATOR("LDO2", "ldo2", TPS6594_LDO_2, + REGULATOR_VOLTAGE, tps6594_ldos_1_2_3_ops, TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_VOUT(1), + TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_CTRL(1), + TPS6594_BIT_LDO_EN, 0, 0, ldos_1_2_3_ranges, + 1, 0, 0, NULL, 0, TPS6594_BIT_LDO_BYPASS), + TPS6594_REGULATOR("LDO3", "ldo3", TPS6594_LDO_3, + REGULATOR_VOLTAGE, tps6594_ldos_1_2_3_ops, TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_VOUT(2), + TPS6594_MASK_LDO123_VSET, + TPS6594_REG_LDOX_CTRL(2), + TPS6594_BIT_LDO_EN, 0, 0, ldos_1_2_3_ranges, + 1, 0, 0, NULL, 0, TPS6594_BIT_LDO_BYPASS), + TPS6594_REGULATOR("LDO4", "ldo4", TPS6594_LDO_4, + REGULATOR_VOLTAGE, tps6594_ldos_4_ops, TPS6594_MASK_LDO4_VSET >> 1, + TPS6594_REG_LDOX_VOUT(3), + TPS6594_MASK_LDO4_VSET, + TPS6594_REG_LDOX_CTRL(3), + TPS6594_BIT_LDO_EN, 0, 0, ldos_4_ranges, + 1, 0, 0, NULL, 0, 0), +}; + +static irqreturn_t tps6594_regulator_irq_handler(int irq, void *data) +{ + struct tps6594_regulator_irq_data *irq_data = data; + + if (irq_data->type->event_name[0] == '\0') { + /* This is the timeout interrupt no specific regulator */ + dev_err(irq_data->dev, + "System was put in shutdown due to timeout during an active or standby transition.\n"); + return IRQ_HANDLED; + } + + regulator_notifier_call_chain(irq_data->rdev, + irq_data->type->event, NULL); + + dev_err(irq_data->dev, "Error IRQ trap %s for %s\n", + irq_data->type->event_name, irq_data->type->regulator_name); + return IRQ_HANDLED; +} + +static int tps6594_get_rdev_by_name(const char *regulator_name, + struct regulator_dev *rdevbucktbl[BUCK_NB], + struct regulator_dev *rdevldotbl[LDO_NB], + struct regulator_dev *dev) +{ + int i; + + for (i = 0; i <= BUCK_NB; i++) { + if (strcmp(regulator_name, buck_regs[i].name) == 0) { + dev = rdevbucktbl[i]; + return 0; + } + } + + for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { + if (strcmp(regulator_name, ldo_regs[i].name) == 0) { + dev = rdevldotbl[i]; + return 0; + } + } + return -EINVAL; +} + +static int tps6594_regulator_probe(struct platform_device *pdev) +{ + struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent); + struct regulator_dev *rdev; + struct regulator_config config = {}; + u8 buck_configured[BUCK_NB] = { 0 }; + u8 buck_multi[MULTI_PHASE_NB] = { 0 }; + int i; + int error; + int irq; + int ext_reg_irq_nb = 2; + struct tps6594_regulator_irq_data *irq_data; + struct tps6594_ext_regulator_irq_data *irq_ext_reg_data; + struct tps6594_regulator_irq_type *irq_type; + struct regulator_dev *rdevbucktbl[BUCK_NB]; + struct regulator_dev *rdevmultitbl[MULTI_PHASE_NB]; + struct regulator_dev *rdevldotbl[LDO_NB]; + + int multi_phase_id; + int multi_phase_case = 0xFFFF; + + config.dev = tps->dev; + config.driver_data = tps; + config.regmap = tps->regmap; + + /* + * Switch case defines different possible multi phase config + * This is based on dts custom property: multi-phase-id + * Using compatible or device rev is a too complex alternative + * Default case is no Multiphase buck. + * In case of Multiphase configuration, value should be defined for + * buck_configured to avoid creating bucks for every buck in multiphase + */ + + if (device_property_present(tps->dev, "ti,multi-phase-id")) { + device_property_read_u32(tps->dev, "ti,multi-phase-id", &multi_phase_id); + switch (multi_phase_id) { + case 12: + buck_multi[0] = 1; + buck_configured[0] = 1; + buck_configured[1] = 1; + multi_phase_case = TPS6594_BUCK_12; + break; + case 34: + buck_multi[1] = 1; + buck_configured[2] = 1; + buck_configured[3] = 1; + multi_phase_case = TPS6594_BUCK_34; + break; + case 123: + buck_multi[2] = 1; + buck_configured[0] = 1; + buck_configured[1] = 1; + buck_configured[2] = 1; + multi_phase_case = TPS6594_BUCK_123; + break; + case 1234: + buck_multi[3] = 1; + buck_configured[0] = 1; + buck_configured[1] = 1; + buck_configured[2] = 1; + buck_configured[3] = 1; + multi_phase_case = TPS6594_BUCK_1234; + break; + } + } + + for (i = 0; i < MULTI_PHASE_NB; i++) { + if (buck_multi[i] == 0) + continue; + + rdev = devm_regulator_register(&pdev->dev, &multi_regs[i], &config); + if (IS_ERR(rdev)) { + dev_err(tps->dev, "failed to register %s regulator\n", + pdev->name); + return PTR_ERR(rdev); + } + rdevmultitbl[i] = rdev; + } + + if (tps->chip_id == LP8764X) + /* There is only 4 buck on LP8764X */ + buck_configured[4] = 1; + + for (i = 0; i < BUCK_NB; i++) { + if (buck_configured[i] == 1) + continue; + + rdev = devm_regulator_register(&pdev->dev, &buck_regs[i], &config); + if (IS_ERR(rdev)) { + dev_err(tps->dev, "failed to register %s regulator\n", + pdev->name); + return PTR_ERR(rdev); + } + rdevbucktbl[i] = rdev; + } + + /* LP8764X dosen't have LDO */ + if (tps->chip_id != LP8764X) { + for (i = 0; i < ARRAY_SIZE(ldo_regs); i++) { + rdev = devm_regulator_register(&pdev->dev, &ldo_regs[i], &config); + if (IS_ERR(rdev)) { + dev_err(tps->dev, + "failed to register %s regulator\n", + pdev->name); + return PTR_ERR(rdev); + } + rdevldotbl[i] = rdev; + } + } + + irq_data = devm_kmalloc(tps->dev, + ARRAY_SIZE(tps6594_regulator_irq_types) * + sizeof(struct tps6594_regulator_irq_data), + GFP_KERNEL); + if (!irq_data) + return -ENOMEM; + + for (i = 0; i < ARRAY_SIZE(tps6594_regulator_irq_types); ++i) { + irq_type = &tps6594_regulator_irq_types[i]; + + irq = platform_get_irq_byname(pdev, irq_type->irq_name); + if (irq < 0) + return -EINVAL; + + irq_data[i].dev = tps->dev; + irq_data[i].type = irq_type; + + tps6594_get_rdev_by_name(irq_type->regulator_name, rdevbucktbl, + rdevldotbl, rdev); + + if (rdev < 0) { + dev_err(tps->dev, "Failed to get rdev for %s\n", + irq_type->regulator_name); + return -EINVAL; + } + irq_data[i].rdev = rdev; + + error = devm_request_threaded_irq(tps->dev, irq, NULL, + tps6594_regulator_irq_handler, + IRQF_ONESHOT, + irq_type->irq_name, + &irq_data[i]); + if (error) { + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", + irq_type->irq_name, irq, error); + return error; + } + } + + if (tps->chip_id == LP8764X) + ext_reg_irq_nb = ARRAY_SIZE(tps6594_ext_regulator_irq_types); + + irq_ext_reg_data = devm_kmalloc(tps->dev, + ext_reg_irq_nb * + sizeof(struct tps6594_ext_regulator_irq_data), + GFP_KERNEL); + if (!irq_ext_reg_data) + return -ENOMEM; + + for (i = 0; i < ext_reg_irq_nb; ++i) { + irq_type = &tps6594_ext_regulator_irq_types[i]; + + irq = platform_get_irq_byname(pdev, irq_type->irq_name); + if (irq < 0) + return -EINVAL; + + irq_ext_reg_data[i].dev = tps->dev; + irq_ext_reg_data[i].type = irq_type; + + error = devm_request_threaded_irq(tps->dev, irq, NULL, + tps6594_regulator_irq_handler, + IRQF_ONESHOT, + irq_type->irq_name, + &irq_ext_reg_data[i]); + if (error) { + dev_err(tps->dev, "failed to request %s IRQ %d: %d\n", + irq_type->irq_name, irq, error); + return error; + } + } + + return 0; +} + +static struct platform_driver tps6594_regulator_driver = { + .driver = { + .name = "tps6594-regulator", + }, + .probe = tps6594_regulator_probe, +}; + +module_platform_driver(tps6594_regulator_driver); + +MODULE_ALIAS("platform:tps6594-regulator"); +MODULE_AUTHOR("Jerome Neanne <jneanne@baylibre.com>"); +MODULE_DESCRIPTION("TPS6594 voltage regulator driver"); +MODULE_LICENSE("GPL");