| Message ID | 20230317060917.15175-1-allen-kh.cheng@mediatek.com |
|---|---|
| Headers | show |
| Series | Add and update some driver nodes for MT8186 SoC | expand |
Il 17/03/23 07:09, Allen-KH Cheng ha scritto: > Add display nodes and the GCE (Global Command Engine) properties > to the display nodes in order to enable the usage of the CMDQ > (Command Queue), which is required for operating the display. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 125 +++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > index b9d5af26771e..29fb970e174e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > @@ -20,6 +20,13 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + ovl0 = &ovl0; > + ovl_2l0 = &ovl_2l0; > + rdma0 = &rdma0; > + rdma1 = &rdma1; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -1251,6 +1258,20 @@ > reg = <0 0x14000000 0 0x1000>; > #clock-cells = <1>; > #reset-cells = <1>; > + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>, > + <&gce 1 CMDQ_THR_PRIO_HIGHEST>; Fits in one line. > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>; > + }; > + > + mutex: mutex@14001000 { > + compatible = "mediatek,mt8186-disp-mutex"; > + reg = <0 0x14001000 0 0x1000>; > + clocks = <&mmsys CLK_MM_DISP_MUTEX0>; > + interrupts = <GIC_SPI 295 IRQ_TYPE_LEVEL_HIGH 0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>; > + mediatek,gce-events = <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_0>, > + <CMDQ_EVENT_DISP_STREAM_DONE_ENG_EVENT_1>; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > }; > > smi_common: smi@14002000 { > @@ -1284,6 +1305,49 @@ > power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > }; > > + ovl0: ovl@14005000 { > + compatible = "mediatek,mt8186-disp-ovl", > + "mediatek,mt8192-disp-ovl"; Fits in one line. > + reg = <0 0x14005000 0 0x1000>; > + clocks = <&mmsys CLK_MM_DISP_OVL0>; > + interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH 0>; > + iommus = <&iommu_mm IOMMU_PORT_L0_OVL_RDMA0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x5000 0x1000>; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + ovl_2l0: ovl@14006000 { > + compatible = "mediatek,mt8186-disp-ovl-2l", > + "mediatek,mt8192-disp-ovl-2l"; Same > + reg = <0 0x14006000 0 0x1000>; > + clocks = <&mmsys CLK_MM_DISP_OVL0_2L>; > + interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH 0>; > + iommus = <&iommu_mm IOMMU_PORT_L1_OVL_2L_RDMA0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x6000 0x1000>; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + rdma0: rdma@14007000 { > + compatible = "mediatek,mt8186-disp-rdma", > + "mediatek,mt8183-disp-rdma"; ditto > + reg = <0 0x14007000 0 0x1000>; > + clocks = <&mmsys CLK_MM_DISP_RDMA0>; > + interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH 0>; > + iommus = <&iommu_mm IOMMU_PORT_L1_DISP_RDMA0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x7000 0x1000>; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + color: color@14009000 { > + compatible = "mediatek,mt8186-disp-color", > + "mediatek,mt8173-disp-color"; again.... and again, and again, and again :-) Please compress the compatible strings in one single line here and in other instances of the same (ccorr/aal/gamma/dither/rdma). Postmask doesn't fit. After which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 17/03/23 07:09, Allen-KH Cheng ha scritto: > Add ADSP node for MT8186 SoC. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, Mar 17, 2023 at 2:10 PM Allen-KH Cheng <allen-kh.cheng@mediatek.com> wrote: > > Add audio controller node for MT8186 SoC. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 62 ++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) This patch is already merged in v6.1-rc1.
This series is based on linux for-next. Changes since v3: - Add index for ovl in aliases Changes since v2: - Remove some unnecessary linebreaks for some nodes - Use one line for some properties - Drop "Fix the fallback for mediatek, mt8186-disp-ccorr" patch (since this is applied in chunkuang.hu/linux.git/log/?h=mediatek-drm-next) - Separate GCE into another patch - Drop some patches which are appied in matthias github Changes since v1: - Remove the unnecessary trailing number - Add aliases for ovl* and rdma* Allen-KH Cheng (7): arm64: dts: mediatek: mt8186: Add MTU3 nodes dt-bindings: spmi: spmi-mtk-pmif: Document mediatek,mt8195-spmi as fallback of mediatek,mt8186-spmi arm64: dts: mediatek: mt8186: Add SPMI node arm64: dts: mediatek: mt8186: Add ADSP node arm64: dts: mediatek: mt8186: Add audio controller node arm64: dts: mediatek: mt8186: Add GCE node arm64: dts: mediatek: mt8186: Add display nodes .../bindings/spmi/mtk,spmi-mtk-pmif.yaml | 11 +- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 296 ++++++++++++++++++ 2 files changed, 304 insertions(+), 3 deletions(-)