| Message ID | 20230315064255.15591-6-manivannan.sadhasivam@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Qcom PCIe cleanups and improvements | expand |
On 15.03.2023 07:42, Manivannan Sadhasivam wrote: > To maintain uniformity, let's use lower case for representing hexadecimal > numbers. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- To be fair, preprocessor defines are the only place where uppercase hex is widely used Konrad > drivers/pci/controller/dwc/pcie-qcom.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 926a531fda3a..4179ac973147 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -39,17 +39,17 @@ > #define PARF_PCS_DEEMPH 0x34 > #define PARF_PCS_SWING 0x38 > #define PARF_PHY_CTRL 0x40 > -#define PARF_PHY_REFCLK 0x4C > +#define PARF_PHY_REFCLK 0x4c > #define PARF_CONFIG_BITS 0x50 > #define PARF_DBI_BASE_ADDR 0x168 > -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP ver 2.3.3 */ > +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */ > #define PARF_MHI_CLOCK_RESET_CTRL 0x174 > #define PARF_AXI_MSTR_WR_ADDR_HALT 0x178 > -#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8 > -#define PARF_Q2A_FLUSH 0x1AC > -#define PARF_LTSSM 0x1B0 > +#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1a8 > +#define PARF_Q2A_FLUSH 0x1ac > +#define PARF_LTSSM 0x1b0 > #define PARF_SID_OFFSET 0x234 > -#define PARF_BDF_TRANSLATE_CFG 0x24C > +#define PARF_BDF_TRANSLATE_CFG 0x24c > #define PARF_SLV_ADDR_SPACE_SIZE 0x358 > #define PARF_DEVICE_TYPE 0x1000 > #define PARF_BDF_TO_SID_TABLE_N 0x2000 > @@ -60,7 +60,7 @@ > /* DBI registers */ > #define AXI_MSTR_RESP_COMP_CTRL0 0x818 > #define AXI_MSTR_RESP_COMP_CTRL1 0x81c > -#define MISC_CONTROL_1_REG 0x8BC > +#define MISC_CONTROL_1_REG 0x8bc > > /* PARF_SYS_CTRL register fields */ > #define MAC_PHY_POWERDOWN_IN_P2_D_MUX_EN BIT(29)
On Wed, Mar 15, 2023 at 11:34:13AM +0100, Konrad Dybcio wrote: > > > On 15.03.2023 07:42, Manivannan Sadhasivam wrote: > > To maintain uniformity, let's use lower case for representing hexadecimal > > numbers. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > To be fair, preprocessor defines are the only place where uppercase > hex is widely used > I perfer lower hex all over the driver and in this case, I also want to match what is being done for pcie-qcom-ep so that it helps me in maintaining both drivers. Thanks, Mani > Konrad > > drivers/pci/controller/dwc/pcie-qcom.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 926a531fda3a..4179ac973147 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -39,17 +39,17 @@ > > #define PARF_PCS_DEEMPH 0x34 > > #define PARF_PCS_SWING 0x38 > > #define PARF_PHY_CTRL 0x40 > > -#define PARF_PHY_REFCLK 0x4C > > +#define PARF_PHY_REFCLK 0x4c > > #define PARF_CONFIG_BITS 0x50 > > #define PARF_DBI_BASE_ADDR 0x168 > > -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP ver 2.3.3 */ > > +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */ > > #define PARF_MHI_CLOCK_RESET_CTRL 0x174 > > #define PARF_AXI_MSTR_WR_ADDR_HALT 0x178 > > -#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8 > > -#define PARF_Q2A_FLUSH 0x1AC > > -#define PARF_LTSSM 0x1B0 > > +#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1a8 > > +#define PARF_Q2A_FLUSH 0x1ac > > +#define PARF_LTSSM 0x1b0 > > #define PARF_SID_OFFSET 0x234 > > -#define PARF_BDF_TRANSLATE_CFG 0x24C > > +#define PARF_BDF_TRANSLATE_CFG 0x24c > > #define PARF_SLV_ADDR_SPACE_SIZE 0x358 > > #define PARF_DEVICE_TYPE 0x1000 > > #define PARF_BDF_TO_SID_TABLE_N 0x2000 > > @@ -60,7 +60,7 @@ > > /* DBI registers */ > > #define AXI_MSTR_RESP_COMP_CTRL0 0x818 > > #define AXI_MSTR_RESP_COMP_CTRL1 0x81c > > -#define MISC_CONTROL_1_REG 0x8BC > > +#define MISC_CONTROL_1_REG 0x8bc > > > > /* PARF_SYS_CTRL register fields */ > > #define MAC_PHY_POWERDOWN_IN_P2_D_MUX_EN BIT(29)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 926a531fda3a..4179ac973147 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -39,17 +39,17 @@ #define PARF_PCS_DEEMPH 0x34 #define PARF_PCS_SWING 0x38 #define PARF_PHY_CTRL 0x40 -#define PARF_PHY_REFCLK 0x4C +#define PARF_PHY_REFCLK 0x4c #define PARF_CONFIG_BITS 0x50 #define PARF_DBI_BASE_ADDR 0x168 -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP ver 2.3.3 */ +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */ #define PARF_MHI_CLOCK_RESET_CTRL 0x174 #define PARF_AXI_MSTR_WR_ADDR_HALT 0x178 -#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8 -#define PARF_Q2A_FLUSH 0x1AC -#define PARF_LTSSM 0x1B0 +#define PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1a8 +#define PARF_Q2A_FLUSH 0x1ac +#define PARF_LTSSM 0x1b0 #define PARF_SID_OFFSET 0x234 -#define PARF_BDF_TRANSLATE_CFG 0x24C +#define PARF_BDF_TRANSLATE_CFG 0x24c #define PARF_SLV_ADDR_SPACE_SIZE 0x358 #define PARF_DEVICE_TYPE 0x1000 #define PARF_BDF_TO_SID_TABLE_N 0x2000 @@ -60,7 +60,7 @@ /* DBI registers */ #define AXI_MSTR_RESP_COMP_CTRL0 0x818 #define AXI_MSTR_RESP_COMP_CTRL1 0x81c -#define MISC_CONTROL_1_REG 0x8BC +#define MISC_CONTROL_1_REG 0x8bc /* PARF_SYS_CTRL register fields */ #define MAC_PHY_POWERDOWN_IN_P2_D_MUX_EN BIT(29)
To maintain uniformity, let's use lower case for representing hexadecimal numbers. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)