diff mbox series

[v3,02/17] cache: starfive: Add StarFive JH7110 support

Message ID 20230303032432.7837-3-yanhong.wang@starfivetech.com
State Superseded
Delegated to: Andes
Headers show
Series Basic StarFive JH7110 RISC-V SoC support | expand

Commit Message

Yanhong Wang March 3, 2023, 3:24 a.m. UTC
This adds support for the StarFive JH7110 SoC which also
feature this SiFive cache controller.

Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
---
 drivers/cache/cache-sifive-ccache.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley March 3, 2023, 9:07 p.m. UTC | #1
On Fri, Mar 03, 2023 at 11:24:17AM +0800, Yanhong Wang wrote:
> This adds support for the StarFive JH7110 SoC which also
> feature this SiFive cache controller.
> 
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
>  drivers/cache/cache-sifive-ccache.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cache/cache-sifive-ccache.c b/drivers/cache/cache-sifive-ccache.c
> index c8766f6242..c1bef0b4d3 100644
> --- a/drivers/cache/cache-sifive-ccache.c
> +++ b/drivers/cache/cache-sifive-ccache.c
> @@ -62,6 +62,7 @@ static int sifive_ccache_probe(struct udevice *dev)
>  static const struct udevice_id sifive_ccache_ids[] = {
>  	{ .compatible = "sifive,fu540-c000-ccache" },
>  	{ .compatible = "sifive,fu740-c000-ccache" },
> +	{ .compatible = "starfive,jh7110-ccache" },

Perhaps there's a u-boot policy I am not aware of, but why not just add
"sifive,ccache0" here instead, since the jh7110's ccache is compatible
with that?

Thanks,
Conor.
Yanhong Wang March 6, 2023, 1:56 a.m. UTC | #2
On 2023/3/4 5:07, Conor Dooley wrote:
> On Fri, Mar 03, 2023 at 11:24:17AM +0800, Yanhong Wang wrote:
>> This adds support for the StarFive JH7110 SoC which also
>> feature this SiFive cache controller.
>> 
>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>> ---
>>  drivers/cache/cache-sifive-ccache.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/cache/cache-sifive-ccache.c b/drivers/cache/cache-sifive-ccache.c
>> index c8766f6242..c1bef0b4d3 100644
>> --- a/drivers/cache/cache-sifive-ccache.c
>> +++ b/drivers/cache/cache-sifive-ccache.c
>> @@ -62,6 +62,7 @@ static int sifive_ccache_probe(struct udevice *dev)
>>  static const struct udevice_id sifive_ccache_ids[] = {
>>  	{ .compatible = "sifive,fu540-c000-ccache" },
>>  	{ .compatible = "sifive,fu740-c000-ccache" },
>> +	{ .compatible = "starfive,jh7110-ccache" },
> 
> Perhaps there's a u-boot policy I am not aware of, but why not just add
> "sifive,ccache0" here instead, since the jh7110's ccache is compatible
> with that?
> 

Thanks. I will add "sifive,ccache0" here instead.

> Thanks,
> Conor.
diff mbox series

Patch

diff --git a/drivers/cache/cache-sifive-ccache.c b/drivers/cache/cache-sifive-ccache.c
index c8766f6242..c1bef0b4d3 100644
--- a/drivers/cache/cache-sifive-ccache.c
+++ b/drivers/cache/cache-sifive-ccache.c
@@ -62,6 +62,7 @@  static int sifive_ccache_probe(struct udevice *dev)
 static const struct udevice_id sifive_ccache_ids[] = {
 	{ .compatible = "sifive,fu540-c000-ccache" },
 	{ .compatible = "sifive,fu740-c000-ccache" },
+	{ .compatible = "starfive,jh7110-ccache" },
 	{}
 };